mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-04-29 14:59:39 -04:00
Similarly to the serialization reads optimization, buffered writes will enable batched XOR calculations. This is especially beneficial since the current implementation requires copying the write input's `std::span` to perform obfuscation. Batching allows us to apply XOR operations on the internal buffer instead, reducing unnecessary data copying and improving performance. ------ > macOS Sequoia 15.3.1 > C++ compiler .......................... Clang 19.1.7 > cmake -B build -DBUILD_BENCH=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ && cmake --build build -j$(nproc) && build/bin/bench_bitcoin -filter='WriteBlockBench' -min-time=10000 Before: | ns/op | op/s | err% | total | benchmark |--------------------:|--------------------:|--------:|----------:|:---------- | 5,149,564.31 | 194.19 | 0.8% | 10.95 | `WriteBlockBench` After: | ns/op | op/s | err% | total | benchmark |--------------------:|--------------------:|--------:|----------:|:---------- | 2,990,564.63 | 334.39 | 1.5% | 11.27 | `WriteBlockBench` ------ > Ubuntu 24.04.2 LTS > C++ compiler .......................... GNU 13.3.0 > cmake -B build -DBUILD_BENCH=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ && cmake --build build -j$(nproc) && build/bin/bench_bitcoin -filter='WriteBlockBench' -min-time=20000 Before: | ns/op | op/s | err% | ins/op | cyc/op | IPC | bra/op | miss% | total | benchmark |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:---------- | 5,152,973.58 | 194.06 | 2.2% | 19,350,886.41 | 8,784,539.75 | 2.203 | 3,079,335.21 | 0.4% | 23.18 | `WriteBlockBench` After: | ns/op | op/s | err% | ins/op | cyc/op | IPC | bra/op | miss% | total | benchmark |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:---------- | 4,145,681.13 | 241.21 | 4.0% | 15,337,596.85 | 5,732,186.47 | 2.676 | 2,239,662.64 | 0.1% | 23.94 | `WriteBlockBench` Co-authored-by: Ryan Ofsky <ryan@ofsky.org> Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
126 lines
4 KiB
C++
126 lines
4 KiB
C++
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or https://opensource.org/license/mit/.
|
|
|
|
#include <memusage.h>
|
|
#include <span.h>
|
|
#include <streams.h>
|
|
#include <util/fs_helpers.h>
|
|
|
|
#include <array>
|
|
|
|
AutoFile::AutoFile(std::FILE* file, std::vector<std::byte> data_xor)
|
|
: m_file{file}, m_xor{std::move(data_xor)}
|
|
{
|
|
if (!IsNull()) {
|
|
auto pos{std::ftell(m_file)};
|
|
if (pos >= 0) m_position = pos;
|
|
}
|
|
}
|
|
|
|
std::size_t AutoFile::detail_fread(std::span<std::byte> dst)
|
|
{
|
|
if (!m_file) throw std::ios_base::failure("AutoFile::read: file handle is nullptr");
|
|
size_t ret = std::fread(dst.data(), 1, dst.size(), m_file);
|
|
if (!m_xor.empty()) {
|
|
if (!m_position.has_value()) throw std::ios_base::failure("AutoFile::read: position unknown");
|
|
util::Xor(dst.subspan(0, ret), m_xor, *m_position);
|
|
}
|
|
if (m_position.has_value()) *m_position += ret;
|
|
return ret;
|
|
}
|
|
|
|
void AutoFile::seek(int64_t offset, int origin)
|
|
{
|
|
if (IsNull()) {
|
|
throw std::ios_base::failure("AutoFile::seek: file handle is nullptr");
|
|
}
|
|
if (std::fseek(m_file, offset, origin) != 0) {
|
|
throw std::ios_base::failure(feof() ? "AutoFile::seek: end of file" : "AutoFile::seek: fseek failed");
|
|
}
|
|
if (origin == SEEK_SET) {
|
|
m_position = offset;
|
|
} else if (origin == SEEK_CUR && m_position.has_value()) {
|
|
*m_position += offset;
|
|
} else {
|
|
int64_t r{std::ftell(m_file)};
|
|
if (r < 0) {
|
|
throw std::ios_base::failure("AutoFile::seek: ftell failed");
|
|
}
|
|
m_position = r;
|
|
}
|
|
}
|
|
|
|
int64_t AutoFile::tell()
|
|
{
|
|
if (!m_position.has_value()) throw std::ios_base::failure("AutoFile::tell: position unknown");
|
|
return *m_position;
|
|
}
|
|
|
|
void AutoFile::read(std::span<std::byte> dst)
|
|
{
|
|
if (detail_fread(dst) != dst.size()) {
|
|
throw std::ios_base::failure(feof() ? "AutoFile::read: end of file" : "AutoFile::read: fread failed");
|
|
}
|
|
}
|
|
|
|
void AutoFile::ignore(size_t nSize)
|
|
{
|
|
if (!m_file) throw std::ios_base::failure("AutoFile::ignore: file handle is nullptr");
|
|
unsigned char data[4096];
|
|
while (nSize > 0) {
|
|
size_t nNow = std::min<size_t>(nSize, sizeof(data));
|
|
if (std::fread(data, 1, nNow, m_file) != nNow) {
|
|
throw std::ios_base::failure(feof() ? "AutoFile::ignore: end of file" : "AutoFile::ignore: fread failed");
|
|
}
|
|
nSize -= nNow;
|
|
if (m_position.has_value()) *m_position += nNow;
|
|
}
|
|
}
|
|
|
|
void AutoFile::write(std::span<const std::byte> src)
|
|
{
|
|
if (!m_file) throw std::ios_base::failure("AutoFile::write: file handle is nullptr");
|
|
if (m_xor.empty()) {
|
|
if (std::fwrite(src.data(), 1, src.size(), m_file) != src.size()) {
|
|
throw std::ios_base::failure("AutoFile::write: write failed");
|
|
}
|
|
if (m_position.has_value()) *m_position += src.size();
|
|
} else {
|
|
std::array<std::byte, 4096> buf;
|
|
while (src.size()) {
|
|
auto buf_now{std::span{buf}.first(std::min<size_t>(src.size(), buf.size()))};
|
|
std::copy_n(src.begin(), buf_now.size(), buf_now.begin());
|
|
write_buffer(buf_now);
|
|
src = src.subspan(buf_now.size());
|
|
}
|
|
}
|
|
}
|
|
|
|
void AutoFile::write_buffer(std::span<std::byte> src)
|
|
{
|
|
if (!m_file) throw std::ios_base::failure("AutoFile::write_buffer: file handle is nullptr");
|
|
if (m_xor.size()) {
|
|
if (!m_position) throw std::ios_base::failure("AutoFile::write_buffer: obfuscation position unknown");
|
|
util::Xor(src, m_xor, *m_position); // obfuscate in-place
|
|
}
|
|
if (std::fwrite(src.data(), 1, src.size(), m_file) != src.size()) {
|
|
throw std::ios_base::failure("AutoFile::write_buffer: write failed");
|
|
}
|
|
if (m_position) *m_position += src.size();
|
|
}
|
|
|
|
bool AutoFile::Commit()
|
|
{
|
|
return ::FileCommit(m_file);
|
|
}
|
|
|
|
bool AutoFile::Truncate(unsigned size)
|
|
{
|
|
return ::TruncateFile(m_file, size);
|
|
}
|
|
|
|
size_t DataStream::GetMemoryUsage() const noexcept
|
|
{
|
|
return sizeof(*this) + memusage::DynamicUsage(vch);
|
|
}
|