mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-25 10:43:19 -03:00

Bitcoin Core mirror and no, I don't give a fuck about Monero.

bitcoin c-plus-plus cryptocurrency cryptography p2p

Find a file

MarcoFalke 4e1de1fc59 Merge bitcoin/bitcoin#22340 : p2p: Use legacy relaying to download blocks in blocks-only mode `18c5b23a0f` [test] Test that -blocksonly nodes still serve compact blocks. (Niklas Gögge) `a79ad65fc2` [test] Test that getdata(CMPCT) is still sent on regular low bandwidth connections. (Niklas Gögge) `5e231c116b` [test] Test that -blocksonly nodes do not send getdata(CMPCT) on a low bandwidth connection. (Niklas Gögge) `5bf6587457` [test] Test that -blocksonly nodes do not request high bandwidth mode. (Niklas Gögge) `0dc8bf5b92` [net processing] Dont request compact blocks in blocks-only mode (Niklas Gögge) Pull request description: A blocks-only node does not participate in transaction relay to reduce its own bandwidth usage and therefore does not have a mempool. The use of compact blocks is not beneficial to such a node since it will always have to download full blocks. In both high- and low-bandwidth relaying the `cmpctblock` message is sent. This represent a bandwidth overhead for blocks-only nodes because the `cmpctblock` message is several times larger in the average case than the equivalent `headers` or `inv` announcement. ![compact blocks](https://raw.githubusercontent.com/bitcoin/bips/master/bip-0152/protocol-flow.png) >Example: >A block with 2000 txs results in a `cmpctblock` with 2000*6 bytes in short ids. This is several times larger than the equivalent 82 bytes for a `headers` message or 37 bytes for an `inv`. ## Approach This PR makes blocks-only nodes always use the legacy relaying to download new blocks. It does so by making blocks-only nodes never initiate a high-bandwidth block relay connection by disabling the sending of `sendcmpct(1)`. Additionally a blocks-only node will never request a compact block using `getdata(CMPCT)`. A blocks-only node will continue to serve compact blocks to its peers in both high- and low-bandwidth mode. ACKs for top commit: naumenkogs: ACK `18c5b23a0f` rajarshimaitra: tACK `18c5b23a0f` jnewbery: reACK `18c5b23a0f` theStack: re-ACK `18c5b23a0f` 🥛 Tree-SHA512: 0c78804aa397513d41f97fe314efb815efcd852d452dd903df9d4749280cd3faaa010fa9b51d7d5168b8a77e08c8ab0a491ecdbdb3202f2e9cd5137cddc74624		2021-10-01 08:16:54 +02:00
.github	doc: Remove label from good first issue template	2020-08-24 09:31:24 +02:00
.tx	qt: Bump transifex slug for 22.x	2021-04-21 13:46:41 +02:00
build-aux/m4	build, qt: Fix typo in QtInputSupport check	2021-08-27 17:50:30 +03:00
build_msvc	Merge bitcoin/bitcoin#22219 : multiprocess: Start using init makeNode, makeChain, etc methods	2021-09-16 08:47:38 +08:00
ci	ci: update minimum compiler requirements for std::filesystem	2021-09-22 18:18:19 +08:00
contrib	Merge bitcoin/bitcoin#22993 : build: set OSX_MIN_VERSION to 10.15	2021-09-21 15:37:12 +08:00
depends	build: set OSX_MIN_VERSION to 10.15	2021-09-16 17:50:19 +08:00
doc	Merge bitcoin/bitcoin#23123 : Remove `-rescan` startup parameter	2021-09-30 20:49:40 +02:00
share	Remove -rescan startup parameter	2021-09-30 12:06:27 +13:00
src	Merge bitcoin/bitcoin#22340 : p2p: Use legacy relaying to download blocks in blocks-only mode	2021-10-01 08:16:54 +02:00
test	Merge bitcoin/bitcoin#22340 : p2p: Use legacy relaying to download blocks in blocks-only mode	2021-10-01 08:16:54 +02:00
.cirrus.yml	ci: Enable extended tests on native Windows	2021-09-28 20:12:36 +02:00
.editorconfig	ci: Drop AppVeyor CI integration	2021-09-07 06:12:53 +03:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	build: add *~ to .gitignore	2021-05-12 18:10:47 +02:00
.python-version	Bump minimum python version to 3.6	2020-11-09 17:53:47 +10:00
.style.yapf	test: .style.yapf: Set column_limit=160	2019-03-04 18:28:13 -05:00
autogen.sh	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
configure.ac	build: remove support for weak linking getauxval()	2021-09-24 15:40:04 +08:00
CONTRIBUTING.md	Enable TLS in links in documentation	2021-09-16 22:00:20 +00:00
COPYING	doc: Update license year range to 2021	2020-12-30 16:24:47 +01:00
INSTALL.md	doc: Added hyperlink for doc/build	2021-09-09 19:53:12 +05:30
libbitcoinconsensus.pc.in	build: remove libcrypto as internal dependency in libbitcoinconsensus.pc	2019-11-19 15:03:44 +01:00
Makefile.am	test: Rename bitcoin-util-test.py to util/test_runner.py	2021-09-02 10:43:19 +02:00
README.md	Squashed 'src/crc32c/' changes from b5ef9be675..0d624261ef	2021-09-29 14:09:01 +02:00
REVIEWERS	release: remove gitian	2021-08-31 09:37:23 +08:00
SECURITY.md	doc: Remove explicit mention of version from SECURITY.md	2019-06-14 06:39:17 -04:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

Further information about Bitcoin Core is available in the doc folder.

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information read the original Bitcoin whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.