bitcoin/src
practicalswift 343ba8fef5 [wallet] Remove redundant initialization
Prior to this commit pindexRescan was initialized to a chainActive.Tip().
However, the value of pindexRescan set at time of initialization was never
read before pindexRescan was being set to either chainActive.Genesis()
(case 1), FindForkInGlobalIndex(chainActive, locator) (case 2) or
chainActive.Genesis() (case 3). Thus, the initialization was redundant.

This commit a.) removes the redundant initialization and b.) simplifies
this logic so that pindexRescan is initialized to chainActive.Genesis()
(case 1 and 3), and set to FindForkInGlobalIndex(chainActive, locator)
(case 2) as needed.
2017-02-28 16:54:43 +01:00
..
bench bench: Fix initialization order in registration 2017-02-07 19:07:29 +01:00
compat Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
config
consensus [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
crypto Avoid unaligned access in crypto i/o 2017-01-12 11:52:45 -08:00
leveldb Merge in LevelDB 1.19 changes 2016-12-01 16:14:45 -08:00
obj
obj-test
policy Remove harmless read of unusued priority estimates 2017-02-21 11:12:44 -05:00
primitives Merge #9283: A few more CTransactionRef optimizations 2017-01-04 12:23:10 +01:00
qt Trivial: fix comments referencing AppInit2 2017-02-24 09:19:29 +09:00
rpc Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). 2017-02-26 14:01:05 +01:00
script Trivial: fix comments referencing AppInit2 2017-02-24 09:19:29 +09:00
secp256k1 Update libsecp256k1 to master 2016-12-12 11:08:47 -08:00
support Merge #9387: [Refactor] RAII of libevent stuff using unique ptrs with deleters 2017-01-05 11:11:17 +01:00
test Merge #9867: Replace remaining sprintf with snprintf 2017-02-28 12:02:44 +01:00
univalue Merge commit '2ca7faab4205822b06dc2ab2bbda0a9a70fce7e0' into HEAD 2016-09-30 19:58:11 +02:00
wallet [wallet] Remove redundant initialization 2017-02-28 16:54:43 +01:00
zmq Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
.clang-format [doc] Remove unused clang format dev script 2017-01-28 16:57:08 +01:00
addrdb.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
addrdb.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
addrman.cpp Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0; 2017-02-07 15:46:38 +01:00
addrman.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
amount.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
amount.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
arith_uint256.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
arith_uint256.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
base58.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
base58.h [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
bitcoin-cli-res.rc Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
bitcoin-cli.cpp rpc: Named argument support for bitcoin-cli 2017-01-10 12:04:54 +01:00
bitcoin-tx-res.rc Update Windows resource files (and add one for bitcoin-tx) 2015-05-22 02:56:55 +00:00
bitcoin-tx.cpp Merge #8883: Add all standard TXO types to bitcoin-tx 2017-01-12 12:24:35 +01:00
bitcoind-res.rc Update Windows resource files (and add one for bitcoin-tx) 2015-05-22 02:56:55 +00:00
bitcoind.cpp use EXIT_ codes instead of magic numbers 2017-02-21 17:17:24 +09:00
blockencodings.cpp Clarify comment about mempool/extra conflicts 2017-01-16 22:58:06 -05:00
blockencodings.h [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
bloom.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
bloom.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
chain.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
chain.h Replace FindLatestBefore used by importmuti with FindEarliestAtLeast. 2017-01-12 14:21:43 +00:00
chainparams.cpp Add seed.btc.petertodd.org to mainnet DNS seeds 2017-02-19 16:11:54 -05:00
chainparams.h Shorten variable names and switch to tx/s 2017-01-11 08:21:37 -08:00
chainparamsbase.cpp Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
chainparamsbase.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
chainparamsseeds.h Pre-0.14.0 hardcoded seeds update 2017-02-10 11:04:34 +01:00
checkpoints.cpp [MOVEONLY] Move progress estimation out of checkpoints 2017-01-04 13:18:49 -08:00
checkpoints.h [MOVEONLY] Move progress estimation out of checkpoints 2017-01-04 13:18:49 -08:00
checkqueue.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
clientversion.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
clientversion.h build: bump version to 0.14.99 2017-02-17 17:27:18 +01:00
coins.cpp Check FRESH validity in CCoinsViewCache::BatchWrite 2017-01-04 14:56:17 -05:00
coins.h Merge #9107: Safer modify new coins 2017-01-04 11:56:17 -08:00
compat.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
compressor.cpp Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
compressor.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
core_io.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
core_memusage.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
core_read.cpp Fail in DecodeHexTx if there is extra data at the end 2017-02-02 17:32:27 -05:00
core_write.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
cuckoocache.h [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
dbwrapper.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
dbwrapper.h Merge #9353: Add data() method to CDataStream (and use it) 2017-01-09 08:47:47 -08:00
hash.cpp Remove redundant semicolons 2017-01-14 21:45:32 +01:00
hash.h Avoid VLA in hash.h 2017-02-17 15:28:28 -08:00
httprpc.cpp Make KEY_SIZE a compile-time constant 2017-02-17 11:42:22 -08:00
httprpc.h evhttpd implementation 2015-09-03 10:59:18 +02:00
httpserver.cpp Access WorkQueue::running only within the cs lock. 2017-02-03 13:50:17 -05:00
httpserver.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
indirectmap.h prepend license statement to indirectmap 2016-07-27 16:27:07 -07:00
init.cpp Merge #9822: Remove block file location upgrade code 2017-02-28 12:31:33 +01:00
init.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
key.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
key.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
keystore.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
keystore.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
limitedmap.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
Makefile.am build: add --enable-werror option 2017-02-23 01:06:04 -05:00
Makefile.bench.include Add Basic CheckQueue Benchmark 2017-01-09 14:07:02 -05:00
Makefile.leveldb.include Merge #8826: Do not include env_win.cc on non-Windows systems 2016-09-29 17:27:28 +02:00
Makefile.qt.include Merge #9513: build: fix qt distdir builds (retry) 2017-01-11 13:45:28 +01:00
Makefile.qttest.include Uses built-in byte swap if available (Apple) and if bswap_XX is undefined. 2016-12-17 12:27:00 +09:00
Makefile.test.include Merge #9525: test: Include tx data in EXTRA_DIST 2017-01-12 13:41:32 +01:00
memusage.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
merkleblock.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
merkleblock.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
miner.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
miner.h Introduce -blockmintxfee 2017-01-04 13:24:19 -05:00
net.cpp Merge #9715: Disconnect peers which we do not receive VERACKs from within 60 sec 2017-02-14 14:35:15 +01:00
net.h Move CNode::addrLocal access behind locked accessors 2017-02-10 11:32:41 -05:00
net_processing.cpp Merge #9720: net: fix banning and disallow sending messages before receiving verack 2017-02-14 14:42:29 +01:00
net_processing.h Net: pass interruptMsgProc as const where possible 2017-01-31 23:45:47 +01:00
netaddress.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
netaddress.h [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
netbase.cpp netbase: Do not print an error on connection timeouts through proxy 2017-02-09 08:53:22 +01:00
netbase.h Merge #9289: net: drop boost::thread_group 2017-01-04 12:21:53 +01:00
netmessagemaker.h Net: Make CNetMsgMaker more const 2017-01-31 23:29:28 +01:00
noui.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
noui.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
pow.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
pow.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
prevector.h prevector: assert successful allocation 2017-02-27 14:52:15 -05:00
protocol.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
protocol.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
pubkey.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
pubkey.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
random.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
random.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
rest.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
reverselock.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
scheduler.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
scheduler.h More robust CScheduler unit test 2015-05-16 17:59:23 -04:00
serialize.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
streams.h Merge #9353: Add data() method to CDataStream (and use it) 2017-01-09 08:47:47 -08:00
sync.cpp Further-enforce lockordering by enforcing directly after TRY_LOCKs 2017-02-07 14:15:28 -05:00
sync.h Break addnode out from the outbound connection limits. 2017-01-05 19:02:09 +00:00
threadinterrupt.cpp net: add CThreadInterrupt and InterruptibleSleep 2017-01-03 17:53:09 -05:00
threadinterrupt.h net: add CThreadInterrupt and InterruptibleSleep 2017-01-03 17:53:09 -05:00
threadsafety.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
timedata.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
timedata.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
tinyformat.h util: Update tinyformat 2016-06-27 18:17:27 +02:00
torcontrol.cpp [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
torcontrol.h torcontrol improvements and fixes 2015-11-12 17:58:15 +01:00
txdb.cpp Refactor: Remove using namespace <xxx> from src/*.cpp. 2017-01-27 18:13:20 +09:00
txdb.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
txmempool.cpp Removed redundant parameter from mempool.PrioritiseTransaction 2017-02-21 20:44:23 -07:00
txmempool.h Merge #9732: [Trivial] Remove nonsense #undef foreach 2017-02-28 12:29:43 +01:00
ui_interface.cpp [wallet] Add high transaction fee warnings 2016-09-26 01:11:27 +02:00
ui_interface.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
uint256.cpp uint256: replace sprintf with HexStr and reverse-iterator 2017-02-27 10:02:45 +01:00
uint256.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
undo.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
util.cpp Fix for issue #9775. Added check for open() returning a NULL pointer. 2017-02-20 23:53:18 +05:30
util.h Merge #9417: Do not evaluate hidden LogPrint arguments 2017-01-05 10:49:00 +01:00
utilmoneystr.cpp Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
utilmoneystr.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
utilstrencodings.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
utilstrencodings.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
utiltime.cpp [trivial] Fix typos in comments 2017-01-27 21:22:35 +01:00
utiltime.h [trivial] Fix recently introduced typos in comments 2017-02-14 20:19:40 +01:00
validation.cpp Merge #9773: Return errors from importmulti if complete rescans are not successful 2017-02-22 12:43:11 +01:00
validation.h Return errors from importmulti if complete rescans are not successful 2017-02-17 14:12:31 -05:00
validationinterface.cpp Add a CValidationInterface::NewPoWValidBlock callback 2017-01-05 10:32:07 -05:00
validationinterface.h [trivial] Fix recently introduced typos in comments 2017-02-14 20:19:40 +01:00
version.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
versionbits.cpp RPC: augment getblockchaininfo bip9_softforks data 2016-10-19 09:08:39 -04:00
versionbits.h RPC: augment getblockchaininfo bip9_softforks data 2016-10-19 09:08:39 -04:00
warnings.cpp Move GetWarnings() into its own file. 2016-12-03 07:17:34 +00:00
warnings.h Move GetWarnings() into its own file. 2016-12-03 07:17:34 +00:00