MarcoFalke d692d192cd Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction) ... fa6bb0ce5d Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction) (MarcoFalke) fa80c81487 Assert that RPCArg names are equal to CRPCCommand ones (blockchain) (MarcoFalke) Pull request description: This is split out from #18531 to just touch some RPC methods. Description from the main pr: ### Motivation RPCArg names in the rpc help are currently only used for documentation. However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the `CRPCCommand`s and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors). See section "bugs found" for a list of bugs that have been found as a result of the changes here. ### Changes The changes here add an assert in the `CRPCCommand` constructor that the RPCArg names are identical to the ones in the `CRPCCommand`. ### Future work > Here or follow up, makes sense to also assert type of returned UniValue? Sure, but let's not get ahead of ourselves. I am going to submit any further works as follow-ups, including: * Removing the CRPCCommand arguments, now that they are asserted to be equal and thus redundant * Removing all python regex linters on the args, now that RPCMan can be used to generate any output, including the cli.cpp table * Auto-formatting and sanity checking the RPCExamples with RPCMan * Checking passed-in json in self-check. Removing redundant checks * Checking returned json against documentation to avoid regressions or false documentation * Compile the RPC documentation at compile-time to ensure it doesn't change at runtime and is completely static ### Bugs found * The assert identified issue #18607 * The changes itself fixed bug #19250 ACKs for top commit: fjahr: utACK fa6bb0ce5d tryphe: utACK fa6bb0ce5d. Reducing data duplication is nice. Code changes are minimal and concise. Tree-SHA512: deb0edc3f999baf055526eaa199b98c500635e12502dece7aa3cad5319db330eb5ee7459a5c8f040a83671a7f20c560c19a2026fb76c8416f138aa332727cbce		2020-09-22 17:08:08 +02:00
..
bench	Add SHA3 benchmark	2020-09-06 18:35:23 -07:00
compat	net: Use C++11 member initialization in protocol	2020-05-20 08:27:07 -04:00
config
consensus	add signet basic support (signet.cpp)	2020-09-10 10:47:40 +09:00
crc32c	Import crc32c using subtree merge as as 'src/crc32c'	2020-01-28 17:00:01 +01:00
crypto	Merge #19931: Change CSipHasher's count variable to uint8_t	2020-09-14 16:30:17 +08:00
index	Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB	2020-08-21 12:48:46 +08:00
interfaces	Do not create default wallet	2020-09-08 21:02:53 -04:00
leveldb	Update to leveldb upstream using subtree merge	2020-01-28 16:59:07 +01:00
logging	Remove use of non-standard zero variadic macros	2020-04-30 18:02:04 +08:00
node	Merge #19879: [p2p] miscellaneous wtxid followups	2020-09-16 06:30:57 +08:00
policy	doc: Add doxygen comment to IsRBFOptIn	2020-09-05 11:45:16 +02:00
primitives	refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic	2020-07-30 13:44:54 -07:00
qt	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
rpc	Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)	2020-09-22 17:08:08 +02:00
script	Merge #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071)	2020-08-25 20:18:40 +08:00
secp256k1	Update src/secp256k1 subtree to upstream libsecp256k1	2020-09-11 12:44:08 -07:00
support	Move Win32 defines to configure.ac to ensure they are globally defined	2020-08-20 17:55:06 +00:00
test	Merge #17785: p2p: Unify Send and Receive protocol versions	2020-09-22 00:14:32 +02:00
univalue	Update univalue subtree	2020-02-09 07:44:29 -08:00
util	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
wallet	Merge #15454: Remove the automatic creation and loading of the default wallet	2020-09-18 12:03:55 +12:00
zmq	scripted-diff: Rename SendMessage to SendZmqMessage.	2020-09-15 09:38:56 +02:00
.clang-format	tools: clang-format 6 compatibility	2020-07-06 03:52:37 +02:00
addrdb.cpp	refactor: Use uint16_t instead of unsigned short	2020-06-22 12:12:22 +02:00
addrdb.h	Clean up separated ban/discourage interface	2020-07-03 20:43:55 -07:00
addrman.cpp	[addrman] Specify max addresses and pct when calling GetAddresses()	2020-08-12 09:22:07 +01:00
addrman.h	[addrman] Specify max addresses and pct when calling GetAddresses()	2020-08-12 09:22:07 +01:00
amount.h
arith_uint256.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
arith_uint256.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
attributes.h
banman.cpp	banlist: log post-swept banlist size at startup	2020-07-08 21:44:45 +08:00
banman.h	Clean up separated ban/discourage interface	2020-07-03 20:43:55 -07:00
base58.cpp	Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}	2020-08-28 16:50:57 +02:00
base58.h	Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}	2020-08-28 16:50:57 +02:00
bech32.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
bech32.h	Assert that the HRP is lowercase in Bech32::Encode	2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	Merge #19643: Add -netinfo peer connections dashboard	2020-09-15 15:01:50 +08:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	Replace usage of GetScriptForWitness with GetScriptForDestination	2020-08-14 08:44:42 +12:00
bitcoin-wallet-res.rc	[tools] Add wallet inspection and modification tool	2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp	scripted-diff: Replace gArgs with local argsman	2020-07-29 16:39:00 +07:00
bitcoind-res.rc
bitcoind.cpp	refactor: Create interfaces earlier during initialization	2020-08-27 14:33:00 -04:00
blockencodings.cpp	Get rid of -Wthread-safety-precise warnings	2020-05-28 09:55:39 +03:00
blockencodings.h	Get rid of -Wthread-safety-precise warnings	2020-05-28 09:55:39 +03:00
blockfilter.cpp	Make CHash256/CHash160 output to Span	2020-07-30 13:57:54 -07:00
blockfilter.h	[indexes] Fix default [de]serialization of BlockFilter.	2020-05-26 17:27:15 -04:00
bloom.cpp	scripted-diff: TxoutType C++11 scoped enum class	2020-06-21 06:41:55 -04:00
bloom.h	Merge #18317: Serialization improvements step 6 (all except wallet/gui)	2020-05-20 07:30:29 -04:00
chain.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chain.h	chain: Remove UB CChain comparison	2020-08-27 20:07:27 -04:00
chainparams.cpp	signet: hard-coded parameters for Signet Global Network VI (2020-09-07)	2020-09-18 10:19:42 +09:00
chainparams.h	help: Generate checkpoint height from chainparams	2020-08-20 18:20:27 +00:00
chainparamsbase.cpp	signet: hard-coded parameters for Signet Global Network VI (2020-09-07)	2020-09-18 10:19:42 +09:00
chainparamsbase.h	add signet chain and accompanying parameters	2020-09-18 09:37:57 +09:00
chainparamsseeds.h	net: Hardcoded seeds update for 0.20	2020-04-03 16:29:26 +02:00
checkqueue.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
clientversion.cpp	Drop unused GIT_COMMIT_DATE macro	2020-05-04 19:53:58 +03:00
clientversion.h
coins.cpp	Add CChainState::ResizeCoinsCaches	2020-07-01 14:44:28 -04:00
coins.h	Add CChainState::ResizeCoinsCaches	2020-07-01 14:44:28 -04:00
compat.h	Move Win32 defines to configure.ac to ensure they are globally defined	2020-08-20 17:55:06 +00:00
compressor.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
compressor.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
core_io.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
core_memusage.h
core_read.cpp	refactor: Replace const char* to std::string	2020-05-22 01:40:31 +09:00
core_write.cpp	refactor: Avoid duplicate map lookup in ScriptToAsmStr	2020-09-04 10:25:44 +01:00
cuckoocache.h	tests: Add fuzzing harness for classes/functions in cuckoocache.h	2020-04-08 14:45:27 +00:00
dbwrapper.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
dbwrapper.h	Drop unused CDBWrapper methods	2020-07-08 14:26:14 +03:00
dummywallet.cpp	Merge #19671: wallet: Remove -zapwallettxes	2020-09-01 09:26:28 +08:00
flatfile.cpp	Style cleanup.	2019-02-22 17:38:45 -08:00
flatfile.h	Merge #18317: Serialization improvements step 6 (all except wallet/gui)	2020-05-20 07:30:29 -04:00
fs.cpp	Add missing includes to fix compile errors	2020-06-16 15:15:46 -04:00
fs.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
hash.cpp	Add SHA256Uint256 helper functions	2020-08-06 16:28:26 -07:00
hash.h	Add SHA256Uint256 helper functions	2020-08-06 16:28:26 -07:00
httprpc.cpp	Merge #18740: Remove g_rpc_node global	2020-05-21 06:53:39 -04:00
httprpc.h	refactor: Pass NodeContext to RPC and REST methods through util::Ref	2020-05-13 16:20:13 -04:00
httpserver.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
httpserver.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
indirectmap.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
init.cpp	Merge #19241: help: Generate checkpoint height from chainparams	2020-09-15 15:46:08 +02:00
init.h	refactor: Create interfaces earlier during initialization	2020-08-27 14:33:00 -04:00
key.cpp	tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_export_der(...)	2020-08-18 18:03:57 +00:00
key.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.h
limitedmap.h
logging.cpp	log: remove deprecated db log category	2020-06-07 17:03:49 +02:00
logging.h	refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex	2020-05-28 09:54:24 +03:00
Makefile.am	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
Makefile.bench.include	build: split PTHREAD_* flags out of AM_LDFLAGS	2020-09-14 16:35:09 +08:00
Makefile.crc32c.include	build: CRC32C build system integration	2020-01-28 17:01:48 +01:00
Makefile.leveldb.include	build: Enable -Wsuggest-override	2020-05-12 18:03:39 +03:00
Makefile.qt.include	build: split PTHREAD_* flags out of AM_LDFLAGS	2020-09-14 16:35:09 +08:00
Makefile.qt_locale.include	qt: Translations update pre-branch	2020-04-01 12:49:15 +02:00
Makefile.qttest.include	build: split PTHREAD_* flags out of AM_LDFLAGS	2020-09-14 16:35:09 +08:00
Makefile.test.include	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
Makefile.test_fuzz.include	build: create test_fuzz library from src/test/fuzz/fuzz.cpp	2020-04-05 01:01:13 +02:00
Makefile.test_util.include	fuzz: Add process_messages harness	2020-04-05 10:46:24 +08:00
memusage.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
merkleblock.cpp	Make Hash[160] consume range-like objects	2020-07-30 13:57:54 -07:00
merkleblock.h	Convert merkleblock to new serialization	2020-03-30 16:09:51 -07:00
miner.cpp	refactor: Remove unused BlockAssembler::pblock member var	2020-06-15 08:08:19 -04:00
miner.h	Remove mapLinks in favor of entry inlined structs with iterator type erasure	2020-09-04 09:46:44 -07:00
net.cpp	Merge #17785: p2p: Unify Send and Receive protocol versions	2020-09-22 00:14:32 +02:00
net.h	Merge #17785: p2p: Unify Send and Receive protocol versions	2020-09-22 00:14:32 +02:00
net_permissions.cpp	Add addr permission flag enabling non-cached addr sharing	2020-07-30 14:38:50 +03:00
net_permissions.h	Add addr permission flag enabling non-cached addr sharing	2020-07-30 14:38:50 +03:00
net_processing.cpp	Merge #17785: p2p: Unify Send and Receive protocol versions	2020-09-22 00:14:32 +02:00
net_processing.h	Do not pass chain params to CheckForStaleTipAndEvictPeers twice	2020-09-08 07:55:11 +02:00
net_types.h	refactor: Remove addrdb.h dependency from node.h	2019-10-29 11:30:12 +02:00
netaddress.cpp	Merge #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes	2020-08-28 17:51:37 +02:00
netaddress.h	net: change CNetAddr::ip to have flexible size	2020-08-24 21:50:59 +02:00
netbase.cpp	net: change CNetAddr::ip to have flexible size	2020-08-24 21:50:59 +02:00
netbase.h	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
netmessagemaker.h	refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg	2020-05-11 00:20:57 +02:00
noui.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
noui.h	Make ThreadSafe{MessageBox|Question} bilingual	2020-05-05 04:45:59 +03:00
optional.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
outputtype.cpp	Enable Wswitch for OutputType	2020-07-01 18:03:12 -04:00
outputtype.h	Remove confusing OutputType::CHANGE_AUTO	2020-07-01 18:02:38 -04:00
pow.cpp
pow.h
prevector.h	prevector: Avoid unnamed struct, which is a GNU extension	2020-04-30 18:02:03 +08:00
protocol.cpp	refactor: remove unused header <arpa/inet.h> in protocol.cpp	2020-09-06 02:29:30 +02:00
protocol.h	Merge #19818: p2p: change CInv::type from int to uint32_t, fix UBSan warning	2020-09-03 17:23:52 +02:00
psbt.cpp	psbt: always put a non_witness_utxo and don't remove it	2020-06-24 16:32:19 -04:00
psbt.h	psbt: always put a non_witness_utxo and don't remove it	2020-06-24 16:32:19 -04:00
pubkey.cpp	tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)	2020-08-18 18:03:56 +00:00
pubkey.h	Make Hash[160] consume range-like objects	2020-07-30 13:57:54 -07:00
random.cpp	Merge #17563: lib: fix a compiler warning: unused GetDevURandom()	2020-08-10 21:30:42 +08:00
random.h	Add templated GetRandomDuration<>	2020-04-30 09:19:14 -04:00
randomenv.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
randomenv.h	[MOVEONLY] Move perfmon data gathering to new randomenv module	2019-11-12 14:50:44 -08:00
rest.cpp	Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)	2020-09-22 17:08:08 +02:00
reverse_iterator.h
scheduler.cpp	clang-format scheduler	2020-06-21 06:02:59 -04:00
scheduler.h	clang-format scheduler	2020-06-21 06:02:59 -04:00
serialize.h	refactor: Use uint16_t instead of unsigned short	2020-06-22 12:12:22 +02:00
shutdown.cpp
shutdown.h
signet.cpp	add signet basic support (signet.cpp)	2020-09-10 10:47:40 +09:00
signet.h	add signet basic support (signet.cpp)	2020-09-10 10:47:40 +09:00
span.h	Add MakeUCharSpan, to help constructing Span<[const] unsigned char>	2020-07-30 13:57:09 -07:00
streams.h	refactor: Drop unused CBufferedFile::Seek()	2020-07-26 22:46:28 +03:00
sync.cpp	sync.h: Make runtime lock checks require compile-time lock checks	2020-08-29 20:46:47 +03:00
sync.h	sync.h: Make runtime lock checks require compile-time lock checks	2020-08-29 20:46:47 +03:00
threadinterrupt.cpp
threadinterrupt.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
threadsafety.h	Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations	2020-08-18 10:46:53 +03:00
timedata.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
timedata.h
tinyformat.h	util: Update tinyformat to upstream	2019-12-06 10:02:08 +01:00
torcontrol.cpp	Replace hidden service with onion service	2020-08-07 14:55:02 +02:00
torcontrol.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
txdb.cpp	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
txdb.h	txdb: add CCoinsViewDB::ChangeCacheSize	2020-07-01 14:44:24 -04:00
txmempool.cpp	Get rid of unused functions CTxMemPool::GetMemPoolChildren, CTxMemPool::GetMemPoolParents	2020-09-04 09:46:44 -07:00
txmempool.h	Merge #19879: [p2p] miscellaneous wtxid followups	2020-09-16 06:30:57 +08:00
uint256.cpp	refactor: Make HexStr take a span	2020-08-06 19:41:43 +02:00
uint256.h	Make uint256 Span-convertible by adding ::data()	2020-07-30 13:57:09 -07:00
undo.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
validation.cpp	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
validation.h	Merge #18267: BIP-325: Signet [consensus]	2020-09-21 22:33:00 +02:00
validationinterface.cpp	trivial: Suggested cleanups to surrounding code	2020-05-22 16:30:07 -04:00
validationinterface.h	trivial: Suggested cleanups to surrounding code	2020-05-22 16:30:07 -04:00
version.h	Add p2p message "wtxidrelay"	2020-07-19 02:10:41 -04:00
versionbits.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbits.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.h
walletinitinterface.h	refactor: add unused ArgsManager to replace gArgs	2020-07-29 16:36:44 +07:00
warnings.cpp	Make SetMiscWarning() accept bilingual_str argument	2020-06-10 15:01:20 +03:00
warnings.h	Make SetMiscWarning() accept bilingual_str argument	2020-06-10 15:01:20 +03:00