Wladimir J. van der Laan 10bee0dd4f Merge #11284: Fix invalid memory access in CScript::operator+= (guidovranken, ajtowns) ... d601f16 Fix invalid memory access in CScript::operator+= (Anthony Towns) Pull request description: This is a fix for #11114 -- invoking "s += s" gets turned into "s.insert(s.end(), s.begin(), s.end())" which can result in an invalid memory access is s.capacity() < 2*s.size() (because s gets resized and possibly moved, so s.begin() and s.end() become invalid references when reading the values to be appended). The fix is straightforward: reserve enough space in advance, so that insert() doesn't need to resize and thus its arguments remain valid. A simple test case is added as well; though you probably need to run it via valgrind to actually catch the problem when it's not fixed... Tree-SHA512: 4720d0c17463fdc43b344c45fe603423d20b30d48da1b9d85eeedc505d7f34db1ed5495ef1556459ae962a94717e3c6e8fc441763771901efea210d01322b7ef		2017-10-02 14:46:47 +02:00
..
bitcoinconsensus.cpp	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
bitcoinconsensus.h	scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL	2017-08-07 07:36:37 +02:00
interpreter.cpp	Changing &vec[0] to vec.data(), what 9804 missed	2017-09-08 10:36:26 +12:00
interpreter.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
ismine.cpp	Implement BIP173 addresses and tests	2017-09-28 16:24:30 -07:00
ismine.h	Increment MIT Licence copyright header year on files modified in 2016	2016-12-31 11:01:21 -07:00
script.cpp	Sanity check transaction scripts in DecodeHexTx	2017-06-07 14:07:26 -07:00
script.h	Fix invalid memory access in CScript::operator+=	2017-09-11 13:40:31 +10:00
script_error.cpp	Add error string for CLEANSTACK script violation, preventing an "unknown error" if the CLEANSTACK error condition is set.	2017-09-29 01:48:43 -07:00
script_error.h	Increment MIT Licence copyright header year on files modified in 2016	2016-12-31 11:01:21 -07:00
sigcache.cpp	scripted-diff: stop using the gArgs wrappers	2017-08-14 17:02:10 +02:00
sigcache.h	Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class	2017-06-28 02:12:06 +02:00
sign.cpp	Implement BIP173 addresses and tests	2017-09-28 16:24:30 -07:00
sign.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
standard.cpp	Implement BIP173 addresses and tests	2017-09-28 16:24:30 -07:00
standard.h	Implement BIP173 addresses and tests	2017-09-28 16:24:30 -07:00