bitcoin/src/rpc
Wladimir J. van der Laan 0f8e09599d
Merge #11288: More user-friendly error message when partially signing
df10edf More user-friendly error message when partially signing (MeshCollider)

Pull request description:

  When partially signing a transaction using `signrawtransaction`, if the wallet doesn't have access to a key, it will output a scary error message `"error": "Operation not valid with the current stack size"`, yet it will partially sign the transaction anyway. This puts a lot of users off, because they don't realise the signing actually succeeded for some inputs. This catches that specific error when signing, and outputs a friendlier message which says `Unable to sign input, invalid stack size (possibly missing key)`.

  This is the best way I could think of to fix the issue, but please let me know if you come up with a better way to do it :)

  Fixes https://github.com/bitcoin/bitcoin/issues/9988

Tree-SHA512: 65e1d4a49caa4202e1357b0b3f42329d76456c7b4286d63232226e03267809027b0c44e0faaa1da8b86c9ad677e3a3d655698a24fc870d6a661203c9f56ef95b
2017-09-26 16:16:50 +02:00
..
blockchain.cpp Merge #11238: Add assertions before potential null deferences 2017-09-06 23:54:06 +02:00
blockchain.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
client.cpp rpc: make estimatesmartfee argument naming consistent with documentation 2017-09-08 01:55:59 +02:00
client.h rpc: Named argument support for bitcoin-cli 2017-01-10 12:04:54 +01:00
mining.cpp Merge #11267: rpc: update cli for estimate*fee argument rename 2017-09-12 19:31:30 +02:00
mining.h Properly bound check conf_target in wallet RPC calls 2017-07-14 23:41:40 -04:00
misc.cpp Merge #10793: Changing &var[0] to var.data() 2017-09-08 01:16:54 +02:00
net.cpp rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
protocol.cpp rpc: Write authcookie atomically 2017-08-25 15:37:24 +02:00
protocol.h rpc: Write authcookie atomically 2017-08-25 15:37:24 +02:00
rawtransaction.cpp More user-friendly error message when partially signing 2017-09-11 22:15:44 +12:00
register.h Do not shadow global RPC table variable (tableRPC) 2016-08-25 15:02:26 +02:00
safemode.cpp rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
safemode.h rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
server.cpp rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
server.h rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00