mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-04-29 14:59:39 -04:00
01960c53c7
There exist many usages of `fuzzed_data_provider` where it is evaluated directly in the function call. Unfortunately, the order of evaluation of function arguments is unspecified. This means it can differ between compilers/version/optimization levels etc. But when the evaluation order changes, the same fuzzing input will produce different output, which is bad for coverage/reproducibility. This PR fixes all these cases where by moving multiple calls to `fuzzed_data_provider` out of the function arguments.
47 lines
2.2 KiB
C++
47 lines
2.2 KiB
C++
// Copyright (c) 2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <primitives/transaction.h>
|
|
#include <script/interpreter.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
|
|
#include <cstdint>
|
|
#include <optional>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
bool CastToBool(const std::vector<unsigned char>& vch);
|
|
|
|
FUZZ_TARGET(script_interpreter)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
{
|
|
const CScript script_code = ConsumeScript(fuzzed_data_provider);
|
|
const std::optional<CMutableTransaction> mtx = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider, TX_WITH_WITNESS);
|
|
if (mtx) {
|
|
const CTransaction tx_to{*mtx};
|
|
const unsigned int in = fuzzed_data_provider.ConsumeIntegral<unsigned int>();
|
|
if (in < tx_to.vin.size()) {
|
|
auto n_hash_type = fuzzed_data_provider.ConsumeIntegral<int>();
|
|
auto amount = ConsumeMoney(fuzzed_data_provider);
|
|
auto sigversion = fuzzed_data_provider.PickValueInArray({SigVersion::BASE, SigVersion::WITNESS_V0});
|
|
(void)SignatureHash(script_code, tx_to, in, n_hash_type, amount, sigversion, nullptr);
|
|
const std::optional<CMutableTransaction> mtx_precomputed = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider, TX_WITH_WITNESS);
|
|
if (mtx_precomputed) {
|
|
const CTransaction tx_precomputed{*mtx_precomputed};
|
|
const PrecomputedTransactionData precomputed_transaction_data{tx_precomputed};
|
|
n_hash_type = fuzzed_data_provider.ConsumeIntegral<int>();
|
|
amount = ConsumeMoney(fuzzed_data_provider);
|
|
sigversion = fuzzed_data_provider.PickValueInArray({SigVersion::BASE, SigVersion::WITNESS_V0});
|
|
(void)SignatureHash(script_code, tx_to, in, n_hash_type, amount, sigversion, &precomputed_transaction_data);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
{
|
|
(void)CastToBool(ConsumeRandomLengthByteVector(fuzzed_data_provider));
|
|
}
|
|
}
|