13 commits

Author	SHA1	Message	Date
Russell Yanofsky	e4f4350471	refactor: Move wallet methods out of chain.h and node.h ... Add WalletClient interface so node interface is cleaner and don't need wallet-specific methods. The new NodeContext::wallet_client pointer will also be needed to eliminate global wallet variables like ::vpwallets, because createWallet(), loadWallet(), getWallets(), etc methods called by the GUI need a way to get a reference to the list of open wallets if it is no longer a global variable. Also tweaks splash screen registration for load wallet events to be delayed until after wallet client is created.	2020-08-27 14:33:00 -04:00
MarcoFalke	faec28252c	scripted-diff: test: Move setup_common to test library ... -BEGIN VERIFY SCRIPT- # Move files for f in $(git ls-files src/test/lib/); do git mv $f src/test/util/; done git mv src/test/setup_common.cpp src/test/util/ git mv src/test/setup_common.h src/test/util/ # Replace Windows paths sed -i -e 's|\\setup_common|\\util\\setup_common|g' $(git grep -l '\\setup_common') sed -i -e 's|src\\test\\lib\\|src\\test\\util\\|g' build_msvc/test_bitcoin/test_bitcoin.vcxproj # Everything else sed -i -e 's|/setup_common|/util/setup_common|g' $(git grep -l 'setup_common') sed -i -e 's|test/lib/|test/util/|g' $(git grep -l 'test/lib/') # Fix include guard sed -i -e 's|BITCOIN_TEST_SETUP_COMMON_H|BITCOIN_TEST_UTIL_SETUP_COMMON_H|g' ./src/test/util/setup_common.h sed -i -e 's|BITCOIN_TEST_LIB_|BITCOIN_TEST_UTIL_|g' $(git grep -l 'BITCOIN_TEST_LIB_') -END VERIFY SCRIPT-	2019-11-06 11:56:41 -05:00
MarcoFalke	fa2c44c3cc	test: Add ASSERT_DEBUG_LOG to unit test framework	2019-11-04 10:42:33 -05:00
Wladimir J. van der Laan	e653eeff76	Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors ... 7a0c224289 Suppress output in test_bitcoin for expected errors (Gert-Jaap Glasbergen) Pull request description: Closes #15944 This adds two methods to noui, that allows temporarily suppressing (and then resuming) the output from `noui`. For situations where errors are expected, it's confusing for the test binary to output an error and then conclude with `No errors detected`. It also uses this supress/reconnect in the tests that currently produce verbose errors when running `test_bitcoin`. Output of `test_bitcoin` on current master: ``` gertjaap@gjdesktop:~/src/bitcoin$ src/test/test_bitcoin Running 351 test cases... Error: Specified -walletdir "/tmp/test_common_Bitcoin Core/1561389554_943311758/tempdir/path_does_not_exist" does not exist Error: Specified -walletdir "/tmp/test_common_Bitcoin Core/1561389554_643733972/tempdir/not_a_directory.dat" is not a directory Error: Specified -walletdir "wallets" is a relative path *** No errors detected ``` Output after this code is merged: ``` gertjaap@gjdesktop:~/src/bitcoin$ src/test/test_bitcoin Running 351 test cases... *** No errors detected ``` ACKs for top commit: l2a5b1: ACK 7a0c224 - tested and reviewed. laanwj: ACK 7a0c224289 Tree-SHA512: c7881f7a431a065329360ffa9937ce4742694c646c90c019d3aff95dfd7fccbdcda9116c5762feb6dfd1108d14f9fb386e203b173c4bde9093afb2b8c977d13d	2019-08-01 15:17:10 +02:00
Gert-Jaap Glasbergen	7a0c224289	Suppress output in test_bitcoin for expected errors	2019-07-03 14:03:21 +02:00
practicalswift	9a841696c1	tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests	2019-06-26 20:37:48 +02:00
practicalswift	eca9767673	Make reasoning about dependencies easier by not including unused dependencies	2019-06-02 17:15:23 +02:00
MarcoFalke	aaaa57c2aa	scripted-diff: Bump copyright headers in wallet ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./src/wallet/ -END VERIFY SCRIPT-	2019-05-06 14:05:52 -04:00
MarcoFalke	fa821904bf	scripted-diff: Rename test_bitcoin to test/setup_common ... -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/test_bitcoin\.(h|cpp)/setup_common.\1/g' $(git grep -l test_bitcoin) git mv ./src/test/test_bitcoin.h ./src/test/setup_common.h git mv ./src/test/test_bitcoin.cpp ./src/test/setup_common.cpp sed -i -e 's/BITCOIN_TEST_TEST_BITCOIN_H/BITCOIN_TEST_SETUP_COMMON_H/g' ./src/test/setup_common.h -END VERIFY SCRIPT-	2019-04-11 10:12:36 -04:00
Russell Yanofsky	ea961c3d72	Remove direct node->wallet calls in init.cpp ... Route calls during node initialization and shutdown that would happen between a node process and wallet processes through the serializable `Chain::Client` interface, rather than `WalletInitInterface` which is now simpler and only deals with early initialization and parameter interaction. This commit mostly does not change behavior. The only change is that the "Wallet disabled!" and "No wallet support compiled in!" messages are now logged earlier during startup.	2018-11-06 11:44:40 -04:00
Russell Yanofsky	8db11dd0b1	Pass chain and client variables where needed ... This commit does not change behavior. All it does is pass new function parameters. It is easiest to review this change with: git log -p -n1 -U0 --word-diff-regex=.	2018-11-06 11:44:40 -04:00
Pierre Rochard	2d471636eb	wallet: Remove trailing separators from -walletdir arg	2018-09-12 21:05:53 -04:00
Pierre Rochard	ea3009ee94	wallet: Add walletdir arg unit tests	2018-09-12 21:05:53 -04:00