Matt Corallo
a6f33ea77d
Sanity-check script sizes in bitcoin-tx
2017-10-24 14:11:52 -04:00
Wladimir J. van der Laan
470c730e3f
Merge #10898 : Fix invalid checks (NULL checks after dereference, redundant checks, etc.)
...
76fed834971a9ab5fb339746699155224af
2017-10-12 23:55:50 +02:00
practicalswift
7466991670
Remove redundant check (!ecc is always true)
2017-10-02 15:47:43 +02:00
Matt Corallo
28d4542a0a
Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds
2017-09-20 23:29:59 -04:00
Pieter Wuille
5c8ff0d448
Introduce wrappers around CBitcoinAddress
...
This patch removes the need for the intermediary Base58 type
CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination
function that directly operate on the conversion between strings
and CTxDestination.
2017-09-06 13:07:45 -07:00
Marko Bencun
bb81e17355
scripted-diff: stop using the gArgs wrappers
...
They were temporary additions to ease the transition.
-BEGIN VERIFY SCRIPT-
find src/ -name "*.cpp" ! -wholename "src/util.h" ! -wholename "src/util.cpp" | xargs perl -i -pe 's/(?<!\.)(ParseParameters|ReadConfigFile|IsArgSet|(Soft|Force)?(Get|Set)(|Bool|)Arg(s)?)\(/gArgs.\1(/g'
-END VERIFY SCRIPT-
2017-08-14 17:02:10 +02:00
practicalswift
90d4d89230
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h
sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp
sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp
sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp
sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp
sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp
-END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
Gregory Maxwell
3babbcb487
Remove confusing MAX_BLOCK_BASE_SIZE.
...
Some people keep thinking that MAX_BLOCK_BASE_SIZE is a separate
size limit from the weight limit when it fact it is superfluous,
and used in early tests before the witness data has been
validated or just to compute worst case sizes. The size checks
that use it would not behave any differently consensus wise
if they were eliminated completely.
Its correct value is not independently settable but is a function
of the weight limit and weight formula.
This patch just eliminates it and uses the scale factor as
required to compute the worse case constants.
It also moves the weight factor out of primitives into consensus,
which is a more logical place for it.
2017-07-14 19:24:17 +00:00
Matt Corallo
73c942ecd3
Use "replaceable" instead of "rbfoptin" in bitcoin-tx.
...
To be consistent with RPC naming
2017-07-05 18:11:22 -04:00
Pieter Wuille
d636f3943d
Merge #10536 : Remove unreachable or otherwise redundant code
...
4265bf351
2017-06-20 16:16:38 -07:00
Pieter Wuille
1ad3d4e126
Merge #10502 : scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE
...
1238f13cf18dc3c3967c00c2672a5410ac5e
2017-06-13 18:05:58 -07:00
practicalswift
4265bf351a
Remove unreachable or otherwise redundant code
2017-06-12 15:01:46 +02:00
Wladimir J. van der Laan
29f80cd230
Merge #10545 : Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
...
3fb81a8
2017-06-08 20:26:40 +02:00
practicalswift
3fb81a8480
Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of
2017-06-06 21:29:16 +02:00
Luke Dashjr
23b0fe34f5
bitcoin-tx: rbfoptin: Avoid touching nSequence if the value is already opting in
2017-06-05 23:14:34 +00:00
Luke Dashjr
b005bf21a7
Introduce MAX_BIP125_RBF_SEQUENCE constant
2017-06-05 23:14:34 +00:00
Jonas Schnelli
575cde4605
[bitcoin-tx] add rbfoptin command
2017-06-05 23:13:24 +00:00
Jorge Timón
7c00c26726
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2017-06-05 20:10:50 +02:00
Pieter Wuille
589827975f
scripted-diff: various renames for per-utxo consistency
...
Thanks to John Newberry for pointing these out.
-BEGIN VERIFY SCRIPT-
sed -i 's/\<GetCoins\>/GetCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<HaveCoins\>/HaveCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<HaveCoinsInCache\>/HaveCoinInCache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<IsPruned\>/IsSpent/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<FetchCoins\>/FetchCoin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<CoinsEntry\>/CoinEntry/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<vHashTxnToUncache\>/coins_to_uncache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<vHashTxToUncache\>/coins_to_uncache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<fHadTxInCache\>/had_coin_in_cache/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<coinbaseids\>/coinbase_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<disconnectedids\>/disconnected_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<duplicateids\>/duplicate_coins/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/\<oldcoins\>/old_coin/g' src/test/coins_tests.cpp
sed -i 's/\<origcoins\>/orig_coin/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
2017-06-01 13:15:25 -07:00
Pieter Wuille
f68cdfe92b
Switch from per-tx to per-txout CCoinsViewCache methods in some places
2017-06-01 11:56:06 -07:00
Wladimir J. van der Laan
6fdb319165
Merge #9743 : Fix several potential issues found by sanitizers
...
1d31093321bbc2
2017-04-26 12:29:05 +02:00
Pieter Wuille
321bbc2079
fix ubsan: bitcoin-tx: not initialize context before IsFullyValid
2017-04-20 06:25:15 -07:00
Awemany
eb66bf9bdd
bitcoin-tx: Fix missing range check
...
The number of arguments is not checked MutateTxAddOutAddr(..), meaning
that
> ./bitcoin-tx -create outaddr=
accessed the vStrInputParts vector beyond its bounds.
This also includes work by jnewbery to check the inputs for
MutateTxAddPubKey()
2017-03-30 15:35:24 -04:00
practicalswift
8dc957ae06
Remove unused code
2017-03-17 04:37:43 +01:00
Wladimir J. van der Laan
d5d4ad87af
Merge #8883 : Add all standard TXO types to bitcoin-tx
...
0c50909b7e144b61a15341814b08
2017-01-12 12:24:35 +01:00
isle2983
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
2016-12-31 11:01:21 -07:00
jnewbery
61a153443e
Add all transaction output types to bitcoin-tx.
...
This commit enhances bitcoin-tx so all remaining standard TXO types can be created:
- Pay to Pub Key
- Multi-sig
- bare multi-sig
- multi-sig in Pay To Script Hash
- multi-sig in Pay to Witness Script Hash
- multi-sig in Pay to Witness Script Hash, wrapped in P2SH
- Pay to Witness Pub Key Hash
- Pay to Witness Pub Key Hash, wrapped in P2SH
- Pay to Witness Script Hash
- Pay to Witness Script Hash, wrapped in P2SH
2016-12-29 15:40:40 +00:00
Stanislas Marion
1814b089fb
add p2sh and segwit options to bitcoin-tx outscript command
2016-12-29 15:40:40 +00:00
Matt Corallo
0cf86a6678
Introduce (and use) an IsArgSet accessor method
2016-12-23 21:30:16 -05:00
Pieter Wuille
f6fb7acda4
Move CTxInWitness inside CTxIn
2016-12-04 23:47:12 -08:00
Pieter Wuille
42fd8dee30
Make DecodeHexTx return a CMutableTransaction
2016-12-02 18:28:22 -08:00
Karl-Johan Alm
2f2625a0bb
Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places.
2016-11-25 17:17:57 +09:00
Wladimir J. van der Laan
210891143b
Merge #8837 : allow bitcoin-tx to parse partial transactions
...
7451cf5
2016-11-21 15:33:19 +01:00
UdjinM6
45d372f889
Missed one "return false" in recent refactoring in #9067
2016-11-10 00:53:55 +03:00
UdjinM6
bd0de1386e
Fix exit codes:
...
- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with `1`
Slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)
2016-11-04 18:40:33 +03:00
jnewbery
7451cf59cd
Allow bitcoin-tx to parse partial transactions
...
Restore pre V0.13.1 functionality to bitcoin-tx and allow it to parse 0-input partial transactions.
2016-11-04 09:10:44 +00:00
BtcDrak
b0aea80579
Sync bitcoin-tx with tx version policy
2016-10-16 23:22:15 +01:00
Jorge Timón
cdd79eb70f
C++11: s/boost::scoped_ptr/std::unique_ptr/
2016-09-01 19:05:07 +02:00
MarcoFalke
fa6dc9f0e5
Remove unused variables
2016-08-25 14:59:38 +02:00
NicolasDorier
745eb678ef
[RPC] signrawtransaction can sign P2WSH
2016-06-22 15:43:01 +02:00
Pieter Wuille
605e8473a7
BIP143: Signing logic
2016-06-22 15:43:01 +02:00
Pieter Wuille
2b1f6f9ccf
BIP141: Other consensus critical limits, and BIP145
...
Includes changes by Suhas Daftuar, Luke-jr, and mruddy.
2016-06-22 15:43:00 +02:00
Pieter Wuille
3dd410294d
BIP143: Verification logic
...
Includes simplifications by Eric Lombrozo.
2016-06-22 15:43:00 +02:00
Pieter Wuille
0ef1dd3e11
Refactor script validation to observe amounts
...
This is a preparation for BIP143 support.
2016-06-22 15:43:00 +02:00
Pieter Wuille
449f9b8deb
BIP141: Witness program
2016-06-22 15:42:59 +02:00
Jonas Schnelli
86efa30ae3
[Bitcoin-Tx] fix missing test fixtures, fix 32bit atoi issue
2016-06-07 21:07:47 +02:00
Jonas Schnelli
e59336fbf9
[bitcoin-tx] allow to set nSequence number over the in= command
2016-04-27 15:42:17 +02:00
Luke Dashjr
a68bb9f5e7
Merge branch 'master' into single_prodname
2016-02-03 05:41:13 +00:00
Luke Dashjr
d5f46832de
Unify package name to as few places as possible without major changes
2015-12-14 02:11:10 +00:00
MarcoFalke
fa24439ff3
Bump copyright headers to 2015
2015-12-13 18:08:39 +01:00
Pieter Wuille
6e18268616
Switch to libsecp256k1-based validation for ECDSA
2015-11-15 16:06:57 +01:00
Philip Kaufmann
ad5aae15b4
constify missing catch cases
...
- ensure all missing catch cases are constant where possible
2015-10-27 17:39:42 +01:00
Wladimir J. van der Laan
2cd020d054
Merge pull request #6846
...
3cb56f3
2015-10-22 17:53:07 +02:00
Daniel Cousens
3cb56f3778
*: alias -h for --help
2015-10-22 00:07:30 +11:00
Wladimir J. van der Laan
e26a3f6713
Merge pull request #6235
...
55a8975f3525e2
2015-10-20 17:06:28 +02:00
Jorge Timón
55a89751fa
Chainparams: Translations: DRY: options and error strings
...
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
2015-10-20 14:28:43 +02:00
Jonas Schnelli
9623e93473
[Univalue] add univalue over subtree
...
similar to secp256k1 include and compile univalue over a subtree
2015-10-01 10:49:57 +02:00
Wladimir J. van der Laan
48efbdbe98
Merge pull request #5264
...
af3208b
2015-09-25 19:19:07 +02:00
Pavel Janík
627468d2ea
Add support for data-based outputs (OP_RETURN) to bitcoin-tx.
2015-08-06 20:27:52 +02:00
mruddy
af3208bfa6
Resolve issue 3166.
...
These changes decode valid SIGHASH types on signatures in assembly (asm) representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from jtimon, laanwj, and sipa.
2015-07-30 19:56:00 -04:00
Casey Rodarmor
17ac0f4025
Avoid leaking file descriptors in RegisterLoad
...
This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.
2015-07-28 14:01:00 -04:00
Jorge Timón
627b9deff4
Policy: MOVEONLY: Create policy/policy.h with some constants
2015-06-26 17:59:07 +02:00
Jeff Garzik
efc7883772
UniValue: prefer .size() to .count(), to harmonize w/ existing tree
2015-06-04 09:16:05 +02:00
Wladimir J. van der Laan
12f3488253
Merge pull request #6047
...
a56054ba591d98
2015-05-06 12:29:07 +02:00
Pieter Wuille
a56054be65
Update key.cpp to use new libsecp256k1
...
libsecp256k1's API changed, so update key.cpp to use it.
Libsecp256k1 now has explicit context objects, which makes it completely thread-safe.
In turn, keep an explicit context object in key.cpp, which is explicitly initialized
destroyed. This is not really pretty now, but it's more efficient than the static
initialized object in key.cpp (which made for example bitcoin-tx slow, as for most of
its calls, libsecp256k1 wasn't actually needed).
This also brings in the new blinding support in libsecp256k1. By passing in a random
seed, temporary variables during the elliptic curve computations are altered, in such
a way that if an attacker does not know the blind, observing the internal operations
leaks less information about the keys used. This was implemented by Greg Maxwell.
2015-05-04 14:45:34 +02:00
Wladimir J. van der Laan
8a10000222
Merge pull request #6022
...
b74dcb3
2015-04-30 16:37:18 +02:00
jtimon
691161d419
Consensus: Create consensus/consensus.h with some constants
2015-04-20 21:27:51 +02:00
Jorge Timón
b74dcb3b4a
Separate CTranslationInterface from CClientUIInterface
2015-04-16 19:58:48 +02:00
Luca Venturini
1fdb9fa3f9
Help messages correctly formatted (79 chars)
...
Help messages are formatted programmatically with FormatParagraph
in order not to break existing strings in Transifex.
The new format works even if the translation of the strings
modifies the lenght of the message.
Sqashed 6 commits in a single one.
Help messages correctly formatted for SVGA text mode (132 chars)
Help messages are formatted programmatically with FormatParagraph
in order not to break existing strings in Transifex.
The new format should work even if the translation of the strings
modifies the lenght of the message.
Fix - syntax error
Correct formatting for 79 chars
Correctly based on C++ functions
Removed spare spaces from option strings
Fix - syntax error
2015-03-10 22:07:17 -07:00
Pieter Wuille
9fddceda44
Avoid storing a reference passed to SignatureChecker constructors
2015-02-02 20:19:46 -08:00
Pieter Wuille
858809a33e
Use separate SignatureChecker for CMutableTransaction
2015-02-02 20:19:12 -08:00
Wladimir J. van der Laan
729ba31749
Merge pull request #5513
...
856e8629b1ab86a324199
2015-01-06 20:32:45 +01:00
Wladimir J. van der Laan
34cdc41128
String conversions uint256 -> uint256S
...
If uint256() constructor takes a string, uint256(0) will become
dangerous when uint256 does not take integers anymore (it will go
through std::string(const char*) making a NULL string, and the explicit
keyword is no help).
2015-01-05 15:45:35 +01:00
Wladimir J. van der Laan
4f1524966a
Replace direct use of 0 with SetNull and IsNull
...
Replace x=0 with .SetNull(),
x==0 with IsNull(), x!=0 with !IsNull().
Replace uses of uint256(0) with uint256().
2015-01-05 15:45:34 +01:00
Cory Fields
856e862f4a
namespace: drop most boost namespaces and a few header cleanups
...
A few boost::asio were left around because they're very wordy otherwise.
2015-01-02 15:12:03 -05:00
Eric R. Schulz
a089c50981
bitcoin-tx: Refer to the JSON fields rather than the whole object
2014-12-23 02:59:00 +00:00
Eric R. Schulz
2a3d988b80
bitcoin-tx: Fix JSON validation of prevtxs
2014-12-22 21:04:53 -05:00
sandakersmann
f914f1a746
Added "Core" to copyright headers
...
Github-Pull: #5494
Rebased-From: 15de949bb9
2014-12-19 19:55:32 +01:00
Wladimir J. van der Laan
111a7d45f1
Merge pull request #5470
...
78253fc
2014-12-19 19:23:23 +01:00
Philip Kaufmann
27df4123c4
make all catch() arguments const
...
- I saw this on http://en.cppreference.com/w/cpp/language/try_catch and
thought it would be a good idea
- also unify used format to better be able to search for exception
uses in our codebase
2014-12-17 09:39:24 +01:00
Michael Ford
78253fcbad
Remove references to X11 licence
2014-12-16 15:56:50 +08:00
Wladimir J. van der Laan
b5fa132329
Merge pull request #5181
...
afd4b94
2014-12-05 16:50:48 +01:00
Wladimir J. van der Laan
7d42644dda
Merge pull request #5207
...
8487790
2014-12-05 11:24:39 +01:00
Matt Corallo
afd4b94b6d
Move CMerkleBlock and CPartialMerkleTree to their own file
2014-12-05 01:57:40 -08:00
Luke Dashjr
d227011184
MOVEONLY: core/ -> primitives/
2014-12-03 10:52:58 +00:00
mruddy
84877904c0
bitcoin-tx: Add the "-txid" option. Also add the hex-encoded transaction to the JSON output as the "hex" property.
2014-11-04 21:43:03 -05:00
Cory Fields
71697f97d3
Separate protocol versioning from clientversion
2014-10-29 00:24:40 -04:00
jtimon
4a3587d8db
MOVEONLY: Separate CTransaction and dependencies from core
2014-10-27 13:54:37 +01:00
Pieter Wuille
d4a42334d4
Merge pull request #4834
...
7c70438ed27e53058b08cc9d1a81f28aec0
2014-10-08 14:58:16 -07:00
Pieter Wuille
5c1e798a8e
Make signature cache optional
2014-10-02 20:26:17 +02:00
Mark Friedenbach
a372168e77
Use a typedef for monetary values
2014-09-26 15:42:04 -07:00
Pieter Wuille
7c70438dc6
Get rid of the dummy CCoinsViewCache constructor arg
2014-09-24 03:19:04 +02:00
Pieter Wuille
f28aec014e
Use ModifyCoins instead of mutable GetCoins.
...
Replace the mutable non-copying GetCoins method with a ModifyCoins, which
returns an encapsulated iterator, so we can keep track of concurrent
modifications (as iterators can be invalidated by those) and run cleanup
code after a modification is finished.
This also removes the overloading of the 'GetCoins' name.
2014-09-23 22:29:12 +02:00
Wladimir J. van der Laan
438c7e4cd2
Merge pull request #4555
...
6dcfda22b23a87ce3649fb358562b
2014-09-17 13:44:22 +02:00
Pieter Wuille
0be990ba34
Move CTxDestination from script/script to script/standard
2014-09-16 19:14:32 +02:00
Pieter Wuille
7388b74cd2
Merge pull request #4911
...
611116d
2014-09-16 04:12:52 +02:00
Philip Kaufmann
611116d4e3
header include cleanup
...
- ensures alphabetical ordering for includes etc. in source file headers
2014-09-14 12:43:56 +02:00
Luke Dashjr
15ef1b905b
Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=<n>:
2014-09-14 05:28:41 +00:00
jtimon
2b23a87599
Don't pass nHashType to VerifyScript
2014-09-12 20:04:31 +02:00
Pieter Wuille
f7cdcb80ab
Merge pull request #4822
...
629d75f
2014-09-10 01:44:30 +02:00
