Russell Yanofsky
ab31b9d6fe
Fix wallet unload race condition
...
Currently it's possible for ReleaseWallet to delete the CWallet pointer while
it is processing BlockConnected, etc chain notifications.
To fix this, unregister from notifications earlier in UnloadWallet instead of
ReleaseWallet, and use a new RegisterSharedValidationInterface function to
prevent the CValidationInterface shared_ptr from being deleted until the last
notification is actually finished.
2020-03-27 15:17:35 +00:00
Andrew Chow
eb81fc3ee5
Refactor: Allow LegacyScriptPubKeyMan to be null
...
In CWallet::LoadWallet, use this to detect and empty wallet with no keys
This commit does not change behavior.
2020-01-23 16:34:28 -05:00
MarcoFalke
faa92a2297
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
Martin Zumsande
78e283e656
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00
Martin Zumsande
f613e5dfda
[test] move mining helper functions into test library
2019-11-25 16:40:03 +01:00
Russell Yanofsky
e6f4f895d5
Pass NodeContext, ConnMan, BanMan references more places
...
So g_connman and g_banman globals can be removed next commit.
2019-10-28 10:30:51 -04:00
practicalswift
eca9767673
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
MarcoFalke
fad7c33342
refactor: Add handleNotifications method to wallet
...
Further stylistic cleanups in touched files:
* Sort the includes
* Wrap long single-line constructors into multiple lines
2019-04-17 14:20:44 -04:00
MarcoFalke
fa46ac3127
bench: Add wallet_balance benchmarks
2019-04-15 16:49:34 -04:00
