Hennadii Stepanov
f886a20b02
qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet
2020-10-23 20:09:55 +03:00
Hennadii Stepanov
6e950118a3
qt, wallet: Remove unused AskPassphraseDialog::Decrypt
...
Co-authored-by: Sehyun Chung <sehyun@berkeley.edu>
2020-10-23 19:55:23 +03:00
MarcoFalke
cccc2784a3
scripted-diff: Move ui_interface to the node lib
...
-BEGIN VERIFY SCRIPT-
# Move files
git mv src/ui_interface.h src/node/ui_interface.h
git mv src/ui_interface.cpp src/node/ui_interface.cpp
sed -i -e 's/BITCOIN_UI_INTERFACE_H/BITCOIN_NODE_UI_INTERFACE_H/g' src/node/ui_interface.h
# Adjust includes and makefile
sed -i -e 's|ui_interface|node/ui_interface|g' $(git grep -l ui_interface)
# Sort includes
git diff -U0 | clang-format-diff -p1 -i -v
-END VERIFY SCRIPT-
2020-06-27 11:49:28 -04:00
Hennadii Stepanov
4f9d9efb4e
qt: Remove needless headers
2020-06-24 14:10:01 +03:00
Glenn Willen
11a0ffb29d
[gui] Load PSBT from clipboard
2020-06-19 02:20:04 -07:00
Glenn Willen
a6cb0b0c29
[gui] PSBT Operations Dialog (sign & broadcast)
...
Add a "PSBT Operations" dialog, reached from the "Load PSBT..." menu
item, giving options to sign or broadcast the loaded PSBT as
appropriate, as well as copying the result to the clipboard or saving
it to a file.
2020-06-19 02:20:04 -07:00
fanquake
a8327fd71f
Merge #19072 : doc: Expand section on Getting Started
...
facef3d413
doc: Explain that anyone can work on good first issues, move text to CONTRIBUTING.md (MarcoFalke)
fae2fb2a19
doc: Expand section on Getting Started (MarcoFalke)
100000d1b2
doc: Add headings to CONTRIBUTING.md (MarcoFalke)
fab893e0ca
doc: Fix unrelated typos reported by codespell (MarcoFalke)
Pull request description:
Some random doc changes:
* Add sections to docs, so that they can be linked to
* Explain that anyone (even maintainers) are allowed to work on good first issues
* Expand section on Getting Started slightly
ACKs for top commit:
hebasto:
ACK facef3d413
fanquake:
ACK facef3d413
Tree-SHA512: 8998e273a76dbf4ca77e79374c14efe4dfcc5c6df6b7d801e1e1e436711dbe6f76b436f9cbc6cacb45a56827babdd6396f3bd376a9426ee7be3bb9b8a3b8e383
2020-06-01 15:38:57 +08:00
Jonas Schnelli
5f75c5e7df
Merge #16432 : qt: Add privacy to the Overview page
...
8d75115844
qt: Add privacy feature to Overview page (Hennadii Stepanov)
73d8ef7274
qt: Add BitcoinUnits::formatWithPrivacy() function (Hennadii Stepanov)
Pull request description:
This PR allows to hide/reveal values on the Overviewpage by checking/unchecking Menu->Settings-> Mask Values
Closes #16407
Privacy mode is OFF (the default behavior):
![Screenshot from 2020-01-02 15-08-28](https://user-images.githubusercontent.com/32963518/71669074-28ab6980-2d74-11ea-8e54-4973aa307192.png )
Privacy mode is ON:
![Screenshot from 2020-01-02 15-10-23 cropped](https://user-images.githubusercontent.com/32963518/71669082-2d701d80-2d74-11ea-9df5-d4acc4982dbe.png )
ACKs for top commit:
jonatack:
Tested ACK 8d75115
jonasschnelli:
Tested ACK 8d75115844
Tree-SHA512: 42f396d5bf0d343b306fb7e925f86f66b3fc3a257af370a812f4be181b5269298f9b23bd8a3ce25ab61de92908c4018d8c2dc8591d11bc58d79c4eb7206fc6ec
2020-05-29 08:55:16 +02:00
MarcoFalke
fab893e0ca
doc: Fix unrelated typos reported by codespell
2020-05-27 12:37:08 -04:00
Hennadii Stepanov
8d75115844
qt: Add privacy feature to Overview page
2020-05-27 11:55:44 +03:00
Russell Yanofsky
2bc9b92ed8
Cancel wallet balance timer when shutdown requested
...
This doesn't fix any current problem, but it makes balance checking code less
fragile, and prevents use-after free travis error in next commit:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/675367629#L4240
2020-05-01 06:59:09 -04:00
Samuel Dobson
4f802e59a0
Merge #17509 : gui: save and load PSBT
...
764bfe4cba
[psbt] add file size limit (Sjors Provoost)
1cd8dc2556
[gui] load PSBT (Sjors Provoost)
f6895301f7
[gui] save PSBT to file (Sjors Provoost)
1d05a9d80b
Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h (Sjors Provoost)
86e22d23bb
[util] GetFileSize (Sjors Provoost)
6ab3aad9a5
[gui] send dialog: split on_sendButton_clicked (Sjors Provoost)
Pull request description:
This adds:
* a dialog after Create Unsigned, which lets you save a PSBT file in binary format, e.g. to an SD card
* a "Load PSBT" menu entry lets you pick a PSBT file. We broadcast the transaction if complete
## Save flow
<img width="482" alt="Schermafbeelding 2020-01-04 om 20 39 34" src="https://user-images.githubusercontent.com/10217/71765684-ba60d580-2f32-11ea-8dea-0c4398eb6e15.png ">
<img width="287" alt="Schermafbeelding 2020-01-04 om 20 40 35" src="https://user-images.githubusercontent.com/10217/71765677-a0bf8e00-2f32-11ea-8172-12dfd34a89f3.png ">
<img width="594" alt="Schermafbeelding 2020-01-04 om 20 41 12" src="https://user-images.githubusercontent.com/10217/71765681-aa48f600-2f32-11ea-8e2c-c4f6bf9f5309.png ">
<img width="632" alt="Schermafbeelding 2020-01-04 om 20 41 28" src="https://user-images.githubusercontent.com/10217/71765691-d19fc300-2f32-11ea-97ff-70f5dd59987a.png ">
By default the file name contains the destination address(es) and amount(s).
We only use the binary format for files, in order to avoid compatibility hell. If we do want to add base64 file format support, we should use a different extension for that (`.psbt64`?).
## Load flow
Select a file:
<img width="649" alt="Schermafbeelding 2020-01-04 om 21 08 57" src="https://user-images.githubusercontent.com/10217/71766089-2ba28780-2f37-11ea-875d-074794b5707d.png ">
Offer to send if complete:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 09 06" src="https://user-images.githubusercontent.com/10217/71766088-2a715a80-2f37-11ea-807d-394c8b840c59.png ">
Tell user if signatures are missing, offer to copy to clipboard:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 15 57" src="https://user-images.githubusercontent.com/10217/71766115-702e2300-2f37-11ea-9f62-a6ede499c0fa.png ">
Incomplete for another reason:
<img width="309" alt="Schermafbeelding 2020-01-04 om 21 07 51" src="https://user-images.githubusercontent.com/10217/71766090-2c3b1e00-2f37-11ea-8a22-6188377b67a1.png ">
ACKs for top commit:
instagibbs:
re-ACK 764bfe4cba
achow101:
ACK 764bfe4cba
jb55:
Tested ACK 764bfe4cba
jonatack:
ACK 764bfe4c
promag:
Code review ACK 764bfe4cba
.
Tree-SHA512: d284ed6895f3a271fb8ff879aac388ad217ddc13f72074725608e1c3d6d90650f6dc9e9e254479544dd71fc111516b02c8ff92158153208dc40fb2726b37d063
2020-04-23 13:16:23 +12:00
MarcoFalke
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-04-16 13:33:09 -04:00
Sjors Provoost
1cd8dc2556
[gui] load PSBT
...
co-authored-by: Glenn Willen <gwillen@nerdnet.org>
2020-03-27 14:59:19 +01:00
João Barbosa
cb8a86d9f9
gui: Remove WalletView and BitcoinGUI circular dependency
2020-01-30 11:38:06 +00:00
João Barbosa
ac3d10777d
gui: Add transactionClicked and coinsSent signals to WalletView
2020-01-30 11:31:07 +00:00
MarcoFalke
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
Andrew Chow
2c530ea2ad
HTML escape address labels in more dialogs and notifications
2019-09-08 16:40:37 -04:00
Andrew Chow
1770a972d4
HTML escape the wallet name in more dialogs and notifications
2019-09-08 16:40:05 -04:00
João Barbosa
d2ae6be80f
gui: Set progressDialog to nullptr
2019-06-02 22:18:19 +01:00
Hennadii Stepanov
7c572c488d
Add workaround for QProgressDialog bug on macOS
...
See: QTBUG-65750, QTBUG-70357.
2019-01-15 01:28:00 +02:00
practicalswift
9096276e0b
Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)
...
Qt-only changes.
2019-01-13 03:25:14 -08:00
João Barbosa
6fc21aca6d
qt: Use GUIUtil::bringToFront where possible
2018-11-05 11:21:50 +00:00
João Barbosa
f78558f1e3
qt: Use new Qt5 connect syntax
2018-08-21 09:43:54 +01:00
DrahtBot
eb7daf4d60
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
João Barbosa
12dd101345
scripted-diff: Remove trailing whitespaces
...
-BEGIN VERIFY SCRIPT-
sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue')
-END VERIFY SCRIPT-
2018-07-24 20:46:23 +01:00
Andrew Chow
69b01e6f8b
Add cancel button to rescan progress dialog
...
Adds a cancel button to the rescan progress dialog. When it is clicked,
AbortRescan is called to abort a rescan
2018-04-12 17:00:30 -04:00
Russell Yanofsky
17780d6f35
scripted-diff: Avoid interface
keyword to fix windows gitian build
...
Rename `interface` to `interfaces`
Build failure reported by Chun Kuan Lee <ken2812221@gmail.com>
https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756
-BEGIN VERIFY SCRIPT-
git mv src/interface src/interfaces
ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; }
ren interface/ interfaces/
ren interface:: interfaces::
ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_
ren "namespace interface" "namespace interfaces"
-END VERIFY SCRIPT-
2018-04-07 03:42:02 -04:00
Russell Yanofsky
a0704a8996
Remove most direct bitcoin calls from qt/walletmodel.cpp
2018-04-04 16:52:40 -04:00
Russell Yanofsky
fe6f27e6ea
Remove direct bitcoin calls from qt/clientmodel.cpp
2018-04-04 16:52:40 -04:00
Jonas Schnelli
12d8d2681e
Qt: When multiple wallets are used, include in notifications the name
2018-03-26 18:40:26 +07:00
Luke Dashjr
85d5319716
Qt: Ensure UI updates only come from the currently selected walletView
2018-03-06 12:03:26 +08:00
Sjors Provoost
e7d9fc5c53
[qt] navigate to transaction history page after send
...
The transaction will be selected. When sending to multiple
destinations, all will be selected (thanks @promag).
2018-03-01 10:40:36 +01:00
Akira Takizawa
595a7bab23
Increment MIT Licence copyright header year on files modified in 2017
2018-01-03 02:26:56 +09:00
MeshCollider
1a445343f6
scripted-diff: Replace #include "" with #include <> (ryanofsky)
...
-BEGIN VERIFY SCRIPT-
for f in \
src/*.cpp \
src/*.h \
src/bench/*.cpp \
src/bench/*.h \
src/compat/*.cpp \
src/compat/*.h \
src/consensus/*.cpp \
src/consensus/*.h \
src/crypto/*.cpp \
src/crypto/*.h \
src/crypto/ctaes/*.h \
src/policy/*.cpp \
src/policy/*.h \
src/primitives/*.cpp \
src/primitives/*.h \
src/qt/*.cpp \
src/qt/*.h \
src/qt/test/*.cpp \
src/qt/test/*.h \
src/rpc/*.cpp \
src/rpc/*.h \
src/script/*.cpp \
src/script/*.h \
src/support/*.cpp \
src/support/*.h \
src/support/allocators/*.h \
src/test/*.cpp \
src/test/*.h \
src/wallet/*.cpp \
src/wallet/*.h \
src/wallet/test/*.cpp \
src/wallet/test/*.h \
src/zmq/*.cpp \
src/zmq/*.h
do
base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f
done
-END VERIFY SCRIPT-
2017-11-16 08:23:01 +13:00
practicalswift
76fed838f3
Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
2017-10-02 17:20:08 +02:00
practicalswift
90d4d89230
scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h
sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp
sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp
sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp
sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp
sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp
-END VERIFY SCRIPT-
2017-08-07 07:36:37 +02:00
isle2983
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
2016-12-31 11:01:21 -07:00
Jonas Schnelli
24f72e9f3f
Merge #8371 : [Qt] Add out-of-sync modal info layer
...
08827df
[Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e
[Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4
[Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f
[Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18
[Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04
[Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c
[Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)
2016-09-23 18:22:48 +02:00
Jonas Schnelli
08827df3ec
[Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul
2016-09-23 16:07:21 +02:00
Pavel Janík
f839350420
Do not shadow in src/qt
2016-09-23 12:42:00 +02:00
Jonas Schnelli
bd44a04dc3
[Qt] make Out-Of-Sync warning icon clickable
2016-08-26 09:53:09 +02:00
Jonas Schnelli
914154f0cc
[Qt] add HD enabled/disabled icon to the status bar
2016-08-19 09:21:04 +02:00
MarcoFalke
fa24439ff3
Bump copyright headers to 2015
2015-12-13 18:08:39 +01:00
Casey Rodarmor
5ffaaba3a1
Disallow duplicate windows.
2015-09-04 15:25:42 -04:00
Wladimir J. van der Laan
eec7757445
qt: Introduce PlatformStyle
...
Introduce a PlatformStyle to handle platform-specific customization of
the UI.
This replaces 'scicon', as well as #ifdefs to determine whether to place
icons on buttons.
The selected PlatformStyle defaults to the platform that the application
was compiled on, but can be overridden from the command line with
`-uiplatform=<x>`.
Also fixes the warning from #6328 .
2015-07-31 09:35:18 +02:00
Wladimir J. van der Laan
d29ec6c230
qt: define QT_NO_KEYWORDS
...
QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`,
`slots` and `emit` macros.
Avoid overlap between Qt macros and boost - for example #undef hackiness
in #6421 .
2015-07-15 07:30:23 +02:00
Luke Dashjr
721cb557aa
GUI: Display label rather than address on popups
2015-03-06 15:07:43 +00:00
Luke Dashjr
9b7d3fb165
Adopt style colour for button icons
2014-12-27 19:04:49 +01:00
sandakersmann
f914f1a746
Added "Core" to copyright headers
...
Github-Pull: #5494
Rebased-From: 15de949bb9
2014-12-19 19:55:32 +01:00