Kiminuo
39b1763730
Replace use of ArgsManager
with DatabaseOptions
...
Co-authored-by: Russell Yanofsky <russ@yanofsky.org>
2022-03-16 08:26:28 +01:00
Russell Yanofsky
f7086fd8ff
Add src/wallet/* code to wallet:: namespace
2022-01-06 22:14:16 -05:00
Hennadii Stepanov
f47dda2c58
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
* 2020: fa0074e2d8
* 2019: aaaaad6ac9
2021-12-30 19:36:57 +02:00
Kiminuo
2ec38bdebb
Remove gArgs
from wallet.h
and wallet.cpp
...
Co-authored-by: Russell Yanofsky <russ@yanofsky.org>
2021-11-09 11:27:06 +01:00
Samuel Dobson
bccd1d942d
Remove -rescan startup parameter
2021-09-30 12:06:27 +13:00
MarcoFalke
fac30eec42
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
fanquake
3ba2840e7e
scripted-diff: remove MakeUnique<T>()
...
-BEGIN VERIFY SCRIPT-
git rm src/util/memory.h
sed -i -e 's/MakeUnique/std::make_unique/g' $(git grep -l MakeUnique src)
sed -i -e '/#include <util\/memory.h>/d' $(git grep -l '#include <util/memory.h>' src)
sed -i -e '/util\/memory.h \\/d' src/Makefile.am
-END VERIFY SCRIPT-
2021-03-11 13:45:14 +08:00
Russell Yanofsky
6a7a63644c
refactor: Drop call to GetWalletEnv in wallet salvage code
...
No observable change in behavior. This just avoids a redundant environment
lookup. Motivation is to be able to simplify the GetWalletEnv implementation in
an upcoming commit.
2020-12-04 11:03:28 -04:00
Andrew Chow
6ebc41bf9c
Enforce salvage is only for BDB wallets
2020-11-18 11:56:12 -05:00
Andrew Chow
b33af48210
Include wallet/bdb.h where it is actually being used
2020-11-18 11:55:43 -05:00
Russell Yanofsky
7bf6dfbb48
wallet: Remove path checking code from bitcoin-wallet tool
...
This commit does not change behavior except for error messages which now
include more complete information.
2020-09-03 12:24:32 -04:00
Russell Yanofsky
288b4ffb6b
Remove WalletLocation class
...
This removes a source of complexity and indirection that makes it harder to
understand path checking code. Path checks will be simplified in upcoming
commits.
There is no change in behavior in this commit other than a slightly more
descriptive error message in `loadwallet` if the default "" wallet can't be
found. (The error message is improved more in upcoming commit "wallet: Remove
path checking code from loadwallet RPC".)
2020-09-03 12:24:32 -04:00
Andrew Chow
0bbe26a1af
wallet: filter for keys only before record deser in salvage
...
When salvaging a wallet, avoid deserializing any records that we don't
care about, i.e. filter for keys only before the deserialization.
2020-08-25 13:23:40 -04:00
Andrew Chow
9f536d4fe9
wallettool: Have RecoverDatabaseFile return errors and warnings
...
Instead of logging or printing these errors and warnings, return them to
the caller.
2020-07-26 20:22:45 -04:00
Andrew Chow
d0ea9bab28
walletdb: Don't remove database transaction logs and instead error
...
Instead of removing the database transaction logs and retrying the
wallet loading, just return an error message to the user. Additionally,
specifically for DB_RUNRECOVERY, notify the user that this could be due
to different BDB versions. This error is pretty much only caused by
compiling with a newer version of BDB and then trying to open the wallet
with a version compiled with an older version of BDB.
2020-07-13 11:00:54 -04:00
Andrew Chow
8f1bcf8b7b
walletdb: Combine VerifyDatabaseFile and VerifyEnvironment
...
Combine these two functions into a single Verify function that is a
member of WalletDatabase. Additionally, these are no longer static.
2020-07-01 12:32:03 -04:00
Andrew Chow
d6045d0ac6
scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase
...
-BEGIN VERIFY SCRIPT-
sed -i -e 's/WalletDatabase::Create(/CreateWalletDatabase(/g' `git grep -l "WalletDatabase::Create("`
sed -i -e 's/WalletDatabase::CreateDummy(/CreateDummyWalletDatabase(/g' `git grep -l "WalletDatabase::CreateDummy("`
sed -i -e 's/WalletDatabase::CreateMock(/CreateMockWalletDatabase(/g' `git grep -l "WalletDatabase::CreateMock("`
-END VERIFY SCRIPT-
2020-06-17 14:12:41 -04:00
Andrew Chow
ea337f2d03
Move RecoverKeysOnlyFilter into RecoverDataBaseFile
2020-05-25 12:59:29 -04:00
Andrew Chow
9ea2d258b4
Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}
2020-05-25 12:59:29 -04:00