phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-12 21:02:38 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions
34440 commits 6 branches 321 tags 2.2 GiB
Commit graph

34440 commits

This branch
This branch
All branches
Author SHA1 Message Date
Hennadii Stepanov
8e017f3288
ci, refactor: Add MACOS_NATIVE_TASK_TEMPLATE 
A native macOS task does not aware of Linux container settings, and it
does not use the `depends_built_cache`.
 2022-06-22 10:14:34 +02:00
MarcoFalke
fa07f84e31
Fix signed integer overflow in prioritisetransaction RPC 2022-06-22 09:32:09 +02:00
MarcoFalke
fa52cf8e11
refactor: Replace feeDelta by m_modified_fee 
* feeDelta tracked the delta (to be applied on top of the actual fee)
* m_modified_fee tracks the actual fee with the delta included
* Instead of passing in the new total delta to the Updater, pass in by
  how much the total delta should be modified.

This is needed for the next commit, but makes sense on its own because
the same is done by UpdateDescendantState and UpdateAncestorState.
 2022-06-22 09:32:07 +02:00
Vasil Dimov
a724c39606
net: rename Sock::Reset() to Sock::Close() and make it private 
Outside of `Sock`, `Sock::Reset()` was used in just one place (in
`i2p.cpp`) which can use the assignment operator instead.

This simplifies the public `Sock` API by having one method less.
 2022-06-22 09:19:43 +02:00
MacroFake
faee330c7b
test: Fail if connect_nodes fails 
Also replace the use of wait_until_helper, which is not allowed to be
called directly. Otherwise, --timeout-factor will not be honoured.
 2022-06-22 09:15:33 +02:00
MarcoFalke
fa7cbc6e5c
build: Remove negated --enable-fuzz checks from build system 2022-06-22 08:12:23 +02:00
Igor Bubelov
f67b6fce37 Update Arch Linux build example 2022-06-22 13:12:03 +07:00
MacroFake
e3b06e8dd8
Merge bitcoin/bitcoin#25440: log: Use consistent wording in random.cpp log 
c01ae8f5ea Use consistent wording in log (Igor Bubelov)

Pull request description:

  It's a trivial change, but it bothers me a bit that two log lines in a row aren't grammatically identical while following exactly the same pattern. I've read `contributing.md` and I'm aware that changes like this are usually being ignored and dropped, but I decided to leave it here anyway in case someone feels the same way about inconsistent log messages or grammar =)

ACKs for top commit:
  laanwj:
    Code review ACK c01ae8f5ea

Tree-SHA512: d5b3849b3a6e3de7ea9b468c05f17cacd1dbd1aca2f3401b5138383dc8d385cea9e221db558ab472c1c4c7f6921d57dcc7af89a54776c5765fa00e429694b4e7
 2022-06-22 07:49:22 +02:00
MacroFake
1b71c76886
Merge bitcoin/bitcoin#25435: test: Remove from_node from create_self_transfer* MiniWallet helpers 
fa8421bc5b test: Remove from_node from create_self_transfer* MiniWallet helpers (MacroFake)

Pull request description:

  MiniWallet is capable to create a transaction without a node, so don't pass it in where not needed.

ACKs for top commit:
  kouloumos:
    ACK fa8421bc5b
  theStack:
    ACK fa8421bc5b

Tree-SHA512: d51e2ae6577c1e2bc80386678ff5c7974609e86317850aaec45cdbf0d23076ba1ae76342610c8f90931a6c0971c8e916864442b041a253212e6a9d476d79c541
 2022-06-22 07:32:03 +02:00
laanwj
a4e066af85
Merge bitcoin/bitcoin#24352: Add doc/design/libraries.md 
dc1e7ad7a5 Add doc/design/libraries.md (Ryan Ofsky)

Pull request description:

  Prompted by the [libbitcoinkernel issue #24303](https://github.com/bitcoin/bitcoin/issues/24303) and PRs, I started looking at  existing libraries and what their dependencies are and wrote this document to describe them and where `libbitcoinkernel` fits in.

  Readable link is:  https://github.com/ryanofsky/bitcoin/blob/pr/libs/doc/design/libraries.md

  Feedback is welcome

ACKs for top commit:
  laanwj:
    ACK dc1e7ad7a5
  hebasto:
    Approach ACK dc1e7ad7a5, using this doc as a guide in https://github.com/hebasto/bitcoin/pull/3 :)

Tree-SHA512: 7687b1847797c50de1f5ea721bd201cc8304690064743fbe6d69e2198cc239084e9da7d158be65bea948a6ec3d71d74c84122c0e523c390b389b49ea8d2cddc9
 2022-06-22 07:13:17 +02:00
laanwj
58b9d6cf9e
Merge bitcoin-core/gui#620: Replace QRegExp with QRegularExpression 
67364ebe4c test, qt: Add tests for `GUIUtil::extractFirstSuffixFromFilter` (w0xlt)
ace9af5688 qt: Replace `QRegExp` with `QRegularExpression` (w0xlt)
c378535e28 qt: Add a function that extracts the suffix from a filter (w0xlt)

Pull request description:

  Picking up https://github.com/bitcoin-core/gui/pull/606 (labeled "Up for grabs") and applying https://github.com/bitcoin-core/gui/pull/606#pullrequestreview-984607067 and https://github.com/bitcoin-core/gui/pull/606#issuecomment-1137149907.

  Replaces occurrences of `QRegExp` usage with `QRegularExpression` as part of the roadmap for Qt6 integration.

  Fixes https://github.com/bitcoin-core/gui/issues/578

ACKs for top commit:
  laanwj:
    Code review and lightly tested ACK 67364ebe4c
  hebasto:
    ACK 67364ebe4c

Tree-SHA512: 4a17d83e557bc635cbd1a15776856e9edb7162b23a369ccbd2ac59c68b8a1ea663baaa7d5ad98e419dc03b91ef3315c768eeadc01c0b29162de109493161e814
 2022-06-22 07:12:10 +02:00
Andrew Chow
174b821e64
Merge bitcoin/bitcoin#25427: wallet: remove extra wtx lookup in AddToSpends 
32e5edc0f4 wallet: avoid extra wtx lookup in AddToSpends (furszy)

Pull request description:

  As `AddToSpends` is only called from `AddToWallet` and `LoadToWallet`, places where we insert the wtx into the wallet map, we can directly feed `AddToSpends` with the `wtx` and remove another extra lookup.

ACKs for top commit:
  laanwj:
    Code review ACK 32e5edc0f4
  achow101:
    ACK 32e5edc0f4
  theStack:
    Code-review ACK 32e5edc0f4
  w0xlt:
    Code Review ACK 32e5edc0f4
  brunoerg:
    crACK 32e5edc0f4

Tree-SHA512: e9fb8df44c3e3fa26c107d261bf78e45014b4755890a64817f2be62ee6b7751f5dd2813a18dcb103a21ddba1422f9d2d59c4bf186f08314e634365d36b01be8f
 2022-06-21 20:56:24 -04:00
w0xlt
67364ebe4c test, qt: Add tests for GUIUtil::extractFirstSuffixFromFilter 2022-06-21 19:19:31 -03:00
w0xlt
ace9af5688 qt: Replace QRegExp with QRegularExpression 
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
 2022-06-21 19:19:18 -03:00
w0xlt
c378535e28 qt: Add a function that extracts the suffix from a filter 
Extract the 'Extract first suffix from filter pattern...'
functionality into a testable utility function
 2022-06-21 19:16:39 -03:00
laanwj
7377ed778c
Merge bitcoin/bitcoin#25389: guix: use libtool 2.4.7 
4a81ef4510 doc: update configure ar doc to mention libtool 2.4.7 (fanquake)
679ecdd14b guix: use libtool 2.4.7 (fanquake)

Pull request description:

  As of version 2.4.7, libtool now respects ARFLAGS, and has changed the default `ARFLAGS` from `cru` to `cr` (which, historically, we have also done, [see configure](d6832217ef/configure.ac (L33))).

  This eliminates spammy `ar` output such as:
  ```bash
    CXXLD    libunivalue.la
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
    AR       libbitcoin_zmq.a
    AR       libbitcoin_consensus.a
    CXXLD    crypto/libbitcoin_crypto_base.la
    CXXLD    crypto/libbitcoin_crypto_sse41.la
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
    CXXLD    crypto/libbitcoin_crypto_avx2.la
    CXXLD    crypto/libbitcoin_crypto_x86_shani.la
    CXXLD    leveldb/libleveldb.la
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
    CXXLD    crc32c/libcrc32c.la
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
    CXXLD    leveldb/libmemenv.la
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
  /root/.guix-profile/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
    AR       libbitcoin_cli.a
  ```

  [Libtool 2.4.7 release notes](https://lists.gnu.org/archive/html/autotools-announce/2022-03/msg00000.html):
  ** New features:

    - Libtool script now supports (configure-time and runtime) ARFLAGS
      variable, which obsoletes AR_FLAGS.  This is due to naming conventions
      among other *FLAGS and to be consistent with Automake's ARFLAGS.

  ** Important incompatible changes:

    - Libtool changed ARFLAGS/AR_FLAGS default from 'cru' to 'cr'.

  Guix Build (x86_64):
  ```bash
  a4da07d0166a7018d1cb7cddd734c9efe062bd28a6349ebdbf427adf353f2acf  guix-build-4a81ef451094/output/aarch64-linux-gnu/SHA256SUMS.part
  e2418d772c8f409b9bfde3bcf494f3d320d89970a4305e8799a8f59ecbd66906  guix-build-4a81ef451094/output/aarch64-linux-gnu/bitcoin-4a81ef451094-aarch64-linux-gnu-debug.tar.gz
  44a877696205b1d60d07e60d01d5427d9ed7efaf8cf62db719bc057a0df77636  guix-build-4a81ef451094/output/aarch64-linux-gnu/bitcoin-4a81ef451094-aarch64-linux-gnu.tar.gz
  b911cae3d8a73eda2f9224a6073e14e26a1aec7f2cb85dc9d949d22ca4e9f4b4  guix-build-4a81ef451094/output/arm-linux-gnueabihf/SHA256SUMS.part
  6fa645e1dbaa77fd082b860852b4a32114d317d630e8791dad14d154a203cd40  guix-build-4a81ef451094/output/arm-linux-gnueabihf/bitcoin-4a81ef451094-arm-linux-gnueabihf-debug.tar.gz
  3d86f047e5453ee73cd4dab4ac0b3a97928914f7469b9bcc807230b38b471f3f  guix-build-4a81ef451094/output/arm-linux-gnueabihf/bitcoin-4a81ef451094-arm-linux-gnueabihf.tar.gz
  1c0dbc156292c3d142e63b29d1fb9c9b6623db5698f59b2bfce96674438780a6  guix-build-4a81ef451094/output/arm64-apple-darwin/SHA256SUMS.part
  17f4c3bf0527ec2bde06691c301e8c6c5290178238a21aa10d3672917eccb27d  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin-unsigned.dmg
  5ed1de03d5d87249fc8671f5641816513a93784d38873d277bdf49a4b98b9ba3  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin-unsigned.tar.gz
  fb18089efdb291714f1359a548a9f101d5fcc9bdc653cd406ab28f7e02713bcd  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin.tar.gz
  4f816681c778b8bb9522be31807d1d60c724383cfa4ae820dd829b716d934939  guix-build-4a81ef451094/output/dist-archive/bitcoin-4a81ef451094.tar.gz
  3af9f38caf09f4424b7a982b5992407fb4ce5574a0e98af0b0558ec85a12519d  guix-build-4a81ef451094/output/powerpc64-linux-gnu/SHA256SUMS.part
  cf88399bc6ea96df3742cb87bfa0629b22b001f49a6ccfb35b66f7dd46a47a94  guix-build-4a81ef451094/output/powerpc64-linux-gnu/bitcoin-4a81ef451094-powerpc64-linux-gnu-debug.tar.gz
  93158fd0b9d3c74565917395d0199d2b9f8b1821dd4aa207f804ee93bd0e4a3d  guix-build-4a81ef451094/output/powerpc64-linux-gnu/bitcoin-4a81ef451094-powerpc64-linux-gnu.tar.gz
  c970dd4dcbd25f2a94eaf526756fc0c01920452f4e42b4dd51fea8bf04f1c7ca  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/SHA256SUMS.part
  80e488a199b91fc2763da94bf5c4024a7173404419f97c68b825dd6c7dccafbc  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/bitcoin-4a81ef451094-powerpc64le-linux-gnu-debug.tar.gz
  00159823c8f0daab6c1034c9648742b6569fe07b50091f4850f5b028d9f1dc83  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/bitcoin-4a81ef451094-powerpc64le-linux-gnu.tar.gz
  f796cbe82e3d4f8ed90647728ad76afae4691c671f5a79c87f0b7a41d67c0a3e  guix-build-4a81ef451094/output/riscv64-linux-gnu/SHA256SUMS.part
  b51be33b674def05b1d8b0b74a2e8c0340fb911859936e3e0024ecac09540270  guix-build-4a81ef451094/output/riscv64-linux-gnu/bitcoin-4a81ef451094-riscv64-linux-gnu-debug.tar.gz
  9f0e52c0b0c706359e28a591c6de71502520e6de9941a6cf378c1c83ebd66480  guix-build-4a81ef451094/output/riscv64-linux-gnu/bitcoin-4a81ef451094-riscv64-linux-gnu.tar.gz
  e145886b3f06d6a69db1657e19661cfb1c95f9b35aac3d3efd89f89f791fa909  guix-build-4a81ef451094/output/x86_64-apple-darwin/SHA256SUMS.part
  7a3512718270cc9be241d1ca0c7f8f37ebeb620e6c5a1a70992aef99bc209854  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin-unsigned.dmg
  0439552bc901a9fd10251c1e4a2eb685aae7b4edcf8f047a28eba837d8b6c960  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin-unsigned.tar.gz
  4c1ce8786b3c381250b8071a17bc6d705e3e5e672909ffeacfa2171814dee527  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin.tar.gz
  9c08271cee5f3bba08866fcc609290dd009b85793460188a4b3c5df5ac83d002  guix-build-4a81ef451094/output/x86_64-linux-gnu/SHA256SUMS.part
  04285f7e68bc25834fe7830f15b1fd0102cd1f02f23701a8f423cf0835d1af5f  guix-build-4a81ef451094/output/x86_64-linux-gnu/bitcoin-4a81ef451094-x86_64-linux-gnu-debug.tar.gz
  b0e467b2ccb1b391ddb981f1d1b16f0f6de71aa8177f7735a88989fdc4ade449  guix-build-4a81ef451094/output/x86_64-linux-gnu/bitcoin-4a81ef451094-x86_64-linux-gnu.tar.gz
  6adb17642959fee8d123482bf0ec5ad0a4f10e63c87bf45447d1e57ab873d2bc  guix-build-4a81ef451094/output/x86_64-w64-mingw32/SHA256SUMS.part
  ac1989f332d1bd5d0acabb7ce28236a80fd6a42eac93c7287f890148ef2999bc  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-debug.zip
  31816d2ef52be01a69fd8701e3da61a32dddaccdd1d424de00a412a798d97b87  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-setup-unsigned.exe
  ecc41932934e5e746883648fd4ee5edf4cd5cadd944d799b31e41aad249c8d7d  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-unsigned.tar.gz
  8634ad4feb1118fc89abd96489533c81176b7172750b8f2cf18a3e10377a8d65  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64.zip
  ```
  Guix Build (arm64):
  ```bash
  b70e6fc1be044e347800d7de78a1c950961f5c52abc724fa8c6fe8556b3ef3ca  guix-build-4a81ef451094/output/arm-linux-gnueabihf/SHA256SUMS.part
  62e670fcedc2cb746b3c589edfa9a0950097256ef974c58984a9f252c91b802a  guix-build-4a81ef451094/output/arm-linux-gnueabihf/bitcoin-4a81ef451094-arm-linux-gnueabihf-debug.tar.gz
  2637e5c31380fbae1ec5efb1792124a0554d49516e1964a609560487ea673ebb  guix-build-4a81ef451094/output/arm-linux-gnueabihf/bitcoin-4a81ef451094-arm-linux-gnueabihf.tar.gz
  1554617b965611ea618664652b566f2c5a16c94fa57572ea31b66a40bb845b3c  guix-build-4a81ef451094/output/arm64-apple-darwin/SHA256SUMS.part
  a98efc26e78ce749d75fc467822f6e68c6b3b7abc5d24e8edaa40b19c6b40632  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin-unsigned.dmg
  ecd9057eaa2c7166b1320bd85555258fd6a49690b29331cdde7b4c9af05acc0d  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin-unsigned.tar.gz
  9417c58463488f3eeddcdfc5440d1cb341d6424517e4b69c227f4291853d3fa6  guix-build-4a81ef451094/output/arm64-apple-darwin/bitcoin-4a81ef451094-arm64-apple-darwin.tar.gz
  4f816681c778b8bb9522be31807d1d60c724383cfa4ae820dd829b716d934939  guix-build-4a81ef451094/output/dist-archive/bitcoin-4a81ef451094.tar.gz
  25cddb3a6a22d1e57cef92d96b106df0fff5d5c3987c3673decad63db834765b  guix-build-4a81ef451094/output/powerpc64-linux-gnu/SHA256SUMS.part
  cb99c30a117e650b837e1e5d835be5e51b282158139b8fd591fa4b6f1aa709db  guix-build-4a81ef451094/output/powerpc64-linux-gnu/bitcoin-4a81ef451094-powerpc64-linux-gnu-debug.tar.gz
  66a182566f0950f7b0d9de497118ce3635ca5acf78c356a1fea6f815f61ce94b  guix-build-4a81ef451094/output/powerpc64-linux-gnu/bitcoin-4a81ef451094-powerpc64-linux-gnu.tar.gz
  d5f65e1d6cb8de238f1c50ec30c0848675274126d197e274d51fed32de3860ad  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/SHA256SUMS.part
  4c2fe35cc087d5e268eb2202cc6579442d4c6b9d6d7b61c55753c6600f8070e7  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/bitcoin-4a81ef451094-powerpc64le-linux-gnu-debug.tar.gz
  918da28dbd9c2db024a31877c3913e1e717c1099d91cb32798ea4afee6b80b72  guix-build-4a81ef451094/output/powerpc64le-linux-gnu/bitcoin-4a81ef451094-powerpc64le-linux-gnu.tar.gz
  ba3c1095676c3f2255a3fb581404887783d234ed44bd89b7fd96016cccadd401  guix-build-4a81ef451094/output/riscv64-linux-gnu/SHA256SUMS.part
  9492973869a7f6274ffe20758ef113cc5f11465c08b465aa18d28618cee6d0fb  guix-build-4a81ef451094/output/riscv64-linux-gnu/bitcoin-4a81ef451094-riscv64-linux-gnu-debug.tar.gz
  a4a767045b987f87994eb50ab5bc17639707e184a58aa66842d8cb9d7a4dffb4  guix-build-4a81ef451094/output/riscv64-linux-gnu/bitcoin-4a81ef451094-riscv64-linux-gnu.tar.gz
  e145886b3f06d6a69db1657e19661cfb1c95f9b35aac3d3efd89f89f791fa909  guix-build-4a81ef451094/output/x86_64-apple-darwin/SHA256SUMS.part
  7a3512718270cc9be241d1ca0c7f8f37ebeb620e6c5a1a70992aef99bc209854  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin-unsigned.dmg
  0439552bc901a9fd10251c1e4a2eb685aae7b4edcf8f047a28eba837d8b6c960  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin-unsigned.tar.gz
  4c1ce8786b3c381250b8071a17bc6d705e3e5e672909ffeacfa2171814dee527  guix-build-4a81ef451094/output/x86_64-apple-darwin/bitcoin-4a81ef451094-x86_64-apple-darwin.tar.gz
  e19a0c510a95662fef30fc3ea1f2496ae8957df1814f237d4a7c1ef40ba47728  guix-build-4a81ef451094/output/x86_64-linux-gnu/SHA256SUMS.part
  1712aca301825d985f7f9e333ebdc2ff0b7f385f79fbecc9747c8a183c15fdac  guix-build-4a81ef451094/output/x86_64-linux-gnu/bitcoin-4a81ef451094-x86_64-linux-gnu-debug.tar.gz
  b40369ea098a02a1cc4e0f5812e9947608d218542038364fb5ce743d9c9e3686  guix-build-4a81ef451094/output/x86_64-linux-gnu/bitcoin-4a81ef451094-x86_64-linux-gnu.tar.gz
  9402b3b6ce1e6642a60e5324ebef565c8c0d4b49085ff6fa2105097f4879f389  guix-build-4a81ef451094/output/x86_64-w64-mingw32/SHA256SUMS.part
  0e810115ea0269311a07cf868270094ced40cb10cfb2faa5db0b8ec881bc46f9  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-debug.zip
  31816d2ef52be01a69fd8701e3da61a32dddaccdd1d424de00a412a798d97b87  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-setup-unsigned.exe
  ecc41932934e5e746883648fd4ee5edf4cd5cadd944d799b31e41aad249c8d7d  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64-unsigned.tar.gz
  dbf4dca62ad173df82571a996ceeef4fba715d600716062d9f851a71cbdd1c9a  guix-build-4a81ef451094/output/x86_64-w64-mingw32/bitcoin-4a81ef451094-win64.zip
  ```

ACKs for top commit:
  dongcarl:
    ACK 4a81ef4510
  hebasto:
    ACK 4a81ef4510

Tree-SHA512: f853580ce594d26446968466d079e68e0c432c2db96a2c686297b78abbf33e9a451a441287468b1684a2f223ba709210bfdf422b7737464d87a7b9934c198761
 2022-06-22 00:03:53 +02:00
laanwj
c3a41ad980
Merge bitcoin/bitcoin#25314: p2p: always set nTime for self-advertisements 
99b9e5f3a9 p2p: always set nTime for self-advertisements (Martin Zumsande)

Pull request description:

  This logic was recently changed in 0cfc0cd322 to overwrite `addrLocal` with the address they gave us when self-advertising to an inbound peer. But if we don't also change `nTime` again from the default `TIME_INIT`, our peer will not relay our advertised address any further.

ACKs for top commit:
  naumenkogs:
    ACK 99b9e5f3a9
  laanwj:
    Code review ACK 99b9e5f3a9
  vasild:
    ACK 99b9e5f3a9

Tree-SHA512: 4c7ea51cc77ddaa4b3537962ad2ad085f7ef5322982d3b1f5baecb852719eb99dd578436ca63432cb6b0a4fbd8b59fca793caf326c4663a4d6f34301e8146aa2
 2022-06-22 00:00:43 +02:00
MacroFake
fafee78188
rpc: Return incrementalrelayfee in getmempoolinfo 2022-06-21 18:03:29 +02:00
Igor Bubelov
c01ae8f5ea Use consistent wording in log 2022-06-21 22:54:55 +07:00
fanquake
34869114a7
Merge bitcoin/bitcoin#25394: build: add *_STANDARD vars to depends gen_id 
f862f4a74e build: add *_STANDARD vars to depends gen_id (fanquake)

Pull request description:

  Followup to #22380 😅. We need to have these in `gen_id` so that we rebuild if we change / unset a *_STANDARD.

  Guix Build (x86_64):
  ```bash
  afc2a24bae06f87b7f14f0958b2ca497c050f6069e68958e45120215bab4507e  guix-build-f862f4a74ec6/output/aarch64-linux-gnu/SHA256SUMS.part
  547266e64002dc1124adedc1679f4c526088212b6ba31fb3457523adeb80be50  guix-build-f862f4a74ec6/output/aarch64-linux-gnu/bitcoin-f862f4a74ec6-aarch64-linux-gnu-debug.tar.gz
  af73193740f93d9ff13ed4eb459aabaf942e7075ac53967f5505bbebfea1eb9f  guix-build-f862f4a74ec6/output/aarch64-linux-gnu/bitcoin-f862f4a74ec6-aarch64-linux-gnu.tar.gz
  b36f58a4e37ed30ac8463716b5ed715f427e419d80d7e90381341fcab2712427  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/SHA256SUMS.part
  1ed49ea3efd7d9f5eba53d8e73356e82dfb5da2050f91a284dd38f157fa790b4  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/bitcoin-f862f4a74ec6-arm-linux-gnueabihf-debug.tar.gz
  dfaf6359511fa82a36448e16722179bd49d1d04e366cf140aaa0dfaa1be75b12  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/bitcoin-f862f4a74ec6-arm-linux-gnueabihf.tar.gz
  41dbc79a8372c2dd2eccc1af282e160f749faacd51c5d2594e8d48afaa6df5bc  guix-build-f862f4a74ec6/output/arm64-apple-darwin/SHA256SUMS.part
  abe6a3506441faeebdc08682c92d51ba3a0e5fc6af3a2b28f054d0ea1f2b5781  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin-unsigned.dmg
  01be81fd0c99a384afd06806441fb1775fc4a875153a3e699417a2c74547ad3a  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin-unsigned.tar.gz
  7e1b5547d5deb5944b6b3552634e3dd737da144c87ce75a5e9029e4edfe126a4  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin.tar.gz
  c4387c1d98f7146aa8926d827129063d502cd9b098a2674c487e550036df36fb  guix-build-f862f4a74ec6/output/dist-archive/bitcoin-f862f4a74ec6.tar.gz
  084912a415d3c8eedf47a60684abc7c753977ecf8990bd72c67158371cf39e2c  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/SHA256SUMS.part
  17f3aba98063f51af29b8b3ad2d9edd9a34b39aee09c82d28e8f49e765395de8  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/bitcoin-f862f4a74ec6-powerpc64-linux-gnu-debug.tar.gz
  12ebd244f31597a54c0b93d23dc6d2a7b375d47edf9576e205d23c7ca7c2cac8  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/bitcoin-f862f4a74ec6-powerpc64-linux-gnu.tar.gz
  c28467af85a6a043cc5c80234680eabc3cbb2857b778b412a128c039c85c419a  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/SHA256SUMS.part
  69ae9c40f0d413e0cfdff58dab0e6938c58a72f8cf3c7b6259e2da67dae61b1a  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/bitcoin-f862f4a74ec6-powerpc64le-linux-gnu-debug.tar.gz
  c75065dcab7260d6072dcb753cf43976a7ad6b0c2be1ab2f96d65b99083c0628  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/bitcoin-f862f4a74ec6-powerpc64le-linux-gnu.tar.gz
  63fdefb6c04fc61fc4354d4f6bc1b1530595e21ecbd9e8dfc7a459e9daaaad32  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/SHA256SUMS.part
  9e5c7a8d459befce46742c254f74771c95d91496a350f396878c204003375f28  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/bitcoin-f862f4a74ec6-riscv64-linux-gnu-debug.tar.gz
  884a789984eda3e3c68f69e975cf664a2bb4e6986b649ab6f09f529995c84702  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/bitcoin-f862f4a74ec6-riscv64-linux-gnu.tar.gz
  59821609cd76efdc8efb1deacaf9f1bc6af754a764ebfbdad47df392152e19ac  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/SHA256SUMS.part
  5f48f56c2efe5ccf9bb22c6ba78af6c019f2df86eacada8241a7a351e0b81f83  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin-unsigned.dmg
  73d0885ac4208345ff8a762a8a421e4812af621b441cfb6ddf4430a0ce657620  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin-unsigned.tar.gz
  9b001f66b969e80c3d22d0eadceaa53d16440e2c1550d181e4e63747de8779f5  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin.tar.gz
  0ace0d29576c6bf110ad7a067399eca649960a7dd6a33b03e82a4eadcfec0fa1  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/SHA256SUMS.part
  3efea8a971c36d642cbfa7fd5d95044f895c81e4729281588726689c4cc4688e  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/bitcoin-f862f4a74ec6-x86_64-linux-gnu-debug.tar.gz
  afa95414ab703a0cdb632b963ef28ba93bb8f136590c5169c90b3906858282d5  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/bitcoin-f862f4a74ec6-x86_64-linux-gnu.tar.gz
  7993b7ed1592f440c498f7643c2a8cc36d0e4c887b77d6fc7e5bef2cc85afb7a  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/SHA256SUMS.part
  54ab6be514f0f865858d278997c409d96572a1f33aa85fd819f395d57aa4a388  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-debug.zip
  90a04f298826699c808519846cb1cec50047ff2959471a684b26c20a2e504c47  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-setup-unsigned.exe
  f487dd6a8d1eb7566df85c1b2fe536352e4e0c3e50c911766f1daccdbdf5706d  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-unsigned.tar.gz
  82be7831089e8245c17ed3d61cd56606b36554c15978c1a64181df02df918a14  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64.zip

  ```

  Guix Build (arm64):
  ```bash
  b465ed412b625a0980473d359e0b34ec646d90d844d1055ad61f99d5a4e08e47  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/SHA256SUMS.part
  0391c59642724c205f466844995c8dc702a581278295189c4ef39c1dd53c915a  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/bitcoin-f862f4a74ec6-arm-linux-gnueabihf-debug.tar.gz
  42ff69794e2c61b205e6f9e8060aa4b5c382c6ba53c1a91dfd46069619ac589a  guix-build-f862f4a74ec6/output/arm-linux-gnueabihf/bitcoin-f862f4a74ec6-arm-linux-gnueabihf.tar.gz
  b26d85b2beb0e8812d71833f493d623ac9419d2f791f34d3726bff387541d096  guix-build-f862f4a74ec6/output/arm64-apple-darwin/SHA256SUMS.part
  0e2a81f2a4ea64b2a7407b52499af41e9a8448d56ebcc65befda42bac964f94e  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin-unsigned.dmg
  f896df86baab84c737a5e2082b184e77a6b983a1a8dfbc1282ed22d7cea5aa0b  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin-unsigned.tar.gz
  3c3be5e7fc97950c612c00f36970e498f356147fee4c0f590298f5ad94fbc7a6  guix-build-f862f4a74ec6/output/arm64-apple-darwin/bitcoin-f862f4a74ec6-arm64-apple-darwin.tar.gz
  c4387c1d98f7146aa8926d827129063d502cd9b098a2674c487e550036df36fb  guix-build-f862f4a74ec6/output/dist-archive/bitcoin-f862f4a74ec6.tar.gz
  792e2ae8c991203765aaa080c58111c57bd59cf217cbf0b461e50cde10754d5b  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/SHA256SUMS.part
  ff68b5693861bc5d9e016ea23e976367f8d4b7655bdbe16c71a02704dc7f602c  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/bitcoin-f862f4a74ec6-powerpc64-linux-gnu-debug.tar.gz
  d6385cfce11872d7008e345cfe6396e24dc37b2367139ce95841a16a91853c0b  guix-build-f862f4a74ec6/output/powerpc64-linux-gnu/bitcoin-f862f4a74ec6-powerpc64-linux-gnu.tar.gz
  9c14549a899c7ac550d4d6e51ebd0416bb62ad31351bc18dac9eada5a2b41d1b  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/SHA256SUMS.part
  e7557409ee809483be422c1f046f3de4994538e3dc840f9683dc341f35897006  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/bitcoin-f862f4a74ec6-powerpc64le-linux-gnu-debug.tar.gz
  a2b9e75edccfadb7b54b7e01cd3ea602aa1d6907037bf8c1517637558e08beb6  guix-build-f862f4a74ec6/output/powerpc64le-linux-gnu/bitcoin-f862f4a74ec6-powerpc64le-linux-gnu.tar.gz
  099b822c656c738b2f4119dffc9630af7c398acd9039d65520653158c05eaff9  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/SHA256SUMS.part
  6bcff8b4b4d68e18fd19d7407be3ba2768894a46e53a10e7a1ea5e730bddf216  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/bitcoin-f862f4a74ec6-riscv64-linux-gnu-debug.tar.gz
  58c3e536e0f199f85d3a71aa5ae41bcebc4bba94fe8b93062a01952f80e3fd49  guix-build-f862f4a74ec6/output/riscv64-linux-gnu/bitcoin-f862f4a74ec6-riscv64-linux-gnu.tar.gz
  59821609cd76efdc8efb1deacaf9f1bc6af754a764ebfbdad47df392152e19ac  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/SHA256SUMS.part
  5f48f56c2efe5ccf9bb22c6ba78af6c019f2df86eacada8241a7a351e0b81f83  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin-unsigned.dmg
  73d0885ac4208345ff8a762a8a421e4812af621b441cfb6ddf4430a0ce657620  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin-unsigned.tar.gz
  9b001f66b969e80c3d22d0eadceaa53d16440e2c1550d181e4e63747de8779f5  guix-build-f862f4a74ec6/output/x86_64-apple-darwin/bitcoin-f862f4a74ec6-x86_64-apple-darwin.tar.gz
  6181e4941f836084d33eec2131b88fa793da168f79a887a7688ded690a3172db  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/SHA256SUMS.part
  c561ac1f2466fc4a685a23a89b325cf76e200b2016daa2692950af7901995149  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/bitcoin-f862f4a74ec6-x86_64-linux-gnu-debug.tar.gz
  c89c49ff45ab9a71c2b3f0e656fdca18be815f2474beb1c4dd663d466e077e8a  guix-build-f862f4a74ec6/output/x86_64-linux-gnu/bitcoin-f862f4a74ec6-x86_64-linux-gnu.tar.gz
  461d8a96c28854eb131544205978849a192ef7a1db14f85f1ae4791a90da96c5  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/SHA256SUMS.part
  9e77f1aa937c3d690160ad362eac92ffc20e5a8d2272243ba10099239521aa70  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-debug.zip
  90a04f298826699c808519846cb1cec50047ff2959471a684b26c20a2e504c47  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-setup-unsigned.exe
  f487dd6a8d1eb7566df85c1b2fe536352e4e0c3e50c911766f1daccdbdf5706d  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64-unsigned.tar.gz
  5f120f1af427ee1c7bd3129a67297b6bc34693e963e90004aee2558c9c5622d5  guix-build-f862f4a74ec6/output/x86_64-w64-mingw32/bitcoin-f862f4a74ec6-win64.zip
  ```

ACKs for top commit:
  laanwj:
    Code review ACK f862f4a74e

Tree-SHA512: df52d0165eb1ca1db1c50bfc06e0f647ef976bd133daf2fd310f25455ee6b69b26a1e5cb48f2d8873aac78660465bfedcd2acdec67e67bf76bb44257d28912a3
 2022-06-21 15:42:31 +01:00
Sebastian Falbesoner
fb38c6e21f refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize() 
These methods haven't been used since the chainstate db cache has been
switched from per-tx to per-txout model years ago (PR #10195, commit
d342424301).
 2022-06-21 16:19:10 +02:00
Hennadii Stepanov
d8d99d041a
qt6: Do not use deprecated high DPI attributes in Qt 6 
In Qt 6, high DPI pixmaps and scaling are always enabled.

https://doc.qt.io/qt-6/highdpi.html
 2022-06-21 13:50:48 +02:00
Hennadii Stepanov
8927bb8f06
refactor: Fix style in initTranslations() function 2022-06-21 13:40:45 +02:00
Hennadii Stepanov
ad73447dc2
qt6: Do not use deprecated QLibraryInfo::path in Qt 6 
See https://doc.qt.io/qt-6/qtcore-changes-qt6.html#other-classes
 2022-06-21 13:39:26 +02:00
Hennadii Stepanov
3f51d0b8b2
qt6: Fix type registration 
In Qt 6, registration of `QDataStream` streaming operators is done
automatically. Consequently, `qRegisterMetaTypeStreamOperators()` does
no longer exist. Calls to this method have to be removed when porting
to Qt 6.

See https://doc.qt.io/qt-6/qtcore-changes-qt6.html#the-qmetatype-class
 2022-06-21 13:14:21 +02:00
laanwj
5884a47c36
Merge bitcoin/bitcoin#25422: build: globally define NOMINMAX when building with mingw-w64 
58a9601dff build: globally define NOMINMAX (fanquake)

Pull request description:

  Define (and document) `NOMINMAX` once, rather than across multiple
  source files.

  Defining this prevents the definition of min/max macros when using
  mingw-w64, which may conflict with unprefixed std::min/max usage. While
  that might not be the case for us, we'd always prefer to use the standard
  library in any case.

  For example:
  73cadc06c6/mingw-w64-headers/include/ntdef.h (L289-L300)

  Note that we already define NOMINMAX globally when building with MSVC.

  Guix Build (arm64):
  ```bash
  d3a3b7045dc1677f6a0a2a73a484f156c81ae764058003d9e870b346912b744a  guix-build-58a9601dffa6/output/arm-linux-gnueabihf/SHA256SUMS.part
  3e66540a3f8c8a10864ab2fed69581241fa41af86bbb028e5f7c3dd4ba859c64  guix-build-58a9601dffa6/output/arm-linux-gnueabihf/bitcoin-58a9601dffa6-arm-linux-gnueabihf-debug.tar.gz
  78756e20d45e327cfd7f9e65858bf6d3814bcbe08f9f825fd6dfc9dff999ea6d  guix-build-58a9601dffa6/output/arm-linux-gnueabihf/bitcoin-58a9601dffa6-arm-linux-gnueabihf.tar.gz
  11073e88d4fd0411c5119a3dca3a90788693fa9aa5134339c84be98ae893cd77  guix-build-58a9601dffa6/output/arm64-apple-darwin/SHA256SUMS.part
  deffd5f8c6286be34bc35e71ec70300bacb37e1b1a83e67c0833cb57d7a45529  guix-build-58a9601dffa6/output/arm64-apple-darwin/bitcoin-58a9601dffa6-arm64-apple-darwin-unsigned.dmg
  acee7e98c5ec41f67e86c78dc5b45fa8bc82de86a04b8c43dbf9c59e7aff36a9  guix-build-58a9601dffa6/output/arm64-apple-darwin/bitcoin-58a9601dffa6-arm64-apple-darwin-unsigned.tar.gz
  83f7cbaf6680fe8981db9260b97ca87d609a76c0857a744c7d406645d2484e1b  guix-build-58a9601dffa6/output/arm64-apple-darwin/bitcoin-58a9601dffa6-arm64-apple-darwin.tar.gz
  b8c73b40a5e307e9e7e482ce92164990d442f3f105a5240ec6eb96a775cb35d5  guix-build-58a9601dffa6/output/dist-archive/bitcoin-58a9601dffa6.tar.gz
  cc435cd925771af7e261d0121047339ea8fddb0d1548b699c12108a62988cd32  guix-build-58a9601dffa6/output/powerpc64-linux-gnu/SHA256SUMS.part
  7a68bd3181a054056b0a5eb6e830b90ac4ba8435114127d5f1720643011aa78f  guix-build-58a9601dffa6/output/powerpc64-linux-gnu/bitcoin-58a9601dffa6-powerpc64-linux-gnu-debug.tar.gz
  bc55b95e263c455a964d9463a3ee60dabee1d10cefc6641ed29a3b1b317d61e0  guix-build-58a9601dffa6/output/powerpc64-linux-gnu/bitcoin-58a9601dffa6-powerpc64-linux-gnu.tar.gz
  49df78009d80af02262806c6c395e2c884a979b1ea13d01aa27d8188403e29d1  guix-build-58a9601dffa6/output/powerpc64le-linux-gnu/SHA256SUMS.part
  29dc7a0e10707b3511fa2afb6977df7ebbb67f796d8be5a042abc14eba764aef  guix-build-58a9601dffa6/output/powerpc64le-linux-gnu/bitcoin-58a9601dffa6-powerpc64le-linux-gnu-debug.tar.gz
  51b7f8e1bccff1e2ce1860bbc382eefe648b90cc3374cdfa3a95a7454386e77d  guix-build-58a9601dffa6/output/powerpc64le-linux-gnu/bitcoin-58a9601dffa6-powerpc64le-linux-gnu.tar.gz
  e62e46d8cebbbfc0f587e930acb648fcae99cfe8b2f63aeba98e46e3338fe1e3  guix-build-58a9601dffa6/output/riscv64-linux-gnu/SHA256SUMS.part
  fa5d0a074ca586583bf08dbf748909b3ff5e0a54a2e5aaa88abec666e17b4e72  guix-build-58a9601dffa6/output/riscv64-linux-gnu/bitcoin-58a9601dffa6-riscv64-linux-gnu-debug.tar.gz
  684b2917fd27a41f884bb6870f7fac847d52b6f8b40df5779d1c674409f7cd14  guix-build-58a9601dffa6/output/riscv64-linux-gnu/bitcoin-58a9601dffa6-riscv64-linux-gnu.tar.gz
  7d7cfd0212b49eec48c7f8dc0d97add53096685dfd646feac466c27a45d20c97  guix-build-58a9601dffa6/output/x86_64-apple-darwin/SHA256SUMS.part
  d70ae6d060b7832f8741dc5d1958cc0d32702605c863254303107246deec0aa6  guix-build-58a9601dffa6/output/x86_64-apple-darwin/bitcoin-58a9601dffa6-x86_64-apple-darwin-unsigned.dmg
  930f3ec43896404208ebdb582c9175e3a5a2470d778722e0001addde84dad99a  guix-build-58a9601dffa6/output/x86_64-apple-darwin/bitcoin-58a9601dffa6-x86_64-apple-darwin-unsigned.tar.gz
  2d8a9d12aadcf60634db953fcb8bd496a002608e9a64eb7d60bb7ffe1f94489f  guix-build-58a9601dffa6/output/x86_64-apple-darwin/bitcoin-58a9601dffa6-x86_64-apple-darwin.tar.gz
  10363729ece6e1c2cbdf435483006191bf17d1def2d318ff8357197d91c06ded  guix-build-58a9601dffa6/output/x86_64-linux-gnu/SHA256SUMS.part
  d50ec8e4f72e8b064b196eb0ece212f7b0b126f4b8b644c4451084cbf0416072  guix-build-58a9601dffa6/output/x86_64-linux-gnu/bitcoin-58a9601dffa6-x86_64-linux-gnu-debug.tar.gz
  471e12b8715ecff4d99121c4bb3288ef4b005ca468810a714c67ea3e7c6669e9  guix-build-58a9601dffa6/output/x86_64-linux-gnu/bitcoin-58a9601dffa6-x86_64-linux-gnu.tar.gz
  d63946401952d131fdf5df9442c52151d86e53f019234b5ad16fdef0d2976356  guix-build-58a9601dffa6/output/x86_64-w64-mingw32/SHA256SUMS.part
  5359782e1eb6f449338f18e053ad82f25382d968690208ae5739d9338eb7bdc7  guix-build-58a9601dffa6/output/x86_64-w64-mingw32/bitcoin-58a9601dffa6-win64-debug.zip
  0d387d5a4cb1d712556a3fe5b4bd1e928bb5fbbe57a85ee06c746f132a6b1ec5  guix-build-58a9601dffa6/output/x86_64-w64-mingw32/bitcoin-58a9601dffa6-win64-setup-unsigned.exe
  dbfd7419d1d764e853a9dc041e276669b488aea4a80e21e4a175b6c3e512e70c  guix-build-58a9601dffa6/output/x86_64-w64-mingw32/bitcoin-58a9601dffa6-win64-unsigned.tar.gz
  0ba07504d9d5a12af9144e8b386b2640b48dba067d47c694a44ecffe56b0c0fc  guix-build-58a9601dffa6/output/x86_64-w64-mingw32/bitcoin-58a9601dffa6-win64.zip
  ```

ACKs for top commit:
  laanwj:
    Code review ACK 58a9601dff

Tree-SHA512: d1c22b3d0d21ef8f9f605ef6ca06353e3f48536d84f3531f93d613a6ccbbe62f12fae0ed09e8b9a8940b0ef33f9d41d9991eb56fbe7c4ab48f0ce7fcf44e08b1
 2022-06-21 12:42:05 +02:00
Hennadii Stepanov
18d9189cc9
Merge bitcoin-core/gui#612: refactor: Drop unused QFrames in SendCoinsEntry 
7ab72b9d2a qt: Fix `BitcoinAmountField`'s base widget (Hennadii Stepanov)
3262542104 qt, refactor: Fix `sendcoinsentry.ui` indentation (Hennadii Stepanov)
f3c7603329 qt, refactor: Convert `SendCoinsEntry` to a sub-`QWidget` (Hennadii Stepanov)
6420fb2005 qt, refactor: Drop unused `QFrame`s in `SendCoinsEntry` (Hennadii Stepanov)

Pull request description:

  The `SendCoins_UnauthenticatedPaymentRequest` and `SendCoins_AuthenticatedPaymentRequest` sub-`QFrame`'s of the `SendCoinsEntry` widget have been unused since bitcoin/bitcoin#17165.

  Removed all dead code. The resulted `SendCoinsEntry` widget has been simplified.

ACKs for top commit:
  w0xlt:
    Tested ACK 7ab72b9d2a
  shaavan:
    reACK 7ab72b9d2a

Tree-SHA512: a46db90d60fae584b52cc7edae910c295351cb3627e04d225708c50c04f7fdd81d2755e055115612a12a3c841e78c31bdcd57bed9feb1d3909f7a2f6e76bd356
 2022-06-21 12:17:30 +02:00
MacroFake
fa8421bc5b
test: Remove from_node from create_self_transfer* MiniWallet helpers 
The from_node argument is no longer used as of commit
a55606c3bd
 2022-06-21 12:02:01 +02:00
MacroFake
b178807265
Merge bitcoin/bitcoin#25430: test: refactor: save MiniWallet mode explicitly 
be8d0dba15 test: refactor: save MiniWallet mode explicitly (Sebastian Falbesoner)

Pull request description:

  Rather than abusing the member variables `self._priv_key` and `self._address` to determine the MiniWallet mode, save it explicitly (`self._mode`) in the constructor and use that instead to increase the readability and maintainability of the code.

ACKs for top commit:
  MarcoFalke:
    review ACK be8d0dba15 🔳

Tree-SHA512: 882c635e39c89911d995917a0603395158ee86dc46b26a49815756db67c61a7aa35059eddf1dc6f2933a77169941426b98bd463e60e39515a596b1b69edf89df
 2022-06-21 11:42:58 +02:00
Sebastian Falbesoner
be8d0dba15 test: refactor: save MiniWallet mode explicitly 
Rather than abusing the member variables self._priv_key and
self._address to determine the MiniWallet mode, save it explicitly
instead in the constructor to increase the readability and
maintainability of the code.
 2022-06-21 10:54:42 +02:00
laanwj
1d39c9ca06
Merge bitcoin/bitcoin#25425: build: Fix ::_wsystem check 
b5f6a46503 build: Fix `::_wsystem` check (Hennadii Stepanov)

Pull request description:

  The `::_wsystem` check has been introduced in bitcoin/bitcoin#15457, and it is broken.

  An excerpt from `config.log` for `./autogen.sh && ./configure CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site` on master (a09033e22c):
  ```
  configure:29111: checking for ::_wsystem
  configure:29125: x86_64-w64-mingw32-g++-posix -std=c++17 -o conftest.exe -pipe -std=c++17 -O2  -I/home/hebasto/git/bitcoin/depends/x86_64-w64-mingw32/include/  -L/home/hebasto/git/bitcoin/depends/x86_64-w64-mingw32/lib  conftest.cpp -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32  >&5
  conftest.cpp: In function 'int main()':
  conftest.cpp:81:15: error: '::_wsystem' has not been declared
     81 |  int nErr = ::_wsystem("");
        |               ^~~~~~~~
  configure:29125: $? = 1
  configure: failed program was:
  | /* confdefs.h */
  | #define PACKAGE_NAME "Bitcoin Core"
  | #define PACKAGE_TARNAME "bitcoin"
  | #define PACKAGE_VERSION "23.99.0"
  | #define PACKAGE_STRING "Bitcoin Core 23.99.0"
  | #define PACKAGE_BUGREPORT "https://github.com/bitcoin/bitcoin/issues"
  | #define PACKAGE_URL "https://bitcoincore.org/"
  | #define HAVE_CXX17 1
  | #define HAVE_STDIO_H 1
  | #define HAVE_STDLIB_H 1
  | #define HAVE_STRING_H 1
  | #define HAVE_INTTYPES_H 1
  | #define HAVE_STDINT_H 1
  | #define HAVE_STRINGS_H 1
  | #define HAVE_SYS_STAT_H 1
  | #define HAVE_SYS_TYPES_H 1
  | #define HAVE_UNISTD_H 1
  | #define STDC_HEADERS 1
  | #define LT_OBJDIR ".libs/"
  | #define USE_ASM 1
  | #define HAVE_CLMUL 1
  | #define ENABLE_SSE41 1
  | #define ENABLE_AVX2 1
  | #define ENABLE_X86_SHANI 1
  | #define HAVE_LIBKERNEL32 1
  | #define HAVE_LIBUSER32 1
  | #define HAVE_LIBGDI32 1
  | #define HAVE_LIBCOMDLG32 1
  | #define HAVE_LIBWINMM 1
  | #define HAVE_LIBSHELL32 1
  | #define HAVE_LIBCOMCTL32 1
  | #define HAVE_LIBOLE32 1
  | #define HAVE_LIBOLEAUT32 1
  | #define HAVE_LIBUUID 1
  | #define HAVE_LIBADVAPI32 1
  | #define HAVE_LIBWS2_32 1
  | #define HAVE_LIBSHLWAPI 1
  | #define HAVE_LIBIPHLPAPI 1
  | #define HAVE_PTHREAD_PRIO_INHERIT 1
  | #define HAVE_PTHREAD 1
  | #define _FILE_OFFSET_BITS 64
  | #define HAVE_DECL_STRERROR_R 0
  | #define HAVE_LIBSSP 1
  | #define HAVE_STDIO_H 1
  | #define HAVE_STDLIB_H 1
  | #define HAVE_UNISTD_H 1
  | #define HAVE_STRINGS_H 1
  | #define HAVE_SYS_TYPES_H 1
  | #define HAVE_SYS_STAT_H 1
  | #define HAVE_DECL_GETIFADDRS 0
  | #define HAVE_DECL_FREEIFADDRS 0
  | #define HAVE_DECL_FORK 0
  | #define HAVE_DECL_SETSID 0
  | #define HAVE_DECL_PIPE2 0
  | #define HAVE_DECL_LE16TOH 0
  | #define HAVE_DECL_LE32TOH 0
  | #define HAVE_DECL_LE64TOH 0
  | #define HAVE_DECL_HTOLE16 0
  | #define HAVE_DECL_HTOLE32 0
  | #define HAVE_DECL_HTOLE64 0
  | #define HAVE_DECL_BE16TOH 0
  | #define HAVE_DECL_BE32TOH 0
  | #define HAVE_DECL_BE64TOH 0
  | #define HAVE_DECL_HTOBE16 0
  | #define HAVE_DECL_HTOBE32 0
  | #define HAVE_DECL_HTOBE64 0
  | #define HAVE_DECL_BSWAP_16 0
  | #define HAVE_DECL_BSWAP_32 0
  | #define HAVE_DECL_BSWAP_64 0
  | #define HAVE_BUILTIN_CLZL 1
  | #define HAVE_BUILTIN_CLZLL 1
  | #define HAVE_DEFAULT_VISIBILITY_ATTRIBUTE 1
  | #define HAVE_DLLEXPORT_ATTRIBUTE 1
  | #define HAVE_FDATASYNC 0
  | #define HAVE_O_CLOEXEC 0
  | /* end confdefs.h.  */
  |
  | int
  | main (void)
  | {
  |  int nErr = ::_wsystem("");
  |
  |   ;
  |   return 0;
  | }
  configure:29130: result: no
  ```

  See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/system-wsystem

ACKs for top commit:
  laanwj:
    Code review ACK b5f6a46503

Tree-SHA512: 30cadb7e2e2e3885955ba72c2c27c5dfef2f1b0a9e02e7e811d9bd7cb2c380bab77ca9df3a476d83105de3fa01d043f995e3680b7bff5e7c33829d281b67f374
 2022-06-21 06:54:52 +02:00
Hennadii Stepanov
09a76e43fd
Merge bitcoin-core/gui#615: If -prune=0 is set, Uncheck Prune on Intro page 
40566e21c0 If -prune=0 is set, Uncheck Prune on Intro page (Jadi)

Pull request description:

  If the bitcoin-qt is started with -prune=0 arg, On the Intro page,
  the Prune Checkbox will be unchecked too, to prevent confusions.

  refs: https://github.com/bitcoin/bitcoin/issues/25052

ACKs for top commit:
  hebasto:
    re-ACK 40566e21c0

Tree-SHA512: d5e0b76a7d20ae806e61a416fd907650f15a744a5823d0f8b57a634cb099bb135199e69a787bd54ecde2cf84e95633f40ff407a722350f337b27de395a6e0f78
 2022-06-21 01:22:33 +02:00
laanwj
e16f644104
Merge bitcoin/bitcoin#25378: build: use sqlite 3380500 in depends 
9d6a7b2fb1 build: sqlite 3380500 in depends (fanquake)

Pull request description:

  Move to using [sqlite 3380500](https://www.sqlite.org/releaselog/3_38_5.html) in depends.

  Other than bug fixes and improvements compared to our current version (3320100), the newer version contains changes that deal with warnings produced with newer versions of GCC (11.2.0), which are also more likely to appear when building with LTO:
  ```bash
  ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c: In function 'sqlite3SelectNew':
  ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:129016: warning: function may return address of local variable [-Wreturn-local-addr]
  ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:128976: note: declared here
  In function 'memcpy',
      inlined from 'sqlite3Fts5IndexQuery' at ../depends/work/build/x86_64-pc-linux-gnu/sqlite/3320100-973d921a018/sqlite3.c:220862:18:
  /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
     29 |   return __builtin___memcpy_chk (__dest, __src, __len,
        |          ^
  ```

  Relevant upstream discussions:
  https://sqlite.org/forum/forumpost/845dd0be91a54ec8
  https://sqlite.org/forum/forumpost/f5eed70bd46ede56

  Guix Build (x86_64):
  ```bash
  5a2bb2a0c09ade10bc78af0eae910e842402598c28cd82dfe67fa7f0bdc7c7d0  guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/SHA256SUMS.part
  e7e82c3ab4654c33389ffda83647723179f548b6d0372204914a94df1479f29c  guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu-debug.tar.gz
  3574852251d08749193a05161a048ae7933aee8910da230a3c32fa874d4df027  guix-build-9d6a7b2fb1e0/output/aarch64-linux-gnu/bitcoin-9d6a7b2fb1e0-aarch64-linux-gnu.tar.gz
  a9d87e7197998051ff4d76253c5c8d86e859c3907d1f29023a62d40b5ca8f82f  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part
  a0813408afb86f505f1ffd6f9361881c08b35b1a7cd869da7e1dad9f042a63ae  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz
  e3d13d137c3bde9a25bf585ecdfe9001bc10b8c82b206d8fbf4977f3ab5da374  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz
  a84a8f5c152048e1a3287afe42f4909d2ea9a271b2474d7406a83482fb1de3c7  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part
  4241ed6de223e899995d4df3ba8566e472e08a125cd1ecd5e1fdab5bc88bb6fd  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg
  75e5096ccab23b546393a368d9beb9b2b0867bb0d0c84604ff2a131f4afb24fa  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz
  ec453221fbd951b0fddfad283a310a550aa15b55aefe6ba6a0f290cfff1d2cb2  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz
  e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c  guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz
  c926dcf8c351548c845e4c6c047a851cb99a72b028005c6c6b0e3e4f1d7384f7  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part
  a6dea61ce6397ba4d5b3c35fae2c7b729cee23e07b71b5de6737663dd144d234  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz
  77d6271322db5bb5ea25f20c5df5fc5a0150cfd1570a8e1a5d0c111702eca77c  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz
  57793bf2ea341012806d6dafb49659b40496eaeee3fe1da580e7c7aed07572ba  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part
  6a37d39313150ad90101b1e29ac7a7a32f3001cb9395326484b117c5538b27a3  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz
  985ceb6eeba7590bef83755b73f1efdef922d50c5ebee7e0c521b27388874482  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz
  21a30c6f53d4544376ebc5f9fa3326edb305bf1dd55079512b7eaf16c408fcfc  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part
  c80d159154a4785dcaf42f77175aad38dd9498e8e0128f2c6277b4a2668f8aae  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz
  d2ed0cde0f6e0245662e8f335091dbe0ed57dcb661ff1d5eac94f5af7cde4daf  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz
  d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part
  a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg
  efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz
  e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz
  80e5b6ffce2bf33bc024ee1decd0d024fe2f23211dbe73cf1ade89abcf5910d9  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part
  9903f76bfce98415c6d6d1cc2057683b4fad9d02f4da0c2afe37b108a4d8d496  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz
  9a05903423afef05222e13646c3b249c747b8cb9d487eceb1a120ca018b02dea  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz
  bbb8e284b9dced4db64c6fbb7ac53ddcc622b9c367300b280beaae2e288140b9  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part
  b7064f1abbf8653e5c045c84244db112cef48043610a30fc878ba644e01b41ae  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip
  be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe
  b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz
  603eb61bcf37ad0939cc588c79c544be545d443043bc194094d203eaab7981d2  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip
  ```

  Guix Build (arm64):
  ```bash
  e4bd8215fb9ff88c58b7d1b2d13f90110585e3a7de7be20a962b4b00b5817012  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/SHA256SUMS.part
  e03b9d5201b68087c267875a570e675a838753cc4062105bc3820b594dfbddc1  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf-debug.tar.gz
  7bb1d6c34910fcd8036adcf1c92ddff330242ad92ecd489864b7a44386e6afec  guix-build-9d6a7b2fb1e0/output/arm-linux-gnueabihf/bitcoin-9d6a7b2fb1e0-arm-linux-gnueabihf.tar.gz
  2e8dd34a1ff1ee041a7c2eb423ee84bdf00be28d71b2ffeb20752f10d10b856b  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/SHA256SUMS.part
  b448114fdb7be57070d7bc563cfc8a3ef7b6658689598e8c1091c359f62a2445  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.dmg
  ea9d06d6208d3279c11eb2845fc6c1cbee4293ca0169e1ac3a6cec737f022230  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin-unsigned.tar.gz
  0a267860eb0414ac2a213b9c6accd24cc73da3474d535c85ec7d542aa08fda30  guix-build-9d6a7b2fb1e0/output/arm64-apple-darwin/bitcoin-9d6a7b2fb1e0-arm64-apple-darwin.tar.gz
  e01c2894eec3827c98241f5cf9c779b07cb4dee8e9e043a6840c8fcf6a91a23c  guix-build-9d6a7b2fb1e0/output/dist-archive/bitcoin-9d6a7b2fb1e0.tar.gz
  8b3a0634a29579352a50b596ff79b58442d53951e6fe7ca291362d697d8bff26  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/SHA256SUMS.part
  2acc3541cf7d09eb0302605b8131aae4561918969bee2a397ef550412afecd86  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu-debug.tar.gz
  eec1781a5daf7e98213299c6aac37d111528f03bd5fa595371e4984491137e0b  guix-build-9d6a7b2fb1e0/output/powerpc64-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64-linux-gnu.tar.gz
  b8d4b83f8194d77bbc09e1cbda9406365655865959bcb200eca76d5db630a0e3  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/SHA256SUMS.part
  05502d75b749465cc2deedcafdb34a910a14c75d3c0b25964899ef102dec8da3  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu-debug.tar.gz
  7c66573cc96f62a75549a5333d2b5c27fde78691f3fe8d863bb676a0a1052a0b  guix-build-9d6a7b2fb1e0/output/powerpc64le-linux-gnu/bitcoin-9d6a7b2fb1e0-powerpc64le-linux-gnu.tar.gz
  fac4613cf7d47f2f22a45c0030c480802dae805f46f59a596a98f4fd709209fd  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/SHA256SUMS.part
  df3d1045cb10d815f5b3bba5246c3349654346a156982c767e2c3b076598185b  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu-debug.tar.gz
  64ec31b702d3c6c25615618be64de631c70f69383e150f27493139933591f024  guix-build-9d6a7b2fb1e0/output/riscv64-linux-gnu/bitcoin-9d6a7b2fb1e0-riscv64-linux-gnu.tar.gz
  d054f0bf16e69ad7b557faed4b5c349bdfba3ff554a2d3636ad913ac307dc2e9  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/SHA256SUMS.part
  a7279c357838b0aa1d3548b45be8568d759b141828e3b7d2ab2d2de9a95b7a8c  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.dmg
  efe4d4d9e4d7e966e19dcc819456169d02891087fa7e767c305afd297e981af2  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin-unsigned.tar.gz
  e1b72c3904a6cb3ba0c9eb156288ab216a94be5da2b10288d414d224ffa525b1  guix-build-9d6a7b2fb1e0/output/x86_64-apple-darwin/bitcoin-9d6a7b2fb1e0-x86_64-apple-darwin.tar.gz
  05fa5c84dce57bb1728a8ac36a967177f25d9f8892b272da0483e4b8f4ea2b94  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/SHA256SUMS.part
  40cb0712447dc4e1f0574fcd307012206ce64c32aa12a240666070a18cf6af51  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu-debug.tar.gz
  7f6b0696f28348584eb62d69ab936f864310dd42a7e4cba7abe087e563b3b77f  guix-build-9d6a7b2fb1e0/output/x86_64-linux-gnu/bitcoin-9d6a7b2fb1e0-x86_64-linux-gnu.tar.gz
  d79bab5b5d4414d23cf26eaddb3c5eabc88e0700e9fd62686e5b44735c62453b  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/SHA256SUMS.part
  55029375d671803013ba49c8f287101c49f62033569240efe9f089907dc47a58  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-debug.zip
  be1a9b270d834d59a731adebed1d4f2424fb6a1bb082808fadb5cf3b930a31a1  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-setup-unsigned.exe
  b893e54fb43b5c256d46e4a58d65a8d3fc111eb65417cb56810f793b1813ca86  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64-unsigned.tar.gz
  9626a24a47af1a1d5240a50c3d7fd74053657bc87a5dff32007b200f48e5573d  guix-build-9d6a7b2fb1e0/output/x86_64-w64-mingw32/bitcoin-9d6a7b2fb1e0-win64.zip
  ```

ACKs for top commit:
  hebasto:
    ACK 9d6a7b2fb1. Confirming that `-Wreturn-local-addr` and `-Wstringop-overflow=` warnings are gone. Verified the hash of the new source archive.

Tree-SHA512: 28783479623be0ccc8169ff63e169a61f850106e820f12917b867b07087d2817fe0d5432a5e1ddf564ed90ba371aaf801dd4e7b32acb3907736dc4dcdd129355
 2022-06-20 22:05:40 +02:00
laanwj
6c6cc7989c
Merge bitcoin/bitcoin#25424: build, qt: Fix QMAKE_CXXFLAGS expression for mingw32 host 
71d33bf33f build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` host (Hennadii Stepanov)

Pull request description:

  A "copy-paste typo" was introduced in bitcoin/bitcoin#21593.

  I'm sorry about that.

ACKs for top commit:
  laanwj:
    Code review ACK 71d33bf33f

Tree-SHA512: 9433d9e51d7772d4ac1579aab75d184bb486e575ec216933b1a5171b0b68718943c96bd3669fe239b1d1ed17ec82bc5d14e777d4ff8b6fae370352864da88534
 2022-06-20 21:46:52 +02:00
laanwj
bc28ca3afb
Merge bitcoin/bitcoin#25118: wallet: unify “allow/block other inputs“ concept 
d338712886 scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs (furszy)
8dea74a8ff refactor: use GetWalletTx in SelectCoins instead of access mapWallet (furszy)
b4e2d4d4ee wallet: move "use-only coinControl inputs" below the selected inputs lookup (furszy)
25749f1df7 wallet: unify “allow/block other inputs“ concept (furszy)

Pull request description:

  Seeking to make the `CoinControl` options less confusing/redundant.
  It should have no functional changes.

  The too long to read technical description; remove `m_add_inputs`, we can use the already existent `fAllowOtherInputs` flag.

  In #16377 the `CoinControl` flag ‘m_add_inputs’ was added to tell the coin filtering and selection process two things:
  - Coin Filtering: Only use the provided inputs. Skip the Rest.
  - Coin Selection: Search the wtxs-outputs and append all the `CoinControl` internal and external selected outpoints to the selection result (skipping all the available output checks). Nothing else.

  Meanwhile, in `CoinControl` we already have a flag ‘fAllowOtherInputs’ which is already saying:
  - Coin Filtering: Only use the provided inputs. Skip the Rest.
  - Coin Selection: If false, no selection process -> append all the `CoinControl` selected outpoints to the selection result (while they passed all the `AvailableCoins` checks and are available in the 'vCoins' vector).

  ### Changes

  As can notice, the first point in the coin filtering process is duplicated in the two option flags. And the second one, is slightly different merely because it takes into account whether the coin is on the `AvailableCoins` vector or not.
  So it makes sense to merge ‘m_add_inputs’ and ‘fAllowOtherInputs’ into a single field for the coin filtering process while introduce other changes to add the missing/skipped internal and external coins into 'vCoins' vector if they were manually selected by the user.

  ——————————————————————————————————

  Just as an extra note:
  On top of this, I’m working on unifying/untangling further the coin filtering and selection processes so we have less duplicate functionality in both processes.

ACKs for top commit:
  laanwj:
    Code review ACK d338712886

Tree-SHA512: 98920b80dd787cfe737dacd4c59575dfa8393c799b55f2aaef9aed2b15c61470715a88663557b49c7400938220f99af7690be01980a8684f4f71947407f21750
 2022-06-20 21:37:55 +02:00
laanwj
57a491bee1
Merge bitcoin/bitcoin#25388: refactor: move policy constants to policy 
0d8e68d705 refactor: move DEFAULT_*_LIMIT assertions from validation to policy (fanquake)
9c94f3b3a7 refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.h (fanquake)
39c6036253 refactor: use braced initialization in policy/policy.h (fanquake)
01ccfbe3aa scripted-diff: use static constexpr in policy/policy.h (fanquake)
62d56bb714 refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.h (fanquake)
a34aa4c187 refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h (fanquake)
05fc5fdc13 refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h (fanquake)
da8d304960 refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.h (CAnon)

Pull request description:

  Picks up #25295. Which was a follow up to [a comment in #25254](https://github.com/bitcoin/bitcoin/pull/25254#discussion_r890595318).
  Moves policy constants from validation.h to policy.h.

ACKs for top commit:
  laanwj:
    Code review ACK 0d8e68d705
  w0xlt:
    reACK 0d8e68d705
  darosior:
    ACK 0d8e68d705

Tree-SHA512: 79900b09dc3a8020b5053ec734f462cb6e8184ed2b76e9d8afae7fe5331bbc906daaa42c0f622782797d971aaf5698aa0155511ec1d15582cc7675c271664a8d
 2022-06-20 20:13:44 +02:00
furszy
32e5edc0f4
wallet: avoid extra wtx lookup in AddToSpends 
This method is only called from AddToWallet and LoadToWallet,
places where we already have the wtx.
 2022-06-20 14:21:57 -03:00
Vasil Dimov
e8ff3f0c52
net: remove CloseSocket() 
Do the closing in `Sock::Reset()` and remove the standalone
`CloseSocket()`.

This reduces the exposure of low-level sockets (i.e. integer file
descriptors) outside of the `Sock` class.
 2022-06-20 16:38:31 +02:00
Vasil Dimov
175fb2670a
net: remove now unused Sock::Release() 2022-06-20 15:01:28 +02:00
Hennadii Stepanov
b5f6a46503
build: Fix ::_wsystem check 
See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/system-wsystem
 2022-06-20 14:04:37 +02:00
Hennadii Stepanov
71d33bf33f
build, qt: Fix QMAKE_CXXFLAGS expression for mingw32 host 2022-06-20 13:39:40 +02:00
fanquake
58a9601dff
build: globally define NOMINMAX 
Define (and document) `NOMINMAX` once, rather than across multiple
source files.

Defining this prevents the definition of min/max macros when using
mingw-w64, which may conflict with unprefixed std::min/max usage. While
that might not be the case for us, we'd always prefer to use the standard
library in any case.

For example:
73cadc06c6/mingw-w64-headers/include/ntdef.h (L289-L300)
 2022-06-20 12:22:05 +01:00
MacroFake
a09033e22c
Merge bitcoin/bitcoin#25409: doc: fix typos 
20c58a3e50 doc: typo fix (Marnix)

Pull request description:

  `contrib/devtools/test-symbol-check.py`: envinonment -> environment
  `contrib/seeds/asmap.py`: succesful -> successful

ACKs for top commit:
  brunoerg:
    ACK 20c58a3e50

Tree-SHA512: acbe060b7c27673208715c4f6d0fac913c61c94a5e7e37b0ab9865d099067568dc683bd0099e5dc46e3602b13b5dae512ec713bd65f56fa10a59d946d5fd2649
 2022-06-20 11:36:52 +02:00
fanquake
0d8e68d705
refactor: move DEFAULT_*_LIMIT assertions from validation to policy 2022-06-20 10:24:15 +01:00
fanquake
9c94f3b3a7
refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.h 2022-06-20 10:02:59 +01:00
fanquake
39c6036253
refactor: use braced initialization in policy/policy.h 2022-06-20 10:02:59 +01:00
fanquake
01ccfbe3aa
scripted-diff: use static constexpr in policy/policy.h 
-BEGIN VERIFY SCRIPT-

sed -i -e "s/static const /static constexpr /" src/policy/policy.h

-END VERIFY SCRIPT-
 2022-06-20 10:02:59 +01:00
fanquake
62d56bb714
refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.h 2022-06-20 10:02:58 +01:00
fanquake
a34aa4c187
refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h 2022-06-20 10:02:58 +01:00
fanquake
05fc5fdc13
refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h 2022-06-20 10:02:58 +01:00