9 commits

Author	SHA1	Message	Date
Jon Atack	cdaab90662	Add test for addrman consistency check on restart with asmap ... PR #22697 introduced a reproducible issue in commit 181a1207 that causes the addrman tried table to fail consistency checks and significantly lose peer entries when the `-asmap` configuration option is used. The issue occurs on bitcoind restart due to an initialization order change in `src/init.cpp` in that commit whereby CAddrman asmap is set after deserializing `peers.dat`, rather than before. Issue reported on the `#bitcoin-core-dev` IRC channel starting at https://www.erisian.com.au/bitcoin-core-dev/log-2021-08-23.html#l-263. ``` addrman lost 22813 new and 2 tried addresses due to collisions or invalid addresses ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17 bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted ``` How to reproduce: - `git checkout 181a1207` and recompile - launch bitcoind with `-asmap` and `-checkaddrman=1` config options - restart bitcoind - bitcoind aborts on second call to `CAddrMan::Check()` This commit adds a regression test to reproduce the case; it passes or fails with the same error. Co-authored-by: John Newbery <john@johnnewbery.com> Co-authored-by: Martin Zumsande <mzumsande@gmail.com>	2021-09-15 16:38:03 +02:00
fanquake	6f3d5ad67a	test: use f-strings in feature_asmap.py	2021-08-18 09:52:25 +08:00
Fabian Jahr	590bda79e8	scripted-diff: Remove setup_clean_chain if default is not changed ... -BEGIN VERIFY SCRIPT- git grep -l "self.setup_clean_chain = False" test/functional/*.py | xargs sed -i "/self.setup_clean_chain = False/d"; -END VERIFY SCRIPT-	2021-02-01 23:13:38 +01:00
Jon Atack	1ba3e1cc21	init: move asmap code earlier in init process ... and update feature_asmap.py and test_runner.py This commit moves the asmap init.cpp code from the end of "Step 12: start node" to "Step 6: network initialization" to provide feedback on passing an -asmap config arg much more quickly. This change speeds up the feature_asmap.py functional test file from 60 to 5 seconds by accelerating the 2 tests that use `assert_start_raises_init_error`. Credit to Wladimir J. van der Laan for the suggestion.	2020-03-04 14:54:30 +01:00
Jon Atack	819fb5549b	logging: asmap logging and #include fixups ... - move asmap #includes to sorted positions in addrman and init (move-only) - remove redundant quotes in asmap InitError, update test - remove full stops from asmap logging to be consistent with debug logging, update tests	2020-03-04 14:24:19 +01:00
Jon Atack	dcaf543ba0	test: add functional test for an empty, unparsable asmap ... This is now testable after separating the asmap finding and parsing checks in the previous commit.	2020-03-04 14:24:17 +01:00
Jon Atack	b8d0412b21	config: separate the asmap finding and parsing checks ... and update the tests.	2020-03-04 14:24:15 +01:00
Jon Atack	81c38a2497	config: enable passing -asmap an absolute file path ... - allow passing an absolute file path to the -asmap config arg - update the -asmap config help - add a functional test in feature_asmap.py	2020-03-04 14:24:13 +01:00
Jon Atack	08b992675c	test: add feature_asmap functional tests ... to verify node behaviour and debug log when launching bitcoind in these cases: 1. `bitcoind` with no -asmap arg, using /16 prefix for IP bucketing 2. `bitcoind -asmap=<relative path>`, using the unit test skeleton asmap 3. `bitcoind -asmap/-asmap=` with no file specified, using the default asmap 4. `bitcoind -asmap` with no file specified, and a missing default asmap file The tests are order-independent. The slowest test (missing default asmap file) is placed last.	2020-03-04 14:24:08 +01:00