6 commits

Author	SHA1	Message	Date
fanquake	3ba2840e7e	scripted-diff: remove MakeUnique<T>() ... -BEGIN VERIFY SCRIPT- git rm src/util/memory.h sed -i -e 's/MakeUnique/std::make_unique/g' $(git grep -l MakeUnique src) sed -i -e '/#include <util\/memory.h>/d' $(git grep -l '#include <util/memory.h>' src) sed -i -e '/util\/memory.h \\/d' src/Makefile.am -END VERIFY SCRIPT-	2021-03-11 13:45:14 +08:00
Sjors Provoost	07b7c940a7	rpc: add external signer RPC files	2021-02-23 14:34:30 +01:00
MarcoFalke	ffc4d04990	Merge #20275: wallet: List all wallets in non-SQLite and non-BDB builds ... f3d870fc22 wallet: List all wallets in non-SQLite or non-BDB builds (Russell Yanofsky) d70dc89e78 refactor: Consolidate redundant wallet database path and exists functions (Russell Yanofsky) 6a7a63644c refactor: Drop call to GetWalletEnv in wallet salvage code (Russell Yanofsky) 6ee9cbdd18 refactor: Replace ListWalletDir() function with ListDatabases() (Russell Yanofsky) 5aaeb6cf87 MOVEONLY: Move IsBDBFile, IsSQLiteFile, and ListWalletDir (Russell Yanofsky) Pull request description: This PR does not change behavior when bitcoin is built normally with both the SQLite and BDB libraries. It just makes non-SQLite and non-BDB builds more similar to the normal build. Specifically: - It makes wallet directory lists always include all wallets so wallets don't appear missing depending on the build. - It now triggers specific "Build does not support SQLite database format" and "Build does not support Berkeley DB database format" errors if a wallet can't be loaded instead of the more ambiguous and scary "Data is not in recognized format" error. Both changes are implemented in the last commit. The previous commits are just refactoring cleanups that make the last commit possible and consolidate and reduce code. ACKs for top commit: achow101: ACK f3d870fc22 promag: Tested ACK f3d870fc22. Tested a --without-sqlite build with sqlite wallets. Tree-SHA512: 029ad21559dbc338b5f351d05113c51bc25bce830f4f4e18bcd82287bc528275347a60249da65b91d252632aeb70b25d057bd59c704bfcaafb9f790bc5b59762	2020-12-12 09:20:11 +01:00
practicalswift	12dcdaaa54	Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const	2020-12-06 00:22:40 +00:00
Russell Yanofsky	6ee9cbdd18	refactor: Replace ListWalletDir() function with ListDatabases() ... No change to behavior. This is just cleanup after previous MOVEONLY commit to make db.h list function fit conventions of surrounding functions.	2020-12-04 11:03:28 -04:00
Russell Yanofsky	629a9299b2	Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp	2020-11-24 10:20:16 -05:00

Renamed from src/interfaces/wallet.cpp (Browse further)