8 commits

Author	SHA1	Message	Date
Russell Yanofsky	288b4ffb6b	Remove WalletLocation class ... This removes a source of complexity and indirection that makes it harder to understand path checking code. Path checks will be simplified in upcoming commits. There is no change in behavior in this commit other than a slightly more descriptive error message in `loadwallet` if the default "" wallet can't be found. (The error message is improved more in upcoming commit "wallet: Remove path checking code from loadwallet RPC".)	2020-09-03 12:24:32 -04:00
Andrew Chow	0bbe26a1af	wallet: filter for keys only before record deser in salvage ... When salvaging a wallet, avoid deserializing any records that we don't care about, i.e. filter for keys only before the deserialization.	2020-08-25 13:23:40 -04:00
Andrew Chow	9f536d4fe9	wallettool: Have RecoverDatabaseFile return errors and warnings ... Instead of logging or printing these errors and warnings, return them to the caller.	2020-07-26 20:22:45 -04:00
Andrew Chow	d0ea9bab28	walletdb: Don't remove database transaction logs and instead error ... Instead of removing the database transaction logs and retrying the wallet loading, just return an error message to the user. Additionally, specifically for DB_RUNRECOVERY, notify the user that this could be due to different BDB versions. This error is pretty much only caused by compiling with a newer version of BDB and then trying to open the wallet with a version compiled with an older version of BDB.	2020-07-13 11:00:54 -04:00
Andrew Chow	8f1bcf8b7b	walletdb: Combine VerifyDatabaseFile and VerifyEnvironment ... Combine these two functions into a single Verify function that is a member of WalletDatabase. Additionally, these are no longer static.	2020-07-01 12:32:03 -04:00
Andrew Chow	d6045d0ac6	scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase ... -BEGIN VERIFY SCRIPT- sed -i -e 's/WalletDatabase::Create(/CreateWalletDatabase(/g' `git grep -l "WalletDatabase::Create("` sed -i -e 's/WalletDatabase::CreateDummy(/CreateDummyWalletDatabase(/g' `git grep -l "WalletDatabase::CreateDummy("` sed -i -e 's/WalletDatabase::CreateMock(/CreateMockWalletDatabase(/g' `git grep -l "WalletDatabase::CreateMock("` -END VERIFY SCRIPT-	2020-06-17 14:12:41 -04:00
Andrew Chow	ea337f2d03	Move RecoverKeysOnlyFilter into RecoverDataBaseFile	2020-05-25 12:59:29 -04:00
Andrew Chow	9ea2d258b4	Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}	2020-05-25 12:59:29 -04:00