bitcoin

25441 commits 6 branches 321 tags 2.2 GiB

Author SHA1 Message Date

Author	SHA1	Message	Date
Russell Yanofsky	7918c1b019	test: Add CreateWalletFromFile test Add unit test calling CreateWalletFromFile, which isn't currently called from other unit tests, with some basic checks to make sure it rescans and registers for notifications correctly. Motivation for this change was to try to write a test that would fail without the early `handleNotifications` call in ef8c6ca60767cac589d98ca57ee33179608ccda8 from https://github.com/bitcoin/bitcoin/pull/16426, but succeed with it: `ef8c6ca607/src/wallet/wallet.cpp (L3978-L3986)` However, writing a full test for the race condition that call prevents isn't possible without the locking changes from #16426. So this PR just adds as much test coverage as is possible now. This new test is also useful for https://github.com/bitcoin/bitcoin/pull/15719, since it detects the stale notifications.transactionAddedToMempool notifications that PR eliminates.	2020-04-26 20:23:05 -04:00
MarcoFalke	faec28252c	scripted-diff: test: Move setup_common to test library -BEGIN VERIFY SCRIPT- # Move files for f in $(git ls-files src/test/lib/); do git mv $f src/test/util/; done git mv src/test/setup_common.cpp src/test/util/ git mv src/test/setup_common.h src/test/util/ # Replace Windows paths sed -i -e 's\|\\setup_common\|\\util\\setup_common\|g' $(git grep -l '\\setup_common') sed -i -e 's\|src\\test\\lib\\\|src\\test\\util\\\|g' build_msvc/test_bitcoin/test_bitcoin.vcxproj # Everything else sed -i -e 's\|/setup_common\|/util/setup_common\|g' $(git grep -l 'setup_common') sed -i -e 's\|test/lib/\|test/util/\|g' $(git grep -l 'test/lib/') # Fix include guard sed -i -e 's\|BITCOIN_TEST_SETUP_COMMON_H\|BITCOIN_TEST_UTIL_SETUP_COMMON_H\|g' ./src/test/util/setup_common.h sed -i -e 's\|BITCOIN_TEST_LIB_\|BITCOIN_TEST_UTIL_\|g' $(git grep -l 'BITCOIN_TEST_LIB_') -END VERIFY SCRIPT-	2019-11-06 11:56:41 -05:00

Russell Yanofsky

7918c1b019

test: Add CreateWalletFromFile test

Add unit test calling CreateWalletFromFile, which isn't currently called from
other unit tests, with some basic checks to make sure it rescans and registers
for notifications correctly.

Motivation for this change was to try to write a test that would fail without
the early `handleNotifications` call in ef8c6ca60767cac589d98ca57ee33179608ccda8
from https://github.com/bitcoin/bitcoin/pull/16426, but succeed with it:

ef8c6ca607/src/wallet/wallet.cpp (L3978-L3986)

However, writing a full test for the race condition that call prevents isn't
possible without the locking changes from #16426. So this PR just adds as much
test coverage as is possible now.

This new test is also useful for https://github.com/bitcoin/bitcoin/pull/15719,
since it detects the stale notifications.transactionAddedToMempool notifications
that PR eliminates.

2020-04-26 20:23:05 -04:00

MarcoFalke

faec28252c

scripted-diff: test: Move setup_common to test library

-BEGIN VERIFY SCRIPT-
 # Move files
 for f in $(git ls-files src/test/lib/); do git mv $f src/test/util/; done
 git mv src/test/setup_common.cpp                     src/test/util/
 git mv src/test/setup_common.h                       src/test/util/
 # Replace Windows paths
 sed -i -e 's|\\setup_common|\\util\\setup_common|g' $(git grep -l '\\setup_common')
 sed -i -e 's|src\\test\\lib\\|src\\test\\util\\|g'  build_msvc/test_bitcoin/test_bitcoin.vcxproj
 # Everything else
 sed -i -e 's|/setup_common|/util/setup_common|g'    $(git grep -l 'setup_common')
 sed -i -e 's|test/lib/|test/util/|g'                $(git grep -l 'test/lib/')
 # Fix include guard
 sed -i -e 's|BITCOIN_TEST_SETUP_COMMON_H|BITCOIN_TEST_UTIL_SETUP_COMMON_H|g' ./src/test/util/setup_common.h
 sed -i -e 's|BITCOIN_TEST_LIB_|BITCOIN_TEST_UTIL_|g'                     $(git grep -l 'BITCOIN_TEST_LIB_')
-END VERIFY SCRIPT-

2019-11-06 11:56:41 -05:00

Renamed from src/test/lib/logging.cpp (Browse further)

2 commits