Wladimir J. van der Laan
53c300fb52
Merge #9910 : Docs: correct and elaborate -rpcbind doc
...
e5b449c
2017-03-03 17:22:44 +01:00
Wladimir J. van der Laan
90cb2a218e
Merge #9774 : Enable host lookups for -proxy and -onion parameters
...
f36bdf0
2017-03-03 16:22:22 +01:00
Wladimir J. van der Laan
67c5cc1917
Merge #9828 : Avoid -Wshadow warnings in wallet_tests
...
09fe346
2017-03-03 16:08:50 +01:00
Wladimir J. van der Laan
75d012e8c7
Merge #8808 : Do not shadow variables (gcc set)
...
ad1ae7a9de90bb
2017-03-03 15:48:53 +01:00
Wladimir J. van der Laan
ba80a684cf
Merge #9903 : Docs: add details to -rpcclienttimeout doc
...
90a1d9a
2017-03-03 14:57:02 +01:00
Wladimir J. van der Laan
eb281842b7
Merge #8775 : RPC refactoring: Access wallet using new GetWalletForJSONRPCRequest
...
d6787719756be386be48aa435632ad15734bf8a04a2e518e3d77ad6deca550f
2017-03-03 13:38:42 +01:00
Ian Kelling
e5b449c3e8
Docs: correct and elaborate -rpcbind doc
...
The default was incorrect unless -rpcallowip was also specified.
2017-03-03 04:14:10 -08:00
Wladimir J. van der Laan
58861ad91b
Merge #9904 : test: Fail if InitBlockIndex fails
...
6485466
2017-03-03 07:16:32 +01:00
MarcoFalke
f7ec7cfd38
Merge #9359 : Add test for CWalletTx::GetImmatureCredit() returning stale values.
...
7ed143c
2017-03-02 22:30:15 +01:00
Wladimir J. van der Laan
64854666f5
test: Report InitBlockIndex result
...
If InitBlockIndex fails, then it will segfault later. Same for the later
ActivateBestChain. BOOST_REQUIRE the result, so that an error will be
reported and the test case aborted.
2017-03-02 14:54:47 +01:00
Ian Kelling
90a1d9a55d
Docs: add details to -rpcclienttimeout doc
2017-03-02 04:42:37 -08:00
Wladimir J. van der Laan
65d90f585a
Merge #9143 : Refactor ZapWalletTxes to avoid layer violations
...
0165a56
2017-03-02 11:32:34 +01:00
Wladimir J. van der Laan
0496e15aef
Merge #9894 : remove 'label' filter for rpc command help
...
6665977
2017-03-02 10:07:31 +01:00
Jonas Schnelli
b00ba6251f
Merge #9834 : qt: clean up initialize/shutdown signals
...
5b528d7
2017-03-02 09:37:40 +01:00
Gregory Sanders
666597798c
remove 'label' filter for rpc command help
2017-03-01 09:15:39 -08:00
Wladimir J. van der Laan
d19d45a1e6
Merge #9821 : util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD
...
7e6dcd97cad849aa09ccb224e6eb
2017-03-01 12:41:53 +01:00
Wladimir J. van der Laan
cbdb4732f1
Merge #9868 : Abstract out the command line options for block assembly
...
277b47248faf0b
2017-03-01 12:38:04 +01:00
Wladimir J. van der Laan
22f609f25a
Merge #9861 : Trivial: Debug log ambiguity fix for peer addrs
...
6d37ee8
2017-03-01 11:16:59 +01:00
Russell Yanofsky
7ed143c10e
Add test for CWalletTx::GetImmatureCredit() returning stale values.
...
Add test for cached immature credit flag not being cleared in
CWalletTx::MarkDirty() bug, which was fixed in
https://github.com/bitcoin/bitcoin/pull/8717 , commit a560378
2017-03-01 05:11:46 -05:00
keystrike
6d37ee8314
Trivial: Debug log ambiguity fix for peer addrs
...
This line can be misinterpreted as loading wallet addresses which is confusing, especially when the wallet is disabled.
2017-02-28 22:14:24 -03:00
Wladimir J. van der Laan
7e2a2212ec
Merge #9829 : Fix importmulti returning rescan errors for wrong keys
...
306bd72
2017-02-28 13:52:50 +01:00
Wladimir J. van der Laan
b7547fa93e
Merge #9822 : Remove block file location upgrade code
...
4b183d3
2017-02-28 12:31:33 +01:00
Wladimir J. van der Laan
c322fa472e
Merge #9732 : [Trivial] Remove nonsense #undef foreach
...
467df39
2017-02-28 12:29:43 +01:00
Wladimir J. van der Laan
f5ef8e9dd2
Merge #9867 : Replace remaining sprintf with snprintf
...
19cafc60a17714
2017-02-28 12:02:44 +01:00
Wladimir J. van der Laan
30bdcfca2b
Merge #9865 : Change bitcoin address in RPC help message
...
83ac719
2017-02-28 11:59:34 +01:00
Wladimir J. van der Laan
65fdc37ac3
Merge #9856 : Terminate immediately when allocation fails
...
d4ee7bac5f008a
2017-02-28 11:37:36 +01:00
MarcoFalke
88c2ae3ed2
Merge #9350 : [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json
...
988ce2d
2017-02-27 22:33:55 +01:00
Luke Dashjr
d678771c66
Wallet: Sanitise -wallet parameter
2017-02-27 20:45:18 +00:00
Luke Dashjr
9756be382e
Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet RPCRunLater job name
...
The job name is logged, and could pose as an information leak to someone attacking the process, helping them counteract ASLR protections
2017-02-27 20:45:18 +00:00
Luke Dashjr
86be48a77c
More tightly couple EnsureWalletIsAvailable with GetWalletForJSONRPCRequest where appropriate
2017-02-27 20:45:18 +00:00
Luke Dashjr
a4356328e0
Move wallet RPC declarations to rpcwallet.h
2017-02-27 20:45:18 +00:00
Luke Dashjr
ad1573472e
RPC: Pass on JSONRPCRequest metadata (URI/user/etc) for "help" method
2017-02-27 20:45:18 +00:00
Luke Dashjr
bf8a04a165
Reformat touched lines with C++11
2017-02-27 20:45:18 +00:00
Luke Dashjr
2e518e313b
Move nWalletUnlockTime to CWallet::nRelockTime, and name timed task unique per CWallet
2017-02-27 20:45:17 +00:00
Luke Dashjr
d77ad6d416
RPC: Do all wallet access through new GetWalletForJSONRPCRequest
2017-02-27 20:45:17 +00:00
Luke Dashjr
eca550f250
RPC/Wallet: Pass CWallet as pointer to helper functions
2017-02-27 20:45:17 +00:00
Cory Fields
d4ee7baef7
prevector: assert successful allocation
2017-02-27 14:52:15 -05:00
Russell Yanofsky
306bd72157
Fix importmulti returning rescan errors for wrong keys
...
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
2017-02-27 07:38:51 -05:00
Wladimir J. van der Laan
75a109338f
tests: Fix dangling pwalletMain pointer in wallet tests
2017-02-27 13:15:39 +01:00
Wladimir J. van der Laan
19cafc6239
test: Replace remaining sprintf with snprintf
...
Use of `sprintf` is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
[cloudlibc from cloudabi](https://github.com/NuxiNL/cloudlibc ) don't
even provide it anymore.
Although our uses of these functions are secure, it can't hurt to
replace them anyway. There are only 3 occurences left, all in the
tests.
2017-02-27 10:03:20 +01:00
Wladimir J. van der Laan
0a177148e7
uint256: replace sprintf with HexStr and reverse-iterator
...
Instead of calling sprintf for every byte, format the hex bytes
ourselves by help of HexStr and a reverse_iterator.
2017-02-27 10:02:45 +01:00
Pieter Wuille
277b472fb2
Run miner_tests with fixed options
2017-02-26 16:13:51 -08:00
Pieter Wuille
48faf0bf63
Abstract out BlockAssembler options
2017-02-26 16:13:17 -08:00
Marijn Stollenga
83ac719d34
Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did).
2017-02-26 14:01:05 +01:00
Wladimir J. van der Laan
6206252e50
Merge #9847 : Extra test vector for BIP32
...
30aedcb
2017-02-25 10:43:29 +01:00
Cory Fields
c5f008a416
don't throw std::bad_alloc when out of memory. Instead, terminate immediately
2017-02-25 01:09:11 -05:00
Wladimir J. van der Laan
f19afdbfb4
Merge #9612 : [trivial] Rephrase the definition of difficulty.
...
dc222f8
2017-02-24 12:48:56 +01:00
Wladimir J. van der Laan
dd6e0d6301
Merge #9833 : Trivial: fix comments referencing AppInit2
...
ef9f495
2017-02-24 10:53:32 +01:00
Wladimir J. van der Laan
00285cece8
Merge #9840 : Update sendfrom RPC help to correct coin selection misconception
...
f81f0d0
2017-02-24 10:22:04 +01:00
Karl-Johan Alm
dc222f8f63
Trivial: Rephrase the definition of difficulty in the code.
2017-02-23 22:06:37 -08:00
