9 commits

Author	SHA1	Message	Date
fanquake	795afe6e63	Merge #19910: net processing: Move peer_map to PeerManager ... 3025ca9e77 [net processing] Add RemovePeer() (John Newbery) a20ab22786 [net processing] Make GetPeerRef const (John Newbery) ed7e469cee [net_processing] Move peer_map to PeerManager (John Newbery) a529fd3e3f [net processing] Move GetNodeStateStats into PeerManager (John Newbery) Pull request description: This moves `g_peer_map` from a global in net_processing.cpp's unnamed namespace to being a member `m_peer_map` of `PeerManager`. ACKs for top commit: theuni: Re-ACK 3025ca9e77. dongcarl: Re-ACK 3025ca9 hebasto: re-ACK 3025ca9e77, since my [previous](https://github.com/bitcoin/bitcoin/pull/19910#pullrequestreview-545574237) review only reverted the change that introduced NRVO in `PeerManager::GetPeerRef`, and comments are fixed in the proper commits. Tree-SHA512: 6369eb3c688ac5b84f89f7674115f78ff02edbed76063ac2ebb1759894c9e973883e10821a35dab92bd3d738280acc095bd5368f552a060b83cd309330387d47	2020-12-09 21:56:17 +08:00
Russell Yanofsky	6965f1352d	refactor: Replace uses ChainActive() in interfaces/chain.cpp ... Suggested https://github.com/bitcoin/bitcoin/pull/19425#discussion_r456236407	2020-12-07 09:09:53 -04:00
Russell Yanofsky	3fbbb9a640	refactor: Get rid of more redundant chain methods ... This just drops three interfaces::Chain methods replacing them with other calls. Motivation for removing these chain methods: - Need to get rid of findFirstBlockWithTimeAndHeight for #10102, which doesn't support overloaded methods - Followup from https://github.com/bitcoin/bitcoin/pull/16426#discussion_r412487403 - phantomcircuit comments about findNextBlock test http://www.erisian.com.au/bitcoin-core-dev/log-2020-06-06.html#l-214 Behavior is not changing in any way here. A TODO comment in ScanForWalletTransactions was removed, but just because it was invalid (see https://github.com/bitcoin/bitcoin/pull/19195#discussion_r448020762), not because it was implemented.	2020-12-07 09:09:53 -04:00
John Newbery	a529fd3e3f	[net processing] Move GetNodeStateStats into PeerManager	2020-12-04 11:37:45 +00:00
Antoine Poinsot	86ff2cf202	Remove the remaining fee estimation globals ... This moves the CBlockPolicyEstimator to the NodeContext, which get rids of two globals and allows us to conditionally create the CBlockPolicyEstimator (and to remove a circular dep). Signed-off-by: Antoine Poinsot <darosior@protonmail.com>	2020-12-03 12:56:37 +01:00
Antoine Poinsot	03bfeee957	interface: remove unused estimateSmartFee method from node ... Co-Authored-by: MarcoFalke <falke.marco@gmail.com> Signed-off-by: Antoine Poinsot <darosior@protonmail.com>	2020-12-03 12:56:36 +01:00
Fabian Jahr	1e62350ca2	refactor: Improve use of explicit keyword	2020-12-01 18:36:39 +01:00
Russell Yanofsky	2a26771d81	Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp ... No changes to ChainImpl or any related classes (review with `git diff --color-moved=dimmed_zebra`)	2020-11-24 10:13:23 -05:00
Russell Yanofsky	12bd0fc9d7	Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp	2020-11-24 10:13:23 -05:00

Renamed from src/interfaces/node.cpp (Browse further)