Jeff Garzik
3ce7e669e3
bitcoin-cli, rpcrawtransaction: harmonize "{" styling
2014-07-29 11:13:27 -04:00
Cory Fields
2a5840096f
core_read's ParseScript(): minor cleanups
...
- use .empty() rather than .size() == 0
- use a const_iterator rather than BOOST_FOREACH
- validate iterators before creating a string from them
2014-07-29 11:13:27 -04:00
Jeff Garzik
b2aeaa7939
Move ParseScript() helper, becoming accessible outside src/test/
2014-07-29 11:13:27 -04:00
Jeff Garzik
ae775b5b31
Consolidate CTransaction hex encode/decode into core_io.h, core_{read,write}.cpp
2014-07-29 11:13:27 -04:00
Jeff Garzik
2e7009d67b
Avoid querying DNS seeds, if we have open connections.
...
The goal is to increase independence and privacy.
2014-07-29 11:04:46 -04:00
Pieter Wuille
2887bffcfd
Update coding style and add .clang-format
2014-07-28 22:08:13 +02:00
Wladimir J. van der Laan
f9de17ec2f
Add warning comment to getinfo
...
Warn that people should not add new information, or change current
information returned by getinfo.
2014-07-28 19:30:58 +02:00
Alex Morcos
961ae93c85
Fix minor bug which only affected log messages.
2014-07-28 10:52:54 -04:00
Wladimir J. van der Laan
826d07101c
Merge pull request #4597
...
d817187
[Qt] remove ProxySocksVersion from OptionID (Philip Kaufmann)
2014-07-28 14:55:58 +02:00
Wladimir J. van der Laan
0449a17e41
Merge pull request #4541
...
125fba1
Add a new checkpoint at block 295,000 (Trevin Hofmann)
2014-07-28 14:54:08 +02:00
Philip Kaufmann
d817187bdb
[Qt] remove ProxySocksVersion from OptionID
...
- we only support SOCKS5, so remove it
2014-07-28 14:47:27 +02:00
Wladimir J. van der Laan
aaa7076937
Merge pull request #4531
...
ebdcc36
Add helptexts for -whitelist and rpc prioritisetransaction and switch to bitcoin instead of satoshis (Cozz Lovan)
2014-07-28 14:37:40 +02:00
Wladimir J. van der Laan
c5eabde9ea
Merge pull request #4491
...
eaedb59
net: add SetSocketNonBlocking() as OS independent wrapper (Philip Kaufmann)
2014-07-28 14:05:54 +02:00
Alex Morcos
17f15678d3
Fixed a bug with index bounds checking
2014-07-27 21:41:13 -04:00
Pieter Wuille
d70bc52ee3
Rework block processing benchmark code
...
* Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
* Increase coverage and granularity of individual block processing steps.
* Add cummulative times.
2014-07-27 00:41:03 +02:00
Philip Kaufmann
f65352a7d0
[Qt] small Qt-only include cleanup
2014-07-25 17:43:41 +02:00
Wladimir J. van der Laan
3955c3940e
Merge pull request #4584
...
0430c30
Add missing FindNode prototype to net.h (Wladimir J. van der Laan)
2014-07-25 11:06:11 +02:00
Wladimir J. van der Laan
32235a3bb9
Merge pull request #4567
...
f469f79
remove an unneded .c_str() in OpenNetworkConnection() (Philip Kaufmann)
2014-07-25 11:04:48 +02:00
Wladimir J. van der Laan
93659379bd
Add comment about never updating nTimeOffset past 199 samples
...
Refer to issue #4521 for details.
2014-07-24 19:00:24 +02:00
Wladimir J. van der Laan
0430c30af1
Add missing FindNode prototype to net.h
...
Also make the argument a const std::string & instead of pass-by-value.
2014-07-24 17:28:47 +02:00
Wladimir J. van der Laan
70d0325999
Merge pull request #4496
...
5734d4d
Only remove actualy failed blocks from setBlockIndexValid (Pieter Wuille)
2014-07-24 16:55:48 +02:00
Wladimir J. van der Laan
7eb3d6152f
Merge pull request #4575
...
ad08d0b
Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache (Pieter Wuille)
2014-07-24 16:46:38 +02:00
paveljanik
ab651b2d62
Fix typos in comments (missing i's).
2014-07-24 16:08:59 +02:00
Wladimir J. van der Laan
29eaa31694
ui: Make sure sendcoinsentry signals only connected once
...
Move signal connections to constructor where possible.
2014-07-23 17:58:47 +02:00
Wladimir J. van der Laan
2a05101efd
qt: Remove unused functions from BitcoinUnits
...
Remove two functions that are now unused.
2014-07-23 17:58:46 +02:00
Wladimir J. van der Laan
91cce1732b
qt: Use fixed-point arithmetic in amount spinbox
...
Fixes various issues and cleans up code
- Fixes issue #4500 : Amount widget +/- has floating point rounding artifacts
- Amount box can now be emptied again, without clearing to 0
Also aligns the amount to the right, as in other places.
2014-07-23 17:58:46 +02:00
Pieter Wuille
ad08d0b95b
Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache
2014-07-23 15:40:52 +02:00
Wladimir J. van der Laan
afa71fb3e3
Harmonize importprivkey and importaddress documentation
2014-07-22 08:58:49 +02:00
Tom Harding
9c347313f7
CBloomFilter::clear() method
2014-07-21 11:50:07 -07:00
Philip Kaufmann
f469f79ff8
remove an unneded .c_str() in OpenNetworkConnection()
2014-07-21 15:00:42 +02:00
Wladimir J. van der Laan
8f3f94a470
Revert "CBloomFilter::clear() method"
...
This reverts commit 8fbf03995d
.
2014-07-21 07:46:34 +02:00
Wladimir J. van der Laan
98e84aae7a
Revert "Relay double-spends, subject to anti-DOS"
...
This reverts commit d640a3ceab
.
2014-07-21 07:46:34 +02:00
Wladimir J. van der Laan
3015e0bca6
Revert "UI to alert of respend attempt affecting wallet."
...
This reverts commit ada5a067c7
.
Conflicts:
src/qt/guiconstants.h
src/wallet.h
2014-07-21 07:46:33 +02:00
Wladimir J. van der Laan
39d3f2cb40
Revert "Add -respendnotify option and new RPC data"
...
This reverts commit 9004798e62
.
2014-07-21 07:46:33 +02:00
Wladimir J. van der Laan
ad26dc9c31
Revert "Formatting, spelling, comment fixes."
...
This reverts commit 7a19efe040
.
2014-07-21 07:46:33 +02:00
Wladimir J. van der Laan
cd057bfd41
Revert "Check signatures before respend relay"
...
This reverts commit 88dd3598d2
.
2014-07-21 07:46:33 +02:00
Wladimir J. van der Laan
67cc8f25c2
Revert "Remove signal DoubleSpendDetected, use function"
...
This reverts commit 0da6b3fd18
.
2014-07-21 07:46:33 +02:00
Wladimir J. van der Laan
0de61e7585
qt: Move SplashFinished to after ClientModel/WalletModel creation
...
With a large wallet there was a noticable gap between hiding of the
splash and showing the main window.
2014-07-20 13:50:42 +02:00
Cozz Lovan
027dcdc792
[Qt] Fix thin space in URI
2014-07-20 04:17:02 +02:00
Wladimir J. van der Laan
ff1fe669d4
Merge pull request #3939
...
3da434a
Introduce option to disable relay/mining of bare multisig scripts in TX outputs (Jeff Garzik)
2014-07-18 23:29:50 +02:00
Whit J
b9345f7d1c
qt: Make error message for failed export a little friendlier
...
Closes #4528 .
2014-07-18 23:21:50 +02:00
Otto Allmendinger
d2d9dc063f
script tests: add tests for CHECKMULTISIG limits
2014-07-18 17:55:06 +02:00
Jeff Garzik
3da434a2ef
Introduce option to disable relay/mining of bare multisig scripts in TX outputs
...
First and foremost, this defaults to OFF.
This option lets a node consider such transactions non-standard,
meaning they will not be relayed or mined by default, but other miners
are free to mine these as usual.
2014-07-18 10:16:47 -04:00
Otto Allmendinger
89101c6e78
script test: test case for 5-byte bools
2014-07-18 15:41:45 +02:00
Wladimir J. van der Laan
40d2d69223
Merge pull request #4167
...
7149499
Add comments re BitcoinUnits::formatWithUnit/formatHtmlWithUnit (Roy Badami)
f7d70c6
Remove unused fAlign argument from BitcoinUnits::format and friends (Roy Badami)
2e4fee2
Show bitcoin quantities with full precision, even in the presence of trailing zeros (Roy Badami)
7007402
Implement SI-style (thin space) thoudands separator (Roy Badami)
2014-07-18 13:59:26 +02:00
Wladimir J. van der Laan
5bb765507b
Fix a signed/unsigned warning introduced in 1b4568c
...
vout counter must be unsigned.
2014-07-18 13:24:38 +02:00
Wladimir J. van der Laan
eaa9400781
Merge pull request #4255
...
1b4568c
Add vout to ListTransactions output (Cozz Lovan)
2014-07-18 12:57:06 +02:00
Otto Allmendinger
4cac5dbf83
script tests: value with trailing 0x00 is true
2014-07-18 12:55:46 +02:00
Wladimir J. van der Laan
773c1f297b
Merge pull request #4554
...
2d89ea9
build: fix whitespace in pkg-config variable (Cory Fields)
ab123ad
build: allow linux and osx to build against static qt5 (Cory Fields)
2014-07-18 11:39:18 +02:00
Otto Allmendinger
833ff161bc
script tests: values that overflow to 0 are true
2014-07-18 11:02:28 +02:00