23378 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
fanquake	2755b2b109	Merge #18010: test: rename test suite name "tx_validationcache_tests" to match filename ... b3c4d9bac6 test: rename test suite name "tx_validationcache_tests" to match filename (Sebastian Falbesoner) Pull request description: Quoting `src/test/README.md`, '`Adding test cases`': > "The file naming convention is `<source_filename>_tests.cpp` > and such files should wrap their tests in a test suite > called `<source_filename>_tests`." Currently the unit test source file `txvalidationcache_tests.cpp` contains a unit test suite with the name `tx_validationcache_tests`, which is fixed by this PR. The following shell script shows that this is the only mismatch and for all other unit test source files the test suite names are correct: ``` #!/bin/bash shopt -s globstar for test_full_filename in **/*_tests.cpp; do test_name_file=`basename $test_full_filename .cpp` test_name_suite=`sed -n "s/^.*TEST_SUITE(\(.*_tests\).*$/\1/p" $test_full_filename` if [ $test_name_file != $test_name_suite ]; then echo "TestFilename: $test_name_file != TestSuitname: $test_name_suite" fi done ``` ACKs for top commit: practicalswift: ACK b3c4d9bac6 -- expected naming is better than unexpected naming :) kristapsk: ACK b3c4d9bac6 Tree-SHA512: 29d409b1eb22057ee2cc407508e2580d2bc03f412401df11b8ecf77be5ada6bda8f7d2cb5338c5e079490fa12242c1fd6230a09e47252c1b0d9fe535a828ca4c	2020-01-28 18:25:54 +08:00
fanquake	3774281327	Merge #17933: guix: Pin Guix using guix time-machine ... 88c83636d5 guix: Update documentation for time-machine (Carl Dong) e6050884fd guix: Pin Guix using `guix time-machine` (Carl Dong) Pull request description: An alternative to #16519, pinning our version of Guix and eliminating a `guix pull` and changing the default Guix profile of builders. I think this method might be superior, as it: - Eliminates the possibility of future changes to the `guix environment` command line interface breaking our builds - Eliminates the need to set up a separate channel repo It is a more general pinning solution than #16519. ----- The reason why I didn't originally propose this is because `guix time-machine` is a recent addition to Guix, only available since `f675f8dec73d02e319e607559ed2316c299ae8c7` ACKs for top commit: fanquake: ACK 88c83636d5 Tree-SHA512: 85e03b0987ffa86da73e02801e1cd8b7622698d70c4ba4e60561611be1e9717d661c2811a59b3e137b1b8eef2d0ba37c313867d035ebc89c3bd06a23a078064a	2020-01-28 17:14:50 +08:00
Sebastian Falbesoner	b3c4d9bac6	test: rename test suite name "tx_validationcache_tests" to match filename ... Quoting src/test/README.md, 'Adding test cases': "The file naming convention is `<source_filename>_tests.cpp` and such files should wrap their tests in a test suite called `<source_filename>_tests`." Currently the unit test source file txvalidationcache_tests.cpp contains a unit test suite with the name tx_validationcache_tests, which is fixed by this commit. The following shell script shows that this is the only mismatch and for all other unit test source files the test suite names are correct: #!/bin/bash shopt -s globstar for test_full_filename in **/*_tests.cpp; do test_name_file=`basename $test_full_filename .cpp` test_name_suite=`sed -n "s/^.*TEST_SUITE(\(.*_tests\).*$/\1/p" $test_full_filename` if [ $test_name_file != $test_name_suite ]; then echo "TestFilename: $test_name_file != TestSuitname: $test_name_suite" fi done	2020-01-27 22:44:02 +01:00
Carl Dong	88c83636d5	guix: Update documentation for time-machine ... Wait a minute, doc. Are you telling me you built a time machine... Out of a functional package manager?	2020-01-27 16:41:20 -05:00
Carl Dong	e6050884fd	guix: Pin Guix using guix time-machine	2020-01-27 16:38:07 -05:00
practicalswift	cc668d06fb	tests: Add fuzzing harness for strprintf(...)	2020-01-27 21:31:42 +00:00
practicalswift	ccc3c76e2b	tests: Add fuzzer strprintf to FUZZERS_MISSING_CORPORA (temporarily)	2020-01-27 21:31:42 +00:00
practicalswift	6ef04912af	tests: Update FuzzedDataProvider.h from upstream (LLVM) ... Upstream revision: a44ef027eb/compiler-rt/include/fuzzer/FuzzedDataProvider.h	2020-01-27 21:31:42 +00:00
Jonas Schnelli	b89f2d0599	Merge #17453: gui: Fix intro dialog labels when the prune button is toggled ... 4f7127d1e3 gui: Make Intro consistent with prune checkbox (Hennadii Stepanov) 4824a7d36c gui: Add Intro::UpdateFreeSpaceLabel() (Hennadii Stepanov) daa3f3fa90 refactor: Add Intro::UpdatePruneLabels() (Hennadii Stepanov) e4caa82a03 refactor: Replace static variable with data member (Hennadii Stepanov) 2bede28cd9 util: Add PruneGBtoMiB() function (Hennadii Stepanov) e35e4b2ba0 util: Add PruneMiBtoGB() function (Hennadii Stepanov) Pull request description: On master (a6f6333ba2) and on 0.19.0.1 the intro dialog with prune enabled (checkbox "Discard blocks..." is checked) provides a user with wrong info about the required disk space:  Also the paragraph "If you have chosen to limit..." is missed. --- With this PR when prune checkbox is toggled, the related text labels and the amount of required space shown are updated (previously they were only updated when the data directory was updated):  --- This PR is an alternative to #17035. **ryanofsky**'s [suggestion](https://github.com/bitcoin/bitcoin/pull/17035#discussion_r337594268) also has been implemented. ACKs for top commit: emilengler: ACK 4f7127d1e3 Sjors: tACK 4f7127d1e3 ryanofsky: Code review ACK 4f7127d1e3. It seems like there are a few visible changes here: jonasschnelli: utACK 4f7127d1e3 Tree-SHA512: fa0bbdcfafde97d7906cda066cbd4608b936a71cae1b4cda3ee3aa2eed3a9795f279f14c6b1b4997278e094db891c7d3bb695368ba0882347aa42165a86e5172	2020-01-27 18:15:45 +01:00
Jonas Schnelli	ef8e2cee9f	Merge #18007: Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open ... 4c524f0aad Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open (Luke Dashjr) Pull request description: To reproduce bug, open 2 wallets, and close 1. You end up left without the HD/encrypt icons, despite having a wallet open still. This works because the icons are re-shown after we remove the current wallet (if there's another wallet still open). ACKs for top commit: promag: Tested ACK 4c524f0aad. jonasschnelli: utACK 4c524f0aad hebasto: ACK 4c524f0aad, tested on Linux Mint 19.3. Tree-SHA512: 4ef1bd4a0ae2f20ace9d02bc5d778640c11e46a86f30b762f8502e577f85114f0644d51a70cfbc4c23b51869c3caf20e94548aa64f51fdb85aea5f194a23fca6	2020-01-27 15:21:57 +01:00
Jonas Schnelli	3253b5dcf4	Merge #17096: gui: rename debug window ... 44f15cfdcf gui: renamed 'debug window' to 'node window' (Zero) Pull request description: **Edit**: I have now limited the change in this PR to only renaming the window title from `Debug Window` to `Node Window`. Check [this comment](https://github.com/bitcoin/bitcoin/pull/17096#issuecomment-542837511) for more details. This PR is in response to #17082, which aims to rename the `Debug window` title to a more user friendly term; `Node window`. Closes #17082 ACKs for top commit: hebasto: ACK 44f15cfdcf, tested on Linux Mint 19.3: theStack: ACK 44f15cfdcf, tested on Linux (Lubuntu 16.04): Tree-SHA512: 9fc73f2e67badb38525c550ce4c313288858b3fde30ef17fee85230be5bf31cf94408c699265b5e1256dfed60f8d04f48927d9b2831ba9f25498b98e6fa7180f	2020-01-27 11:31:09 +01:00
Jonas Schnelli	36ded99717	Merge #17998: gui: Shortcut to close ModalOverlay ... 1a638e1105 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1105. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1105 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0	2020-01-27 11:14:13 +01:00
Luke Dashjr	4c524f0aad	Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open	2020-01-26 22:55:10 +00:00
fanquake	acd644b83d	build: remove --large-address-aware linker flag ... This flag was used when building 32-bit Windows executables, which we no-longer do, and is not accepted by the linker for any of the hosts we currently build for. i.e: ```bash checking whether the linker accepts -Wl,--large-address-aware... no ``` --large-address-aware If given, the appropriate bit in the "Characteristics" field of the COFF header is set to indicate that this executable supports virtual addresses greater than 2 gigabytes. This should be used in conjunction with the /3GB or /USERVA=value megabytes switch in the "[operating systems]" section of the BOOT .INI. Otherwise, this bit has no effect. [This option is specific to PE targeted ports of the linker] You can check that the appropriate bit in the COFF header of our current Windows binaries is still be set using dumpbin. i.e: ```powershell dumpbin /headers .\bitcoind.exe FILE HEADER VALUES <snip> 26 characteristics Executable Line numbers stripped Application can handle large (>2GB) addresses ```	2020-01-26 10:43:10 +08:00
MarcoFalke	b4f832e24e	Merge #18001: Updated appveyor job to checkout a specific vcpkg commit ID ... 2bcc70531a Updated appveyor job to checkout a specific vcpkg commit ID. (Aaron Clauson) Pull request description: This PR sets the vcpkg packages in stone by checking out a specific commit ID whenever they need to be reinstalled. The commit ID was chosen as the most recent commit at the time of this PR. As per discussion on #17995 (and prior PR's/issues). ACKs for top commit: fanquake: ACK 2bcc70531a - thanks for trying/suggesting all the different approaches, however this looks like the way to go. Should prevent `vcpkg` packages from changing out from under us. Tree-SHA512: ced9c9c6df2287214a966d10110edda43a06380bae270a0d9ba1fd3dde48c27c109881423978e173b3e02512f6380600096b30510e90d37a6967fd8bf9186cb6	2020-01-25 20:42:30 -05:00
Aaron Clauson	2bcc70531a	Updated appveyor job to checkout a specific vcpkg commit ID.	2020-01-25 19:07:03 +00:00
MarcoFalke	c26b05c2b7	Merge #17770: test: bump test timeouts so that functional tests run in valgrind ... 2d23082cbe bump test timeouts so that functional tests run in valgrind (Micky Yun Chan) Pull request description: ci/tests: Bump timeouts so all functional tests run on travis in valgrind #17763 Top commit has no ACKs. Tree-SHA512: 5a8c6e2ea02b715facfcb58c761577be15ae58c45a61654beb98c2c2653361196c2eec521bcae4a9a1bab8e409d6807de771ef4c46d3d05996ae47a22d499d54	2020-01-25 11:20:47 -05:00
Micky Yun Chan	2d23082cbe	bump test timeouts so that functional tests run in valgrind	2020-01-25 15:51:35 +08:00
Emil Engler	1a638e1105	gui: Shortcut to close ModalOverlay	2020-01-24 20:27:49 +01:00
fanquake	28fbe68fdc	Merge #17740: build: remove configure checks for win libraries we don't link against ... 2525c096b0 build: remove configure checks for win libraries we don't link against (fanquake) Pull request description: While cross compiling, `HOST=x86_64-w64-mingw32`, none of these libs actually seem to be passed to the linker. i.e tailing a build with `make -j5 V=1 | rg -i 'mingwthrd|winspool|rpcrt4|crypt32'`. I'm not 100% sure about `crypt32`, even though the majority of our Windows cryptography usage, i.e [`CryptAcquireContextW`](https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptacquirecontextw) or [`CryptGenRandom`](https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom) is provided by `advapi32`. Note that `rpcrt4` and `mingwthrd` are already missing from the MSVC build, so we can sync the remainder once it's clear what's actually needed. Hopefully sipsorcery can add some MSVC insight. ACKs for top commit: practicalswift: ACK 2525c096b0 -- diff looks correct sipsorcery: ACK 2525c096b0. Tree-SHA512: c756618f85ce2ab1e14e5514dbdc490d94c1c6dfd7a3e3d3b16344ae302fb789585dd10b5c2d784f961f3115bec1d914615051b3184bea00dfbcc3c23884ab4a	2020-01-24 15:35:57 +08:00
Andrew Chow	3f373659d7	Refactor: Replace SigningProvider pointers with unique_ptrs ... Needed for future ScriptPubKeyMans which may need to create SigningProviders dynamically and thus a normal pointer is not enough This commit does not change behavior.	2020-01-23 16:35:08 -05:00
Andrew Chow	3afe53c403	Cleanup: Drop unused GUI learnRelatedScripts method ... This commit does not change behavior.	2020-01-23 16:35:08 -05:00
Andrew Chow	e2f02aa59e	Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan ... This commit does not change behavior.	2020-01-23 16:35:08 -05:00
Andrew Chow	c729afd0a3	Box the wallet: Add multiple keyman maps and loops ... Add wallet logic for dealing with multiple ScriptPubKeyMan instances. This doesn't change current behavior because there is still only a single LegacyScriptPubKeyMan. But in the future the new logic will be used to support descriptor wallets.	2020-01-23 16:35:08 -05:00
Andrew Chow	4977c30d59	refactor: define a UINT256_ONE global constant ... Instead of having a uint256 representations of one scattered throughout where it is used, define it globally in uint256.h	2020-01-23 16:35:08 -05:00
Andrew Chow	415afcccd3	HD Split: Avoid redundant upgrades ... This avoids repeaded upgrades when support for more multiple keyman references is added in the next commit: https://github.com/bitcoin/bitcoin/pull/16341#discussion_r322370108	2020-01-23 16:35:08 -05:00
Andrew Chow	01b4511206	Make UpgradeKeyMetadata work only on LegacyScriptPubKeyMan	2020-01-23 16:35:08 -05:00
Andrew Chow	4a7e43e846	Store p2sh scripts in AddAndGetDestinationForScript	2020-01-23 16:35:08 -05:00
Andrew Chow	501acb5538	Always try to sign for all pubkeys in multisig	2020-01-23 16:35:08 -05:00
Andrew Chow	81610eddbc	List output types in an array in order to be iterated over	2020-01-23 16:35:06 -05:00
Andrew Chow	eb81fc3ee5	Refactor: Allow LegacyScriptPubKeyMan to be null ... In CWallet::LoadWallet, use this to detect and empty wallet with no keys This commit does not change behavior.	2020-01-23 16:34:28 -05:00
Andrew Chow	fadc08ad94	Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman ... This commit only affects locking behavior and doesn't have other changes.	2020-01-23 16:34:28 -05:00
João Barbosa	f5be479694	wallet: Improve CWallet:MarkDestinationsDirty	2020-01-23 16:34:28 -05:00
Gleb Naumenko	3c1bc40205	Add extra logging of asmap use and bucketing	2020-01-23 14:23:06 -05:00
Gleb Naumenko	e4658aa8ea	Return mapped AS in RPC call getpeerinfo ... If ASN bucketing is used, return a corresponding AS used in bucketing for a given peer.	2020-01-23 14:22:56 -05:00
Wladimir J. van der Laan	fe3b58b959	Merge #17992: doc: Correct a small typo in help / manpage ... 2fa8dc5454 src/init: correct a typo (darosior) Pull request description: Just a little typo I noticed while reading the manpage. ACKs for top commit: emilengler: ACK 2fa8dc5 practicalswift: ACK 2fa8dc5454 -- also small defects should be fixed laanwj: ACK 2fa8dc5454 kristapsk: utACK 2fa8dc5454 Tree-SHA512: 3f25793313348f3584cd56894cc54a88bc3883c19e8e690b9624e1ab66eb2497ce270668684422c01ada2ec72f8349ec19106590739293e54fb458dbe9c561f3	2020-01-23 16:52:53 +01:00
MarcoFalke	fa5c6622c8	doc: Use proper RPC help syntax in importmulti	2020-01-23 10:23:30 -05:00
MarcoFalke	fab63111be	doc: Remove duplicate "comment" from listsinceblock RPC help ... Also, properly document all (json object) and (json array)	2020-01-23 10:21:00 -05:00
MarcoFalke	fa04cd6cfc	doc: Properly document proxy_randomize_credentials as bool in getnetworkinfo ... Also, fix indentation of some fields	2020-01-23 10:20:46 -05:00
MarcoFalke	fa9dec7c39	doc: Fix syntax error (trailing square bracket) in finalizepsbt	2020-01-23 10:20:26 -05:00
MarcoFalke	faff5a60ed	doc: Fix syntax error (trailing square bracket) in walletprocesspsbt	2020-01-23 10:19:51 -05:00
MarcoFalke	fa0545901d	doc: Add missing "optional" to "long" estimaterawfee RPC help ... Also, use multi-line for arrays and objects	2020-01-23 10:19:47 -05:00
darosior	2fa8dc5454	src/init: correct a typo	2020-01-23 15:45:21 +01:00
MarcoFalke	aaaae4d0eb	test: Add p2p test for forcerelay permission	2020-01-23 09:01:37 -05:00
MarcoFalke	fa6b57bcaa	test: Fix whitespace in p2p_permissions.py	2020-01-23 09:00:20 -05:00
MarcoFalke	faf40810d7	test: Make msg_tx a witness tx	2020-01-23 08:59:51 -05:00
fanquake	2525c096b0	build: remove configure checks for win libraries we don't link against ... While cross compiling, HOST=x86_64-w64-mingw32, none of these libs actually seem to be passed to the linker.	2020-01-23 07:59:54 +08:00
Wladimir J. van der Laan	7a311fa54a	Merge #17738: build: remove linking librt for backwards compatibility ... f7453dcc03 build: remove linking librt for backwards compatibility (fanquake) Pull request description: Now that we require glibc 2.17+, see #17538, we can remove linking librt for backwards compatibility purposes. The `clock_*` functions from librt were merged into glibc as part of the [2.17 release](https://sourceware.org/ml/libc-announce/2012/msg00001.html): * The `clock_*` suite of functions (declared in <time.h>) is now available directly in the main C library. Previously it was necessary to link with -lrt to use these functions. This change has the effect that a single-threaded program that uses a function such as `clock_gettime' (and is not linked with -lrt) will no longer implicitly load the pthreads library at runtime and so will not suffer the overheads associated with multi-thread support in other code such as the C++ runtime library. Note that `librt` is already unused by the RISC-V and AARCH64 binaries as their librts don't export any `clock_*` functions. As an example, you can find a diff of the arm32 vs arm64 librt symbols [here](https://gist.github.com/fanquake/b08cb1f0d14df3133395d7796ebf030c). Below is the library usage for the `v0.19.0.1` release (can delete these tables pre-merge). #### RISC-V ```bash riscv/bin/bitcoin-cli: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1'] riscv/bin/bitcoin-qt: ['libpthread.so.0', 'libfontconfig.so.1', 'libfreetype.so.6', 'libxcb.so.1', 'libdl.so.2', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1', 'libatomic.so.1'] riscv/bin/bitcoin-wallet: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1', 'libatomic.so.1'] riscv/bin/bitcoind: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1', 'libatomic.so.1'] riscv/bin/bitcoin-tx: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1'] riscv/bin/test_bitcoin: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-riscv64-lp64d.so.1', 'libatomic.so.1'] ``` #### AARCH64 ```bash aarch64/bin/bitcoin-cli: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] aarch64/bin/bitcoin-qt: ['libpthread.so.0', 'libfontconfig.so.1', 'libfreetype.so.6', 'libxcb.so.1', 'libdl.so.2', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] aarch64/bin/bitcoin-wallet: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] aarch64/bin/bitcoind: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] aarch64/bin/bitcoin-tx: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] aarch64/bin/test_bitcoin: ['libpthread.so.0', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-aarch64.so.1'] ``` #### ARM LINUX GNUEABIHF ```bash arm32/bin/bitcoin-cli: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] arm32/bin/bitcoin-qt: ['libpthread.so.0', 'librt.so.1', 'libfontconfig.so.1', 'libfreetype.so.6', 'libxcb.so.1', 'libdl.so.2', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] arm32/bin/bitcoin-wallet: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] arm32/bin/bitcoind: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] arm32/bin/bitcoin-tx: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] arm32/bin/test_bitcoin: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-armhf.so.3'] ``` #### LINUX X86_64 ```bash x86_64/bin/bitcoin-cli: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] x86_64/bin/bitcoin-qt: ['libpthread.so.0', 'librt.so.1', 'libfontconfig.so.1', 'libfreetype.so.6', 'libxcb.so.1', 'libdl.so.2', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] x86_64/bin/bitcoin-wallet: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] x86_64/bin/bitcoind: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] x86_64/bin/bitcoin-tx: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] x86_64/bin/test_bitcoin: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux-x86-64.so.2'] ``` #### LINUX i686 ```bash i686/bin/bitcoin-cli: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] i686/bin/bitcoin-qt: ['libpthread.so.0', 'librt.so.1', 'libfontconfig.so.1', 'libfreetype.so.6', 'libxcb.so.1', 'libdl.so.2', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] i686/bin/bitcoin-wallet: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] i686/bin/bitcoind: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] i686/bin/bitcoin-tx: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] i686/bin/test_bitcoin: ['libpthread.so.0', 'librt.so.1', 'libm.so.6', 'libgcc_s.so.1', 'libc.so.6', 'ld-linux.so.2'] ``` ACKs for top commit: laanwj: ACK f7453dcc03 Tree-SHA512: b418260edcda88583abfa386a592ebfb977d111e8e2ba887a30bf830b0b10dba429b9cfd615fad453ff0bb824225914ccb91433064b158ae1fbb9d20fc0b9937	2020-01-22 22:24:51 +01:00
Wladimir J. van der Laan	4a07233076	Merge #17767: ci: Fix qemu issues ... fa569e1a9c ci: Set LC_ALL=C when running in qemu-s390x (MarcoFalke) fa3d77623e ci: Use debian to avoid apt install 404 errors (MarcoFalke) fabb946090 ci: Install needed gcc and qemu-user iff cross-compiling (MarcoFalke) faba4672b6 ci: Fix QEMU_USER_CMD parse issues (MarcoFalke) fa5d709fb2 ci: Move wrap-qemu into separate script (MarcoFalke) Pull request description: Now that the ci system no longer propagates files from the docker container back to the host, the wrap-qemu script is broken. To fix it, every statement in the script needs to be executed in the docker (with `DOCKER_EXEC`). Instead of juggling with triple escape sequences like `\\\"`, just move the script to a separate file and call it with `DOCKER_EXEC`. Also, fix a bunch of other bugs that prevent running the ci system in qemu See the `ci/README.md` on how to test. TLDR: Can be tested with (replace `arm` with `s390x` to run the s390x build): ``` FILE_ENV="./ci/test/00_setup_env_arm.sh" MAKEJOBS="-j9" ./ci/test_run_all.sh ``` ACKs for top commit: laanwj: Code review ACK fa569e1a9c Tree-SHA512: 84ebc44a4f0261ee6c29605a6896a1833ff6c81d729e6d08dd111941f570ce73221422bd3303e1108a266ec5eab2148bd5ee1cf6bc01477d8cc9a6c5bf2b34c2	2020-01-22 21:09:13 +01:00
Jonas Schnelli	16d6113f4f	Refactor message transport packaging	2020-01-22 14:55:24 -05:00