From e75d2276324d54a01971afdf531df91748275bd5 Mon Sep 17 00:00:00 2001 From: John Moffett Date: Fri, 25 Nov 2022 15:56:40 -0500 Subject: [PATCH] Minor fix: Don't directly delete abandoned txes This fully closes bitcoin#12179. Currently, in the GUI, when a user abandons a transaction, a call is made to remove it from the list, and another signal fires (eventually) that adds it back to the GUI with a trash can icon. There are no conditions where the abandoned transaction should be directly removed from the GUI. If the underlying model changes, the deletion will be reflected anyway. --- src/qt/transactionview.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qt/transactionview.cpp b/src/qt/transactionview.cpp index b7432a0d775..b1c722388c1 100644 --- a/src/qt/transactionview.cpp +++ b/src/qt/transactionview.cpp @@ -421,9 +421,6 @@ void TransactionView::abandonTx() // Abandon the wallet transaction over the walletModel model->wallet().abandonTransaction(hash); - - // Update the table - model->getTransactionTableModel()->updateTransaction(hashQStr, CT_UPDATED, false); } void TransactionView::bumpFee([[maybe_unused]] bool checked)