phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

coins, refactor: Make AddFlags, SetDirty, SetFresh static

Browse source 
This makes the `Assume(&self.second == this)` check redundant

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
This commit is contained in:
Lőrinc 2024-10-31 13:18:13 +01:00
parent cd0498eabc
commit fc8c282022
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/coins.h
View file

@ -162,20 +162,19 @@ public:
//! Adding a flag also requires a self reference to the pair that contains //! Adding a flag also requires a self reference to the pair that contains
//! this entry in the CCoinsCache map and a reference to the sentinel of the //! this entry in the CCoinsCache map and a reference to the sentinel of the
//! flagged pair linked list. //! flagged pair linked list.
void AddFlags(uint8_t flags, CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept static void AddFlags(uint8_t flags, CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept
{ {
Assume(flags & (DIRTY | FRESH)); Assume(flags & (DIRTY | FRESH));
Assume(&pair.second == this); if (!pair.second.m_flags) {
if (!m_flags) { pair.second.m_prev = sentinel.second.m_prev;
m_prev = sentinel.second.m_prev; pair.second.m_next = &sentinel;
m_next = &sentinel;
sentinel.second.m_prev = &pair; sentinel.second.m_prev = &pair;
m_prev->second.m_next = &pair; pair.second.m_prev->second.m_next = &pair;
} }
m_flags |= flags; pair.second.m_flags |= flags;
} }
static void SetDirty(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { pair.second.AddFlags(DIRTY, pair, sentinel); } static void SetDirty(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { AddFlags(DIRTY, pair, sentinel); }
static void SetFresh(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { pair.second.AddFlags(FRESH, pair, sentinel); } static void SetFresh(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { AddFlags(FRESH, pair, sentinel); }
void SetClean() noexcept void SetClean() noexcept
{ {