phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-10 03:47:29 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tidy: add clang-tidy modernize-use-starts-ends-with check

Browse source
This commit is contained in:
Roman Zeyde 2024-09-06 23:07:46 +03:00
parent 2756797eca
commit fc7b507e9a
No known key found for this signature in database
GPG key ID: 87CAE5FA46917CBB
4 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/.clang-tidy
View file

@ -14,6 +14,7 @@ modernize-use-emplace,
modernize-use-equals-default, modernize-use-equals-default,
modernize-use-noexcept, modernize-use-noexcept,
modernize-use-nullptr, modernize-use-nullptr,
modernize-use-starts-ends-with,
performance-*, performance-*,
-performance-avoid-endl, -performance-avoid-endl,
-performance-enum-size, -performance-enum-size,

2
src/httpserver.cpp
View file

@ -315,7 +315,7 @@ static void http_request_cb(struct evhttp_request* req, void* arg)
if (i->exactMatch) if (i->exactMatch)
match = (strURI == i->prefix); match = (strURI == i->prefix);
else else
match = (strURI.substr(0, i->prefix.size()) == i->prefix); match = strURI.starts_with(i->prefix);
if (match) { if (match) {
path = strURI.substr(i->prefix.size()); path = strURI.substr(i->prefix.size());
break; break;

2
src/init.cpp
View file

@ -1356,7 +1356,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
if (!SplitHostPort(socket_addr, port_out, host_out)) { if (!SplitHostPort(socket_addr, port_out, host_out)) {
#ifdef HAVE_SOCKADDR_UN #ifdef HAVE_SOCKADDR_UN
// Allow unix domain sockets for some options e.g. unix:/some/file/path // Allow unix domain sockets for some options e.g. unix:/some/file/path
if (!unix || socket_addr.find(ADDR_PREFIX_UNIX) != 0) { if (!unix || !socket_addr.starts_with(ADDR_PREFIX_UNIX)) {
return InitError(InvalidPortErrMsg(arg, socket_addr)); return InitError(InvalidPortErrMsg(arg, socket_addr));
} }
#else #else

2
src/netbase.cpp
View file

@ -230,7 +230,7 @@ CService LookupNumeric(const std::string& name, uint16_t portDefault, DNSLookupF
bool IsUnixSocketPath(const std::string& name) bool IsUnixSocketPath(const std::string& name)
{ {
#ifdef HAVE_SOCKADDR_UN #ifdef HAVE_SOCKADDR_UN
if (name.find(ADDR_PREFIX_UNIX) != 0) return false; if (!name.starts_with(ADDR_PREFIX_UNIX)) return false;
// Split off "unix:" prefix // Split off "unix:" prefix
std::string str{name.substr(ADDR_PREFIX_UNIX.length())}; std::string str{name.substr(ADDR_PREFIX_UNIX.length())};