phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

rpc: Remove unused return type from appendCommand

Browse source
This commit is contained in:
MarcoFalke 2020-08-14 10:15:30 +02:00
parent 4d4bd5ed74
commit fa93bc14c7
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/rpc/server.cpp
View file

@ -261,13 +261,11 @@ CRPCTable::CRPCTable()
} }
} }
bool CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd) void CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd)
{ {
if (IsRPCRunning()) CHECK_NONFATAL(!IsRPCRunning()); // Only add commands before rpc is running
return false;
mapCommands[name].push_back(pcmd); mapCommands[name].push_back(pcmd);
return true;
} }
bool CRPCTable::removeCommand(const std::string& name, const CRPCCommand* pcmd) bool CRPCTable::removeCommand(const std::string& name, const CRPCCommand* pcmd)

4
src/rpc/server.h
View file

@ -160,7 +160,7 @@ public:
/** /**
* Appends a CRPCCommand to the dispatch table. * Appends a CRPCCommand to the dispatch table.
* *
* Returns false if RPC server is already running (dump concurrency protection). * Precondition: RPC server is not running
* *
* Commands with different method names but the same unique_id will * Commands with different method names but the same unique_id will
* be considered aliases, and only the first registered method name will * be considered aliases, and only the first registered method name will
@ -169,7 +169,7 @@ public:
* between calls based on method name, and aliased commands can also * between calls based on method name, and aliased commands can also
* register different names, types, and numbers of parameters. * register different names, types, and numbers of parameters.
*/ */
bool appendCommand(const std::string& name, const CRPCCommand* pcmd); void appendCommand(const std::string& name, const CRPCCommand* pcmd);
bool removeCommand(const std::string& name, const CRPCCommand* pcmd); bool removeCommand(const std::string& name, const CRPCCommand* pcmd);
}; };