mingw: Document mode wbx workaround

This commit is contained in:
MarcoFalke 2024-07-17 08:54:52 +02:00
parent fa359255fe
commit fa895c7283
No known key found for this signature in database
2 changed files with 8 additions and 3 deletions

View file

@ -1164,7 +1164,13 @@ static auto InitBlocksdirXorKey(const BlockManager::Options& opts)
xor_key_file >> xor_key; xor_key_file >> xor_key;
} else { } else {
// Create initial or missing xor key file // Create initial or missing xor key file
AutoFile xor_key_file{fsbridge::fopen(xor_key_path, "wbx")}; AutoFile xor_key_file{fsbridge::fopen(xor_key_path,
#ifdef __MINGW64__
"wb" // Temporary workaround for https://github.com/bitcoin/bitcoin/issues/30210
#else
"wbx"
#endif
)};
xor_key_file << xor_key; xor_key_file << xor_key;
} }
// If the user disabled the key, it must be zero. // If the user disabled the key, it must be zero.

View file

@ -30,8 +30,7 @@ BOOST_AUTO_TEST_CASE(xor_file)
} }
{ {
#ifdef __MINGW64__ #ifdef __MINGW64__
// Our usage of mingw-w64 and the msvcrt runtime does not support // Temporary workaround for https://github.com/bitcoin/bitcoin/issues/30210
// the x modifier for the _wfopen().
const char* mode = "wb"; const char* mode = "wb";
#else #else
const char* mode = "wbx"; const char* mode = "wbx";