From fa47b28dfc2a6577519e10da68ebd8da93568434 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Mon, 30 Jan 2023 13:12:51 +0100 Subject: [PATCH] refactor: Remove unused CDataStream SerializeMany constructor --- src/streams.h | 8 -------- src/test/serialize_tests.cpp | 3 ++- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/streams.h b/src/streams.h index c12ba8777a8..b20ef28a6d2 100644 --- a/src/streams.h +++ b/src/streams.h @@ -358,14 +358,6 @@ public: nType{nTypeIn}, nVersion{nVersionIn} {} - template - CDataStream(int nTypeIn, int nVersionIn, Args&&... args) - : nType{nTypeIn}, - nVersion{nVersionIn} - { - ::SerializeMany(*this, std::forward(args)...); - } - int GetType() const { return nType; } void SetVersion(int n) { nVersion = n; } int GetVersion() const { return nVersion; } diff --git a/src/test/serialize_tests.cpp b/src/test/serialize_tests.cpp index f583109e164..09f77d2b611 100644 --- a/src/test/serialize_tests.cpp +++ b/src/test/serialize_tests.cpp @@ -237,7 +237,8 @@ BOOST_AUTO_TEST_CASE(class_methods) BOOST_CHECK(methodtest2 == methodtest3); BOOST_CHECK(methodtest3 == methodtest4); - CDataStream ss2(SER_DISK, PROTOCOL_VERSION, intval, boolval, stringval, charstrval, txval); + CDataStream ss2{SER_DISK, PROTOCOL_VERSION}; + ss2 << intval << boolval << stringval << charstrval << txval; ss2 >> methodtest3; BOOST_CHECK(methodtest3 == methodtest4); }