Merge #21221: [tools] Allow argument/parameter bin packing in clang-format

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-12 04:42:36 -03:00

876ac3f6b6 [tools] Allow argument/parameter bin packing in clang-format (John Newbery)

Pull request description:

  clang-format documentation for BinPackArguments:

  If `false`, a function call’s arguments will either be all on the same line or will have one line each.

  ```
  true:
  void f() {
    f(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa,
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);
  }

  false:
  void f() {
    f(aaaaaaaaaaaaaaaaaaaa,
      aaaaaaaaaaaaaaaaaaaa,
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);
  }
  ```

  https://clang.llvm.org/docs/ClangFormatStyleOptions.html#configurable-format-style-options

  There's no reason to forbid this format. Having multiple arguments or parameters per line can be just as readable as having one per line (and is certainly more readable than having extremely long lines).

ACKs for top commit:
  laanwj:
    ACK 876ac3f6b6
  MarcoFalke:
    review ACK 876ac3f6b6
  vasild:
    ACK 876ac3f6b6

Tree-SHA512: 7c401b4551b458c83dd70883860788b4a60e08a5399171fef27a2f5fdc6b933f6454fe0d396c32d826e3ab537791329da3275ae9b5e9ad36630a6dc2c167e88f

This commit is contained in:

MarcoFalke

2021-02-19 11:28:36 +01:00

parent f093310b2e 876ac3f6b6

commit f1c2f619a6

No known key found for this signature in database

GPG key ID: D2EA4850E7528B25

1 changed files with 2 additions and 1 deletions

3

src/.clang-format

View file

 AllowShortLoopsOnASingleLine: false
 AlwaysBreakBeforeMultilineStrings: false
 AlwaysBreakTemplateDeclarations: true
-BinPackParameters: false
+BinPackArguments: true
+BinPackParameters: true
 BreakBeforeBinaryOperators: false
 BreakBeforeBraces: Custom
 BraceWrapping:

Merge #21221: [tools] Allow argument/parameter bin packing in clang-format

3 src/.clang-format Unescape Escape View file

3

src/.clang-format

View file