phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-25 02:33:24 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

rpc: reserve space for UniValue variables in blockToJSON

Browse source 
- Reserving space avoid reallocation, this provide noticeable
  performance increase in verbosity 1.
This commit is contained in:
ismaelsadeeq 2024-10-28 13:03:11 +01:00
parent 1749aef52a
commit ea62aaed3b
No known key found for this signature in database
GPG key ID: 0E3908F364989888
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/core_write.cpp
View file

@ -181,6 +181,7 @@ void TxToUniv(const CTransaction& tx, const uint256& block_hash, UniValue& entry
entry.pushKV("locktime", (int64_t)tx.nLockTime); entry.pushKV("locktime", (int64_t)tx.nLockTime);
UniValue vin{UniValue::VARR}; UniValue vin{UniValue::VARR};
vin.reserve(tx.vin.size());
// If available, use Undo data to calculate the fee. Note that txundo == nullptr // If available, use Undo data to calculate the fee. Note that txundo == nullptr
// for coinbase transactions and for transactions where undo data is unavailable. // for coinbase transactions and for transactions where undo data is unavailable.
@ -203,6 +204,7 @@ void TxToUniv(const CTransaction& tx, const uint256& block_hash, UniValue& entry
} }
if (!tx.vin[i].scriptWitness.IsNull()) { if (!tx.vin[i].scriptWitness.IsNull()) {
UniValue txinwitness(UniValue::VARR); UniValue txinwitness(UniValue::VARR);
txinwitness.reserve(tx.vin[i].scriptWitness.stack.size());
for (const auto& item : tx.vin[i].scriptWitness.stack) { for (const auto& item : tx.vin[i].scriptWitness.stack) {
txinwitness.push_back(HexStr(item)); txinwitness.push_back(HexStr(item));
} }
@ -232,6 +234,7 @@ void TxToUniv(const CTransaction& tx, const uint256& block_hash, UniValue& entry
entry.pushKV("vin", std::move(vin)); entry.pushKV("vin", std::move(vin));
UniValue vout(UniValue::VARR); UniValue vout(UniValue::VARR);
vout.reserve(tx.vout.size());
for (unsigned int i = 0; i < tx.vout.size(); i++) { for (unsigned int i = 0; i < tx.vout.size(); i++) {
const CTxOut& txout = tx.vout[i]; const CTxOut& txout = tx.vout[i];

1
src/rpc/blockchain.cpp
View file

@ -183,6 +183,7 @@ UniValue blockToJSON(BlockManager& blockman, const CBlock& block, const CBlockIn
result.pushKV("size", (int)::GetSerializeSize(TX_WITH_WITNESS(block))); result.pushKV("size", (int)::GetSerializeSize(TX_WITH_WITNESS(block)));
result.pushKV("weight", (int)::GetBlockWeight(block)); result.pushKV("weight", (int)::GetBlockWeight(block));
UniValue txs(UniValue::VARR); UniValue txs(UniValue::VARR);
txs.reserve(block.vtx.size());
switch (verbosity) { switch (verbosity) {
case TxVerbosity::SHOW_TXID: case TxVerbosity::SHOW_TXID: