test: cleanup rpc_getchaintips.py

Remove whitespace that doesn't conform with pep8 and turn some
comments into log messages.
This commit is contained in:
Martin Zumsande 2024-05-29 16:48:16 -04:00
parent f5149ddb9b
commit ccd98ea4c8

View file

@ -18,44 +18,45 @@ class GetChainTipsTest (BitcoinTestFramework):
self.num_nodes = 4 self.num_nodes = 4
def run_test(self): def run_test(self):
self.log.info("Test getchaintips behavior with two chains of different length")
tips = self.nodes[0].getchaintips() tips = self.nodes[0].getchaintips()
assert_equal(len(tips), 1) assert_equal(len(tips), 1)
assert_equal(tips[0]['branchlen'], 0) assert_equal(tips[0]['branchlen'], 0)
assert_equal(tips[0]['height'], 200) assert_equal(tips[0]['height'], 200)
assert_equal(tips[0]['status'], 'active') assert_equal(tips[0]['status'], 'active')
# Split the network and build two chains of different lengths. self.log.info("Split the network and build two chains of different lengths.")
self.split_network() self.split_network()
self.generate(self.nodes[0], 10, sync_fun=lambda: self.sync_all(self.nodes[:2])) self.generate(self.nodes[0], 10, sync_fun=lambda: self.sync_all(self.nodes[:2]))
self.generate(self.nodes[2], 20, sync_fun=lambda: self.sync_all(self.nodes[2:])) self.generate(self.nodes[2], 20, sync_fun=lambda: self.sync_all(self.nodes[2:]))
tips = self.nodes[1].getchaintips () tips = self.nodes[1].getchaintips()
assert_equal (len (tips), 1) assert_equal(len(tips), 1)
shortTip = tips[0] shortTip = tips[0]
assert_equal (shortTip['branchlen'], 0) assert_equal(shortTip['branchlen'], 0)
assert_equal (shortTip['height'], 210) assert_equal(shortTip['height'], 210)
assert_equal (tips[0]['status'], 'active') assert_equal(tips[0]['status'], 'active')
tips = self.nodes[3].getchaintips () tips = self.nodes[3].getchaintips()
assert_equal (len (tips), 1) assert_equal(len(tips), 1)
longTip = tips[0] longTip = tips[0]
assert_equal (longTip['branchlen'], 0) assert_equal(longTip['branchlen'], 0)
assert_equal (longTip['height'], 220) assert_equal(longTip['height'], 220)
assert_equal (tips[0]['status'], 'active') assert_equal(tips[0]['status'], 'active')
# Join the network halves and check that we now have two tips self.log.info("Join the network halves and check that we now have two tips")
# (at least at the nodes that previously had the short chain). # (at least at the nodes that previously had the short chain).
self.join_network () self.join_network()
tips = self.nodes[0].getchaintips () tips = self.nodes[0].getchaintips()
assert_equal (len (tips), 2) assert_equal(len(tips), 2)
assert_equal (tips[0], longTip) assert_equal(tips[0], longTip)
assert_equal (tips[1]['branchlen'], 10) assert_equal(tips[1]['branchlen'], 10)
assert_equal (tips[1]['status'], 'valid-fork') assert_equal(tips[1]['status'], 'valid-fork')
tips[1]['branchlen'] = 0 tips[1]['branchlen'] = 0
tips[1]['status'] = 'active' tips[1]['status'] = 'active'
assert_equal (tips[1], shortTip) assert_equal(tips[1], shortTip)
if __name__ == '__main__': if __name__ == '__main__':
GetChainTipsTest(__file__).main() GetChainTipsTest(__file__).main()