phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

style: remove () from assert in rpc_setban.py

Browse source
This commit is contained in:
Vasil Dimov 2021-04-26 09:56:49 +02:00
parent 24b10ebda3
commit bb719a08db
No known key found for this signature in database
GPG key ID: 54DF06F64B55CBBF
1 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
test/functional/rpc_setban.py
View file

@ -22,7 +22,7 @@ class SetBanTests(BitcoinTestFramework):
# Node 0 connects to Node 1, check that the noban permission is not granted # Node 0 connects to Node 1, check that the noban permission is not granted
self.connect_nodes(0, 1) self.connect_nodes(0, 1)
peerinfo = self.nodes[1].getpeerinfo()[0] peerinfo = self.nodes[1].getpeerinfo()[0]
assert(not 'noban' in peerinfo['permissions']) assert not "noban" in peerinfo["permissions"]
# Node 0 get banned by Node 1 # Node 0 get banned by Node 1
self.nodes[1].setban("127.0.0.1", "add") self.nodes[1].setban("127.0.0.1", "add")
@ -36,39 +36,40 @@ class SetBanTests(BitcoinTestFramework):
self.restart_node(1, ['-whitelist=127.0.0.1']) self.restart_node(1, ['-whitelist=127.0.0.1'])
self.connect_nodes(0, 1) self.connect_nodes(0, 1)
peerinfo = self.nodes[1].getpeerinfo()[0] peerinfo = self.nodes[1].getpeerinfo()[0]
assert('noban' in peerinfo['permissions']) assert "noban" in peerinfo["permissions"]
# If we remove the ban, Node 0 should be able to reconnect even without noban permission # If we remove the ban, Node 0 should be able to reconnect even without noban permission
self.nodes[1].setban("127.0.0.1", "remove") self.nodes[1].setban("127.0.0.1", "remove")
self.restart_node(1, []) self.restart_node(1, [])
self.connect_nodes(0, 1) self.connect_nodes(0, 1)
peerinfo = self.nodes[1].getpeerinfo()[0] peerinfo = self.nodes[1].getpeerinfo()[0]
assert(not 'noban' in peerinfo['permissions']) assert not "noban" in peerinfo["permissions"]
self.log.info("Test that a non-IP address can be banned/unbanned") self.log.info("Test that a non-IP address can be banned/unbanned")
node = self.nodes[1] node = self.nodes[1]
tor_addr = "pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion" tor_addr = "pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion"
ip_addr = "1.2.3.4" ip_addr = "1.2.3.4"
assert(not self.is_banned(node, tor_addr)) assert not self.is_banned(node, tor_addr)
assert(not self.is_banned(node, ip_addr)) assert not self.is_banned(node, ip_addr)
node.setban(tor_addr, "add") node.setban(tor_addr, "add")
assert(self.is_banned(node, tor_addr)) assert self.is_banned(node, tor_addr)
assert(not self.is_banned(node, ip_addr)) assert not self.is_banned(node, ip_addr)
self.log.info("Test the ban list is preserved through restart") self.log.info("Test the ban list is preserved through restart")
self.restart_node(1) self.restart_node(1)
assert(self.is_banned(node, tor_addr)) assert self.is_banned(node, tor_addr)
assert(not self.is_banned(node, ip_addr)) assert not self.is_banned(node, ip_addr)
node.setban(tor_addr, "remove") node.setban(tor_addr, "remove")
assert(not self.is_banned(self.nodes[1], tor_addr)) assert not self.is_banned(self.nodes[1], tor_addr)
assert(not self.is_banned(node, ip_addr)) assert not self.is_banned(node, ip_addr)
self.restart_node(1) self.restart_node(1)
assert(not self.is_banned(node, tor_addr)) assert not self.is_banned(node, tor_addr)
assert(not self.is_banned(node, ip_addr)) assert not self.is_banned(node, ip_addr)
if __name__ == '__main__': if __name__ == '__main__':
SetBanTests().main() SetBanTests().main()