phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-10 03:47:29 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[doc]: update reason for deducting change output weight

Browse source 
`CoinGrinder` will also produce change output, listing all the
Coin selection algorithms that produces change output is not maintainable,
just infer that remaining algorithms all might produce change.
This commit is contained in:
ismaelsadeeq 2024-02-29 10:59:50 +01:00
parent 7f61d31a5c
commit baab0d2d43
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wallet/spend.cpp
View file

@ -705,7 +705,7 @@ util::Result<SelectionResult> ChooseSelectionResult(interfaces::Chain& chain, co
} else append_error(std::move(bnb_result));
}
// As Knapsack and SRD can create change, also deduce change weight.
// Deduct change weight because remaining Coin Selection algorithms can create change output
max_selection_weight -= (coin_selection_params.change_output_size * WITNESS_SCALE_FACTOR);
// The knapsack solver has some legacy behavior where it will spend dust outputs. We retain this behavior, so don't filter for positive only here.