phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

scripted-diff: wallet: rename plain and encrypted master key variables

Browse source 
-BEGIN VERIFY SCRIPT-
sed -i s/_vMasterKey/plain_master_key/g ./src/wallet/wallet.cpp
sed -i s/kMasterKey/master_key/g ./src/wallet/wallet.cpp
sed -i "s/const MasterKeyMap::value_type& pMasterKey/const auto\& \[_, master_key\]/g" ./src/wallet/wallet.cpp
sed -i s/pMasterKey\.second/master_key/g ./src/wallet/wallet.cpp
sed -i "s/MasterKeyMap::value_type& pMasterKey/auto\& \[master_key_id, master_key\]/g" ./src/wallet/wallet.cpp
sed -i s/pMasterKey\.first/master_key_id/g ./src/wallet/wallet.cpp
-END VERIFY SCRIPT-
This commit is contained in:
Sebastian Falbesoner 2024-12-01 04:33:25 +01:00
parent 5a92077fd5
commit a8333fc9ff
1 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
src/wallet/wallet.cpp
View file

@ -620,16 +620,16 @@ static bool DecryptMasterKey(const SecureString& wallet_passphrase, const CMaste
bool CWallet::Unlock(const SecureString& strWalletPassphrase) bool CWallet::Unlock(const SecureString& strWalletPassphrase)
{ {
CKeyingMaterial _vMasterKey; CKeyingMaterial plain_master_key;
{ {
LOCK(cs_wallet); LOCK(cs_wallet);
for (const MasterKeyMap::value_type& pMasterKey : mapMasterKeys) for (const auto& [_, master_key] : mapMasterKeys)
{ {
if (!DecryptMasterKey(strWalletPassphrase, pMasterKey.second, _vMasterKey)) { if (!DecryptMasterKey(strWalletPassphrase, master_key, plain_master_key)) {
continue; // try another master key continue; // try another master key
} }
if (Unlock(_vMasterKey)) { if (Unlock(plain_master_key)) {
// Now that we've unlocked, upgrade the key metadata // Now that we've unlocked, upgrade the key metadata
UpgradeKeyMetadata(); UpgradeKeyMetadata();
// Now that we've unlocked, upgrade the descriptor cache // Now that we've unlocked, upgrade the descriptor cache
@ -649,20 +649,20 @@ bool CWallet::ChangeWalletPassphrase(const SecureString& strOldWalletPassphrase,
LOCK2(m_relock_mutex, cs_wallet); LOCK2(m_relock_mutex, cs_wallet);
Lock(); Lock();
CKeyingMaterial _vMasterKey; CKeyingMaterial plain_master_key;
for (MasterKeyMap::value_type& pMasterKey : mapMasterKeys) for (auto& [master_key_id, master_key] : mapMasterKeys)
{ {
if (!DecryptMasterKey(strOldWalletPassphrase, pMasterKey.second, _vMasterKey)) { if (!DecryptMasterKey(strOldWalletPassphrase, master_key, plain_master_key)) {
return false; return false;
} }
if (Unlock(_vMasterKey)) if (Unlock(plain_master_key))
{ {
if (!EncryptMasterKey(strNewWalletPassphrase, _vMasterKey, pMasterKey.second)) { if (!EncryptMasterKey(strNewWalletPassphrase, plain_master_key, master_key)) {
return false; return false;
} }
WalletLogPrintf("Wallet passphrase changed to an nDeriveIterations of %i\n", pMasterKey.second.nDeriveIterations); WalletLogPrintf("Wallet passphrase changed to an nDeriveIterations of %i\n", master_key.nDeriveIterations);
WalletBatch(GetDatabase()).WriteMasterKey(pMasterKey.first, pMasterKey.second); WalletBatch(GetDatabase()).WriteMasterKey(master_key_id, master_key);
if (fWasLocked) if (fWasLocked)
Lock(); Lock();
return true; return true;
@ -837,35 +837,35 @@ bool CWallet::EncryptWallet(const SecureString& strWalletPassphrase)
if (IsCrypted()) if (IsCrypted())
return false; return false;
CKeyingMaterial _vMasterKey; CKeyingMaterial plain_master_key;
_vMasterKey.resize(WALLET_CRYPTO_KEY_SIZE); plain_master_key.resize(WALLET_CRYPTO_KEY_SIZE);
GetStrongRandBytes(_vMasterKey); GetStrongRandBytes(plain_master_key);
CMasterKey kMasterKey; CMasterKey master_key;
kMasterKey.vchSalt.resize(WALLET_CRYPTO_SALT_SIZE); master_key.vchSalt.resize(WALLET_CRYPTO_SALT_SIZE);
GetStrongRandBytes(kMasterKey.vchSalt); GetStrongRandBytes(master_key.vchSalt);
if (!EncryptMasterKey(strWalletPassphrase, _vMasterKey, kMasterKey)) { if (!EncryptMasterKey(strWalletPassphrase, plain_master_key, master_key)) {
return false; return false;
} }
WalletLogPrintf("Encrypting Wallet with an nDeriveIterations of %i\n", kMasterKey.nDeriveIterations); WalletLogPrintf("Encrypting Wallet with an nDeriveIterations of %i\n", master_key.nDeriveIterations);
{ {
LOCK2(m_relock_mutex, cs_wallet); LOCK2(m_relock_mutex, cs_wallet);
mapMasterKeys[++nMasterKeyMaxID] = kMasterKey; mapMasterKeys[++nMasterKeyMaxID] = master_key;
WalletBatch* encrypted_batch = new WalletBatch(GetDatabase()); WalletBatch* encrypted_batch = new WalletBatch(GetDatabase());
if (!encrypted_batch->TxnBegin()) { if (!encrypted_batch->TxnBegin()) {
delete encrypted_batch; delete encrypted_batch;
encrypted_batch = nullptr; encrypted_batch = nullptr;
return false; return false;
} }
encrypted_batch->WriteMasterKey(nMasterKeyMaxID, kMasterKey); encrypted_batch->WriteMasterKey(nMasterKeyMaxID, master_key);
for (const auto& spk_man_pair : m_spk_managers) { for (const auto& spk_man_pair : m_spk_managers) {
auto spk_man = spk_man_pair.second.get(); auto spk_man = spk_man_pair.second.get();
if (!spk_man->Encrypt(_vMasterKey, encrypted_batch)) { if (!spk_man->Encrypt(plain_master_key, encrypted_batch)) {
encrypted_batch->TxnAbort(); encrypted_batch->TxnAbort();
delete encrypted_batch; delete encrypted_batch;
encrypted_batch = nullptr; encrypted_batch = nullptr;