From a2bc330da86b604069308f5237b77cfa77ed2b43 Mon Sep 17 00:00:00 2001 From: Pieter Wuille Date: Tue, 8 Apr 2025 15:18:03 -0400 Subject: [PATCH] feefrac test: avoid integer overflow (bugfix) --- src/test/fuzz/feefrac.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/fuzz/feefrac.cpp b/src/test/fuzz/feefrac.cpp index afa04b00ae1..2c4b34d7d4d 100644 --- a/src/test/fuzz/feefrac.cpp +++ b/src/test/fuzz/feefrac.cpp @@ -220,9 +220,9 @@ FUZZ_TARGET(feefrac_mul_div) assert(res == res_fee); // Compare approximately with CFeeRate. - if (mul64 <= std::numeric_limits::max() / 1000 && - mul64 >= std::numeric_limits::min() / 1000 && - quot_abs <= arith_uint256{std::numeric_limits::max() / 1000}) { + if (mul64 < std::numeric_limits::max() / 1000 && + mul64 > std::numeric_limits::min() / 1000 && + quot_abs < arith_uint256{std::numeric_limits::max() / 1000}) { CFeeRate feerate(mul64, (uint32_t)div); CAmount feerate_fee{feerate.GetFee(mul32)}; auto allowed_gap = static_cast(mul32 / 1000 + 3 + round_down);