phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: Add expected result assertions

Browse source 
This test returns the lowest weight solution.  Other possibilities
either exceed allowed weight or result in a higher weight.  Add an
assertion which shows that the lowest weight solution is found and
update the test description accordingly.

Remove the check that a result is returned since the expected result
assertion implies a result.
This commit is contained in:
yancy 2025-01-14 13:17:46 -06:00 • committed by yancy
parent 3c1f72a367
commit a015b7e13d
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/wallet/test/coinselector_tests.cpp
View file

@ -1168,7 +1168,7 @@ BOOST_AUTO_TEST_CASE(coin_grinder_tests)
{ {
// ############################################################################################################### // ###############################################################################################################
// 3) Test selection when some coins surpass the max allowed weight while others not. --> must find a good solution // 3) Test that the lowest-weight solution is found when some combinations would exceed the allowed weight
// ################################################################################################################ // ################################################################################################################
CAmount target = 25.33L * COIN; CAmount target = 25.33L * COIN;
int max_selection_weight = 10'000; // WU int max_selection_weight = 10'000; // WU
@ -1182,7 +1182,14 @@ BOOST_AUTO_TEST_CASE(coin_grinder_tests)
} }
return available_coins; return available_coins;
}); });
BOOST_CHECK(res); SelectionResult expected_result(CAmount(0), SelectionAlgorithm::CG);
for (int i = 0; i < 10; ++i) {
add_coin(2 * COIN, i, expected_result);
}
for (int j = 0; j < 17; ++j) {
add_coin(0.33 * COIN, j + 10, expected_result);
}
BOOST_CHECK(EquivalentResult(expected_result, *res));
// Demonstrate how following improvements reduce iteration count and catch any regressions in the future. // Demonstrate how following improvements reduce iteration count and catch any regressions in the future.
size_t expected_attempts = 37; size_t expected_attempts = 37;
BOOST_CHECK_MESSAGE(res->GetSelectionsEvaluated() == expected_attempts, strprintf("Expected %i attempts, but got %i", expected_attempts, res->GetSelectionsEvaluated())); BOOST_CHECK_MESSAGE(res->GetSelectionsEvaluated() == expected_attempts, strprintf("Expected %i attempts, but got %i", expected_attempts, res->GetSelectionsEvaluated()));