phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-25 02:33:24 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "test: p2p: check that connecting to ourself leads to disconnect"

Browse source 
This reverts commit 5d2fb14baf and
adds a TODO to add it later again once the race condition is fixed.
This commit is contained in:
Sebastian Falbesoner 2024-07-01 20:49:18 +02:00
parent fe70be5377
commit 9ec2c53701
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/functional/p2p_handshake.py
View file

@ -17,7 +17,6 @@ from test_framework.messages import (
NODE_WITNESS, NODE_WITNESS,
) )
from test_framework.p2p import P2PInterface from test_framework.p2p import P2PInterface
from test_framework.util import p2p_port
# Desirable service flags for outbound non-pruned and pruned peers. Note that # Desirable service flags for outbound non-pruned and pruned peers. Note that
@ -89,11 +88,9 @@ class P2PHandshakeTest(BitcoinTestFramework):
with node.assert_debug_log([f"feeler connection completed"]): with node.assert_debug_log([f"feeler connection completed"]):
self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True) self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True)
self.log.info("Check that connecting to ourself leads to immediate disconnect") # TODO: re-add test introduced in commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000
with node.assert_debug_log(["connected to self", "disconnecting"]): # ("test: p2p: check that connecting to ourself leads to disconnect") once
node_listen_addr = f"127.0.0.1:{p2p_port(0)}" # the race condition causing issue #30368 is fixed
node.addconnection(node_listen_addr, "outbound-full-relay", self.options.v2transport)
self.wait_until(lambda: len(node.getpeerinfo()) == 0)
if __name__ == '__main__': if __name__ == '__main__':