phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

script: small fixups/improvements for get_previous_releases.py

Browse source 
This is a small follow-up to #25650 (commit
614d4682ba) with three fixes/improvements:

- fix "Checksum did not match" detection, which was not adapted to the new
  SHA256_SUMS structure and hence never executed (the list of tarball
  names isn't directly in the dictionary's values anymore, but has to be
  extracted from the 'tarball' field of each value)
- make both help text and default tag download order deterministic by
  sorting default tags
- "--tags" argument help text: add missing space between "for" and
  "backwards"
This commit is contained in:
Sebastian Falbesoner 2022-11-28 03:22:01 +01:00
parent 9c47eb4503
commit 9b5feb76bc
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
test/get_previous_releases.py
View file

@ -136,7 +136,7 @@ def download_binary(tag, args) -> int:
tarballHash = hasher.hexdigest() tarballHash = hasher.hexdigest()
if tarballHash not in SHA256_SUMS or SHA256_SUMS[tarballHash]['tarball'] != tarball: if tarballHash not in SHA256_SUMS or SHA256_SUMS[tarballHash]['tarball'] != tarball:
if tarball in SHA256_SUMS.values(): if tarball in [v['tarball'] for v in SHA256_SUMS.values()]:
print("Checksum did not match") print("Checksum did not match")
return 1 return 1
@ -260,9 +260,8 @@ if __name__ == '__main__':
help='download release binary.') help='download release binary.')
parser.add_argument('-t', '--target-dir', action='store', parser.add_argument('-t', '--target-dir', action='store',
help='target directory.', default='releases') help='target directory.', default='releases')
parser.add_argument('tags', nargs='*', default=set( all_tags = sorted([*set([v['tag'] for v in SHA256_SUMS.values()])])
[v['tag'] for v in SHA256_SUMS.values()] parser.add_argument('tags', nargs='*', default=all_tags,
),
help='release tags. e.g.: v0.18.1 v0.20.0rc2 ' help='release tags. e.g.: v0.18.1 v0.20.0rc2 '
'(if not specified, the full list needed for ' '(if not specified, the full list needed for '
'backwards compatibility tests will be used)' 'backwards compatibility tests will be used)'