From ae6b6ea296a228f342c3c635dc9e14c101e9534d Mon Sep 17 00:00:00 2001 From: rkrux Date: Thu, 27 Mar 2025 16:21:54 +0530 Subject: [PATCH] wallet: remove redundant `Assert` call when block is disconnected It was highlighted in a PR discussion previously that the recently moved `Assert` macro call inside the block disconnected loop had been redundant for quite a while because of the presence of the `assert` macro call at the start of the function. Therefore, it is removed now. refs #https://github.com/bitcoin/bitcoin/pull/31757#discussion_r1995416821 --- src/wallet/wallet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 115005c7aa8..40d52b90f00 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -1549,7 +1549,7 @@ void CWallet::blockDisconnected(const interfaces::BlockInfo& block) int disconnect_height = block.height; for (size_t index = 0; index < block.data->vtx.size(); index++) { - const CTransactionRef& ptx = Assert(block.data)->vtx[index]; + const CTransactionRef& ptx = block.data->vtx[index]; // Coinbase transactions are not only inactive but also abandoned, // meaning they should never be relayed standalone via the p2p protocol. SyncTransaction(ptx, TxStateInactive{/*abandoned=*/index == 0});