From 99839bbfa7110c7abf22e587ae2f72c9c57d3c85 Mon Sep 17 00:00:00 2001 From: James O'Beirne Date: Mon, 11 Sep 2023 13:41:28 -0400 Subject: [PATCH] doc: add note about confusing HaveTxsDownloaded name --- src/chain.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/chain.h b/src/chain.h index 7806720ce9..78b06719f4 100644 --- a/src/chain.h +++ b/src/chain.h @@ -276,6 +276,12 @@ public: * * Does not imply the transactions are consensus-valid (ConnectTip might fail) * Does not imply the transactions are still stored on disk. (IsBlockPruned might return true) + * + * Note that this will be true for the snapshot base block, if one is loaded (and + * all subsequent assumed-valid blocks) since its nChainTx value will have been set + * manually based on the related AssumeutxoData entry. + * + * TODO: potentially change the name of this based on the fact above. */ bool HaveTxsDownloaded() const { return nChainTx != 0; }