From 2b071265c37da22f15769945fd159b50a14792a3 Mon Sep 17 00:00:00 2001
From: Tyler Chambers <me@tylerchambers.net>
Date: Fri, 30 Jul 2021 14:26:37 -0400
Subject: [PATCH] error if settings.json exists, but is unreadable

---
 src/util/settings.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/util/settings.cpp b/src/util/settings.cpp
index b92b1d30c35..846b34089dd 100644
--- a/src/util/settings.cpp
+++ b/src/util/settings.cpp
@@ -60,9 +60,15 @@ bool ReadSettings(const fs::path& path, std::map<std::string, SettingsValue>& va
     values.clear();
     errors.clear();
 
+    // Ok for file to not exist
+    if (!fs::exists(path)) return true;
+
     fsbridge::ifstream file;
     file.open(path);
-    if (!file.is_open()) return true; // Ok for file not to exist.
+    if (!file.is_open()) {
+      errors.emplace_back(strprintf("%s. Please check permissions.", path.string()));
+      return false;
+    }
 
     SettingsValue in;
     if (!in.read(std::string{std::istreambuf_iterator<char>(file), std::istreambuf_iterator<char>()})) {