phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-10 20:03:34 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix length of R check in test/key_tests.cpp:key_signature_tests

Browse source 
The code before the fix only checked the length of R value of the last
signature in the loop, and only for equality (but the length can be
less than 32)

The fixed code checks that length of the R value is less than or equal
to 32 on each iteration of the loop

The BOOST_CHECK(sig.size() <= 70) is merged with sig[3] <= 32 check,
and BOOST_CHECKs are moved outside the loop, for efficiency
This commit is contained in:
Dmitry Petukhov 2020-10-26 22:03:41 +05:00
parent 1e9e4b68f3
commit 89895773b7
No known key found for this signature in database
GPG key ID: 2301D26BDC15160D
1 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/test/key_tests.cpp
View file

@ -172,20 +172,30 @@ BOOST_AUTO_TEST_CASE(key_signature_tests)
} }
BOOST_CHECK(found); BOOST_CHECK(found);
// When entropy is not specified, we should always see low R signatures that are less than 70 bytes in 256 tries // When entropy is not specified, we should always see low R signatures that are less than or equal to 70 bytes in 256 tries
// The low R signatures should always have the value of their "length of R" byte less than or equal to 32
// We should see at least one signature that is less than 70 bytes. // We should see at least one signature that is less than 70 bytes.
found = true;
bool found_small = false; bool found_small = false;
bool found_big = false;
bool bad_sign = false;
for (int i = 0; i < 256; ++i) { for (int i = 0; i < 256; ++i) {
sig.clear(); sig.clear();
std::string msg = "A message to be signed" + ToString(i); std::string msg = "A message to be signed" + ToString(i);
msg_hash = Hash(msg); msg_hash = Hash(msg);
BOOST_CHECK(key.Sign(msg_hash, sig)); if (!key.Sign(msg_hash, sig)) {
found = sig[3] == 0x20; bad_sign = true;
BOOST_CHECK(sig.size() <= 70); break;
}
// sig.size() > 70 implies sig[3] > 32, because S is always low.
// But check both conditions anyway, just in case this implication is broken for some reason
if (sig[3] > 32 || sig.size() > 70) {
found_big = true;
break;
}
found_small |= sig.size() < 70; found_small |= sig.size() < 70;
} }
BOOST_CHECK(found); BOOST_CHECK(!bad_sign);
BOOST_CHECK(!found_big);
BOOST_CHECK(found_small); BOOST_CHECK(found_small);
} }