validation: Disable CheckForkWarningConditions for background chainstate

The comparison of m_best_invalid with the tip of the respective chainstate
makes no sense for the background chainstate, and can lead to incorrect
error messages.

Github-Pull: bitcoin/bitcoin#30962
Rebased-From: c0a0c72b4d
This commit is contained in:
Martin Zumsande 2024-09-24 14:11:20 -04:00 committed by Ava Chow
parent e24a25d882
commit 7fcd7b85c6
No known key found for this signature in database
GPG key ID: 17565732E08E5E41

View file

@ -2023,7 +2023,8 @@ void Chainstate::CheckForkWarningConditions()
// Before we get past initial download, we cannot reliably alert about forks
// (we assume we don't get stuck on a fork before finishing our initial sync)
if (m_chainman.IsInitialBlockDownload()) {
// Also not applicable to the background chainstate
if (m_chainman.IsInitialBlockDownload() || this->GetRole() == ChainstateRole::BACKGROUND) {
return;
}