phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge bitcoin/bitcoin#30026: refactor, test: Always initialize pointer

Browse source 
bd2de7ac59 refactor, test: Always initialize pointer (Hennadii Stepanov)

Pull request description:

  This change fixes MSVC warning [C4703](https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703).

  All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all remained are inherited from `common.init.vcxproj`.

  Required to simplify warning suppression porting to the CMake-based build system.

ACKs for top commit:
  maflcko:
    utACK bd2de7ac59
  sipsorcery:
    utACK bd2de7ac59.
  ryanofsky:
    Code review ACK bd2de7ac59

Tree-SHA512: 006db041d3c3697a77d9df14de86cf7c8a10804b45789df01268b2236cf6452e77dc57e89f5d5a6bc26d4b5cd483f0722d6035649c8a523b57954bb1fc810d0c
This commit is contained in:
Ryan Ofsky 2024-05-03 09:44:00 -04:00
commit 70e4d6ff1d
No known key found for this signature in database
GPG key ID: 46800E30FC748A66
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
build_msvc/test_bitcoin/test_bitcoin.vcxproj
View file

@ -59,11 +59,6 @@
<Project>{18430fef-6b61-4c53-b396-718e02850f1b}</Project> <Project>{18430fef-6b61-4c53-b396-718e02850f1b}</Project>
</ProjectReference> </ProjectReference>
</ItemGroup> </ItemGroup>
<ItemDefinitionGroup>
<ClCompile>
<DisableSpecificWarnings>4018;4244;4267;4703;4715;4805</DisableSpecificWarnings>
</ClCompile>
</ItemDefinitionGroup>
<Target Name="RawBenchHeaderGen" BeforeTargets="PrepareForBuild"> <Target Name="RawBenchHeaderGen" BeforeTargets="PrepareForBuild">
<PropertyGroup> <PropertyGroup>
<ErrorText>There was an error executing the JSON test header generation task.</ErrorText> <ErrorText>There was an error executing the JSON test header generation task.</ErrorText>

7
src/test/validation_chainstate_tests.cpp
View file

@ -12,6 +12,7 @@
#include <test/util/random.h> #include <test/util/random.h>
#include <test/util/setup_common.h> #include <test/util/setup_common.h>
#include <uint256.h> #include <uint256.h>
#include <util/check.h>
#include <validation.h> #include <validation.h>
#include <vector> #include <vector>
@ -102,14 +103,14 @@ BOOST_FIXTURE_TEST_CASE(chainstate_update_tip, TestChain100Setup)
BOOST_CHECK_EQUAL(chainman.GetAll().size(), 2); BOOST_CHECK_EQUAL(chainman.GetAll().size(), 2);
Chainstate& background_cs{*[&] { Chainstate& background_cs{*Assert([&]() -> Chainstate* {
for (Chainstate* cs : chainman.GetAll()) { for (Chainstate* cs : chainman.GetAll()) {
if (cs != &chainman.ActiveChainstate()) { if (cs != &chainman.ActiveChainstate()) {
return cs; return cs;
} }
} }
assert(false); return nullptr;
}()}; }())};
// Append the first block to the background chain. // Append the first block to the background chain.
BlockValidationState state; BlockValidationState state;