From 6768389917a8d744f1b1ada4556d3d4fe63c310e Mon Sep 17 00:00:00 2001 From: Ryan Ofsky Date: Thu, 19 Dec 2019 18:00:04 -0500 Subject: [PATCH] Fix nonsensical -norpcwhitelist behavior Treat specifying -norpcwhitelist the same as not specifying -rpcwhitelist, instead of behaving almost the same but flipping the default -rpcwhitelistdefault value. This is confusing because before this change if -norpcwhitelist was specified it would block users from calling any RPC methods. --- src/httprpc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/httprpc.cpp b/src/httprpc.cpp index 5d906ffa0c2..57893702b8b 100644 --- a/src/httprpc.cpp +++ b/src/httprpc.cpp @@ -334,7 +334,7 @@ static bool InitRPCAuthentication() } } - g_rpc_whitelist_default = gArgs.GetBoolArg("-rpcwhitelistdefault", gArgs.IsArgSet("-rpcwhitelist")); + g_rpc_whitelist_default = gArgs.GetBoolArg("-rpcwhitelistdefault", !gArgs.GetArgs("-rpcwhitelist").empty()); for (const std::string& strRPCWhitelist : gArgs.GetArgs("-rpcwhitelist")) { auto pos = strRPCWhitelist.find(':'); std::string strUser = strRPCWhitelist.substr(0, pos);