From 85e9e1f80236b7f3768bb69415ad35c80460e120 Mon Sep 17 00:00:00 2001 From: fanquake Date: Mon, 17 Jul 2023 14:44:46 +0100 Subject: [PATCH 1/2] validation: use noexcept instead of deprecated throw() ```bash CXX libbitcoin_node_a-validation.o validation.cpp:5164:30: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec] const char* what() const throw() override ^~~~~~~ validation.cpp:5164:30: note: use 'noexcept' instead const char* what() const throw() override ^~~~~~~ noexcept ``` --- src/validation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/validation.cpp b/src/validation.cpp index 5bf8bd70e27..e6def01db55 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -5161,7 +5161,7 @@ static void FlushSnapshotToDisk(CCoinsViewCache& coins_cache, bool snapshot_load struct StopHashingException : public std::exception { - const char* what() const throw() override + const char* what() const noexcept override { return "ComputeUTXOStats interrupted."; } From 047daad4f59942488163c6be8516a69291646294 Mon Sep 17 00:00:00 2001 From: fanquake Date: Mon, 17 Jul 2023 14:45:42 +0100 Subject: [PATCH 2/2] clang-tidy: turn on modernize-use-noexcept --- src/.clang-tidy | 1 + 1 file changed, 1 insertion(+) diff --git a/src/.clang-tidy b/src/.clang-tidy index 39566c0cb7f..84c9d5fb3a0 100644 --- a/src/.clang-tidy +++ b/src/.clang-tidy @@ -4,6 +4,7 @@ bugprone-argument-comment, bugprone-use-after-move, misc-unused-using-decls, modernize-use-default-member-init, +modernize-use-noexcept, modernize-use-nullptr, performance-*, -performance-inefficient-string-concatenation,