phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-11 12:22:39 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

log: call LogPrint only once with time data samples

Browse source 
This prevents malformed log entries caused by other threads
logging concurrently.
This commit is contained in:
Martin Zumsande 2021-09-21 22:33:05 +02:00
parent a8a272ac32
commit 64e1ddd255
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/timedata.cpp
View file

@ -11,6 +11,7 @@
#include <netaddress.h> #include <netaddress.h>
#include <node/ui_interface.h> #include <node/ui_interface.h>
#include <sync.h> #include <sync.h>
#include <tinyformat.h>
#include <util/system.h> #include <util/system.h>
#include <util/translation.h> #include <util/translation.h>
#include <warnings.h> #include <warnings.h>
@ -98,11 +99,12 @@ void AddTimeData(const CNetAddr& ip, int64_t nOffsetSample)
} }
if (LogAcceptCategory(BCLog::NET)) { if (LogAcceptCategory(BCLog::NET)) {
std::string log_message{"time data samples: "};
for (const int64_t n : vSorted) { for (const int64_t n : vSorted) {
LogPrint(BCLog::NET, "%+d ", n); /* Continued */ log_message += strprintf("%+d ", n);
} }
LogPrint(BCLog::NET, "| "); /* Continued */ log_message += strprintf("| median offset = %+d (%+d minutes)", nTimeOffset, nTimeOffset / 60);
LogPrint(BCLog::NET, "nTimeOffset = %+d (%+d minutes)\n", nTimeOffset, nTimeOffset / 60); LogPrint(BCLog::NET, "%s\n", log_message);
} }
} }
} }