phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-11 04:12:36 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge bitcoin/bitcoin#23654: fuzz: Rework rpc fuzz target

Browse source 
fa52a86fd3 fuzz: Rework rpc fuzz target (MarcoFalke)

Pull request description:

  Changes (reason):

  * Return `void` in `CallRPC` (the result is unused anyway)
  * Reduce the `catch`-scope of `std::runtime_error` to `RPCConvertValues` (Code clarity and easier bug-finding)
  * Crash when an internal bug is detected (bugs are bad)

ACKs for top commit:
  shaavan:
    Code Review ACK fa52a86fd3

Tree-SHA512: 576411a0e50bca9be3e6ffaf745001b1808fd37029251f8ec2c279e0671efe91d43dd81fd4ca26871c28b119e593ee2a0043d4b75f44da578f17541ee3afd696
This commit is contained in:
MarcoFalke 2021-12-03 14:02:48 +01:00
commit 57982f419e
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/test/fuzz/rpc.cpp
View file

@ -41,13 +41,17 @@ struct RPCFuzzTestingSetup : public TestingSetup {
{ {
} }
UniValue CallRPC(const std::string& rpc_method, const std::vector<std::string>& arguments) void CallRPC(const std::string& rpc_method, const std::vector<std::string>& arguments)
{ {
JSONRPCRequest request; JSONRPCRequest request;
request.context = &m_node; request.context = &m_node;
request.strMethod = rpc_method; request.strMethod = rpc_method;
request.params = RPCConvertValues(rpc_method, arguments); try {
return tableRPC.execute(request); request.params = RPCConvertValues(rpc_method, arguments);
} catch (const std::runtime_error&) {
return;
}
tableRPC.execute(request);
} }
std::vector<std::string> GetRPCCommands() const std::vector<std::string> GetRPCCommands() const
@ -353,7 +357,11 @@ FUZZ_TARGET_INIT(rpc, initialize_rpc)
} }
try { try {
rpc_testing_setup->CallRPC(rpc_command, arguments); rpc_testing_setup->CallRPC(rpc_command, arguments);
} catch (const UniValue&) { } catch (const UniValue& json_rpc_error) {
} catch (const std::runtime_error&) { const std::string error_msg{find_value(json_rpc_error, "message").get_str()};
if (error_msg.find("Internal bug detected") != std::string::npos) {
// Only allow the intentional internal bug
assert(error_msg.find("trigger_internal_bug") != std::string::npos);
}
} }
} }