mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-25 02:33:24 -03:00
random: mark RandAddPeriodic and SeedPeriodic as noexcept
The usage of MilliSleep() in SeedPeriodic (previously SeedSleep) was removed in #17270, meaning it, and its users can now be marked noexcept.
This commit is contained in:
parent
461e547877
commit
55b2cb199c
2 changed files with 4 additions and 14 deletions
|
@ -450,17 +450,7 @@ void LockingCallbackOpenSSL(int mode, int i, const char* file, int line) NO_THRE
|
|||
|
||||
/* A note on the use of noexcept in the seeding functions below:
|
||||
*
|
||||
* None of the RNG code should ever throw any exception, with the sole exception
|
||||
* of MilliSleep in SeedSleep, which can (and does) support interruptions which
|
||||
* cause a boost::thread_interrupted to be thrown.
|
||||
*
|
||||
* This means that SeedSleep, and all functions that invoke it are throwing.
|
||||
* However, we know that GetRandBytes() and GetStrongRandBytes() never trigger
|
||||
* this sleeping logic, so they are noexcept. The same is true for all the
|
||||
* GetRand*() functions that use GetRandBytes() indirectly.
|
||||
*
|
||||
* TODO: After moving away from interruptible boost-based thread management,
|
||||
* everything can become noexcept here.
|
||||
* None of the RNG code should ever throw any exception.
|
||||
*/
|
||||
|
||||
static void SeedTimestamp(CSHA512& hasher) noexcept
|
||||
|
@ -516,7 +506,7 @@ static void SeedStrengthen(CSHA512& hasher, RNGState& rng, int microseconds) noe
|
|||
Strengthen(strengthen_seed, microseconds, hasher);
|
||||
}
|
||||
|
||||
static void SeedPeriodic(CSHA512& hasher, RNGState& rng)
|
||||
static void SeedPeriodic(CSHA512& hasher, RNGState& rng) noexcept
|
||||
{
|
||||
// Everything that the 'fast' seeder includes
|
||||
SeedFast(hasher);
|
||||
|
@ -598,7 +588,7 @@ static void ProcRand(unsigned char* out, int num, RNGLevel level)
|
|||
|
||||
void GetRandBytes(unsigned char* buf, int num) noexcept { ProcRand(buf, num, RNGLevel::FAST); }
|
||||
void GetStrongRandBytes(unsigned char* buf, int num) noexcept { ProcRand(buf, num, RNGLevel::SLOW); }
|
||||
void RandAddPeriodic() { ProcRand(nullptr, 0, RNGLevel::PERIODIC); }
|
||||
void RandAddPeriodic() noexcept { ProcRand(nullptr, 0, RNGLevel::PERIODIC); }
|
||||
|
||||
bool g_mock_deterministic_tests{false};
|
||||
|
||||
|
|
|
@ -88,7 +88,7 @@ void GetStrongRandBytes(unsigned char* buf, int num) noexcept;
|
|||
*
|
||||
* Thread-safe.
|
||||
*/
|
||||
void RandAddPeriodic();
|
||||
void RandAddPeriodic() noexcept;
|
||||
|
||||
/**
|
||||
* Fast randomness source. This is seeded once with secure random data, but
|
||||
|
|
Loading…
Add table
Reference in a new issue