phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

contrib: Fix SyntaxWarning in Python base58 implementation

Browse source 
In Python integers should be compared for equality (`i == j`), not identity (`i is j`). Recent versions of CPython 3.x emit a SyntaxWarning when they encounter this incorrect usage, e.g.

```
$ python3 base58.py 
base58.py:110: SyntaxWarning: "is" with a literal. Did you mean "=="?
  assert get_bcaddress_version('15VjRaDX9zpbA8LVnbrCAFzrVzN7ixHNsC') is 0
Tests passed
```
This commit is contained in:
Alex Willmer 2020-06-15 21:36:54 +01:00 • committed by GitHub
parent 1c86ed4148
commit 47b49a05ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
contrib/testgen/base58.py
View file

@ -107,7 +107,7 @@ def get_bcaddress_version(strAddress):
if __name__ == '__main__': if __name__ == '__main__':
# Test case (from http://gitorious.org/bitcoin/python-base58.git) # Test case (from http://gitorious.org/bitcoin/python-base58.git)
assert get_bcaddress_version('15VjRaDX9zpbA8LVnbrCAFzrVzN7ixHNsC') is 0 assert get_bcaddress_version('15VjRaDX9zpbA8LVnbrCAFzrVzN7ixHNsC') == 0
_ohai = 'o hai'.encode('ascii') _ohai = 'o hai'.encode('ascii')
_tmp = b58encode(_ohai) _tmp = b58encode(_ohai)
assert _tmp == 'DYB3oMS' assert _tmp == 'DYB3oMS'