phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-11 20:32:35 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge #7827: Speed up getchaintips.

Browse source 
87049e8 Speed up getchaintips. (mrbandrews)
This commit is contained in:
Wladimir J. van der Laan 2016-04-19 10:44:44 +02:00
commit 4205ad7ca2
No known key found for this signature in database
GPG key ID: 74810B012346C9A6
1 changed files with 21 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/rpc/blockchain.cpp
View file

@ -815,17 +815,30 @@ UniValue getchaintips(const UniValue& params, bool fHelp)
LOCK(cs_main); LOCK(cs_main);
/* Build up a list of chain tips. We start with the list of all /*
known blocks, and successively remove blocks that appear as pprev * Idea: the set of chain tips is chainActive.tip, plus orphan blocks which do not have another orphan building off of them.
of another block. */ * Algorithm:
* - Make one pass through mapBlockIndex, picking out the orphan blocks, and also storing a set of the orphan block's pprev pointers.
* - Iterate through the orphan blocks. If the block isn't pointed to by another orphan, it is a chain tip.
* - add chainActive.Tip()
*/
std::set<const CBlockIndex*, CompareBlocksByHeight> setTips; std::set<const CBlockIndex*, CompareBlocksByHeight> setTips;
BOOST_FOREACH(const PAIRTYPE(const uint256, CBlockIndex*)& item, mapBlockIndex) std::set<const CBlockIndex*> setOrphans;
setTips.insert(item.second); std::set<const CBlockIndex*> setPrevs;
BOOST_FOREACH(const PAIRTYPE(const uint256, CBlockIndex*)& item, mapBlockIndex) BOOST_FOREACH(const PAIRTYPE(const uint256, CBlockIndex*)& item, mapBlockIndex)
{ {
const CBlockIndex* pprev = item.second->pprev; if (!chainActive.Contains(item.second)) {
if (pprev) setOrphans.insert(item.second);
setTips.erase(pprev); setPrevs.insert(item.second->pprev);
}
}
for (std::set<const CBlockIndex*>::iterator it = setOrphans.begin(); it != setOrphans.end(); ++it)
{
if (setPrevs.erase(*it) == 0) {
setTips.insert(*it);
}
} }
// Always report the currently active tip. // Always report the currently active tip.